Commit Graph

9 Commits

Author SHA1 Message Date
Cedric DEFORTIS
3ad9e7d8d3 Make rake lint happy by fixing WARNINGS 2017-05-04 21:17:39 +02:00
Stefan - Zipkid - Goethals
12bda76ab9 - fix conflicts when using bind::updater on all nodes. 2016-01-27 09:49:31 +01:00
Nate Riffe
3bfcc19a3e Turn params into defaults and formalize it
The `params` vs. `bind` class distinction has been blurry for a long time. I'm
formalizing it.

`params` is now `defaults` and its purpose is to gather platform-specific
variation into a single scope. These variables are related to situating a BIND
server on a particular platform and it should not ever be necessary or perhaps
even possible to change them as a matter of preference. Rather, correct values
are function of e.g. `$osfamily` or `$operatingsystem`.

The parameters of the `bind` class are limited to those that control the
server's feature set. These parameters *are* matters of preference and/or
purpose, rather than platform.

Also, I have taken some care to develop a convention for direct references to
qualified parameters where they are re-scoped into the local scope centrally at
the top first, and subsequent references are to the local value. This should
minimize future code churn and also aid readability.
2015-12-26 10:06:24 -06:00
Nate Riffe
250cb4e4c6 Put confdir in the params class, and more..
Fix a bunch of warnings whne using the bind::updater class by moving confdir to
the params class. In order for this to work, the bind and bind::updater classes
both now inherit from params. Also, fix the default value for
managed_key_directory to something that's actually falsey.
2015-12-26 01:05:52 -06:00
Nate Riffe
7a74314a1e Make it all work again.
Previous iterations and even a release were all broken. The module works again,
sorry for the interlude.

- Giving up on params and moving to module_data (WIP)
- Change the Package and Service references to the static 'bind' name
- Add a meager amount of test coverage
2015-01-08 08:09:32 -06:00
Nate Riffe
3d1d7a29dc Really fix lint issues 2014-12-12 07:33:00 -06:00
Nate Riffe
ac852d2e5b Lint cleanup 2014-12-11 07:12:19 -06:00
Nate Riffe
a66b985adb Fix up bind::updater and support rndc
I thought I fixed rndc a while ago... not quite. Do it now. Make bind::updater
actually work (incomplete last time)
2014-06-27 14:43:46 -05:00
Nate Riffe
09cf90342b Add bind::updater class
Create a bind::updater class to add support for the dns_rr resource on systems
that will not have a BIND server installed or running.
2014-06-15 10:44:15 -05:00