Commit Graph

9 Commits

Author SHA1 Message Date
Nate Riffe
3bfcc19a3e Turn params into defaults and formalize it
The `params` vs. `bind` class distinction has been blurry for a long time. I'm
formalizing it.

`params` is now `defaults` and its purpose is to gather platform-specific
variation into a single scope. These variables are related to situating a BIND
server on a particular platform and it should not ever be necessary or perhaps
even possible to change them as a matter of preference. Rather, correct values
are function of e.g. `$osfamily` or `$operatingsystem`.

The parameters of the `bind` class are limited to those that control the
server's feature set. These parameters *are* matters of preference and/or
purpose, rather than platform.

Also, I have taken some care to develop a convention for direct references to
qualified parameters where they are re-scoped into the local scope centrally at
the top first, and subsequent references are to the local value. This should
minimize future code churn and also aid readability.
2015-12-26 10:06:24 -06:00
Nate Riffe
250cb4e4c6 Put confdir in the params class, and more..
Fix a bunch of warnings whne using the bind::updater class by moving confdir to
the params class. In order for this to work, the bind and bind::updater classes
both now inherit from params. Also, fix the default value for
managed_key_directory to something that's actually falsey.
2015-12-26 01:05:52 -06:00
Aimon Bustardo
0479c58b7c Add missing bind tools package and improve rspec tests
Change-Id: I0b4680ce11fe604917fce654d68c2bec17c05438
2015-07-07 15:33:16 -07:00
Trevor Smith
7a6250d00a change tests and hiera fixtures to allow tests to pass with the changes to the config path 2015-03-19 12:14:28 -04:00
Nate Riffe
7a74314a1e Make it all work again.
Previous iterations and even a release were all broken. The module works again,
sorry for the interlude.

- Giving up on params and moving to module_data (WIP)
- Change the Package and Service references to the static 'bind' name
- Add a meager amount of test coverage
2015-01-08 08:09:32 -06:00
Nate Riffe
f7740f2a05 Make some assertions about ordering 2014-12-19 11:27:38 -06:00
Nate Riffe
78173fa80b Add an example to assert the service 2014-12-17 07:07:59 -06:00
Nate Riffe
636e77356a Add an assertion.
Mostly, this implies adding all of the boilerplate needed to start using
rspec-puppet with fixtures and whatnot.
2014-12-15 14:05:53 -06:00
Nate Riffe
bf7f5f93fc 0 Examples, 0 Failures 2014-12-14 07:13:39 -06:00