unkin/agent-sandbox
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Test uncovered launch-dir refusals #4

Merged
benvin merged 1 commits from benvin/launch-dir-tests into main 2026-10-25 01:08:03 +11:00
Conversation 0 Commits 1 Files Changed 1
+79
unkin-agent commented 2026-10-24 20:43:25 +11:00
Member
Copy Link
Copy Source

Several launch-dir protections can be deleted without any test failing, because existing cases are refused earlier by an overlapping rule.

  • add a default-root test that only the forbidden-roots check refuses
  • add a test refusing the dir holding the resolved allowed-paths file
  • add allowed-paths tests for dot-dir and $HOME-containing roots
  • add a launch test refusing a symlink whose resolved source contains :
Several launch-dir protections can be deleted without any test failing, because existing cases are refused earlier by an overlapping rule. - add a default-root test that only the forbidden-roots check refuses - add a test refusing the dir holding the resolved allowed-paths file - add allowed-paths tests for dot-dir and $HOME-containing roots - add a launch test refusing a symlink whose resolved source contains `:`
unkin-agent added 1 commit 2026-10-24 20:43:25 +11:00
Test launch-dir refusals not covered elsewhere
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
588ef2f8c2
benvin merged commit 757e1c069c into main 2026-10-25 01:08:03 +11:00
benvin deleted branch benvin/launch-dir-tests 2026-10-25 01:08:03 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/agent-sandbox#4
Delete Branch "benvin/launch-dir-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?