unkin/agent-tools
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

Name the cause when a watch stops on an auth failure #18

Merged
benvin merged 2 commits from benvin/watchpr-auth-failure into main 2026-09-19 17:04:18 +10:00
Conversation 0 Commits 2 Files Changed 6
+387 -17
unkin-agent commented 2026-09-19 16:13:48 +10:00
Member
Copy Link
Copy Source

A 401/403 was handled as one thing, so watchpr re-minted on every rejection and reported "token expired" for a permission boundary or an anonymous run that had no token to expire, sending the reader after the wrong problem.

  • Classify a 401/403 as a rejected credential, a permission denial, or a request that carried no token, and re-mint only the first
  • Reject a re-minted empty token instead of replaying anonymously
  • Report the classified cause from --once as well as from the watch loop
  • Document watchpr's exit behaviour per cause
A 401/403 was handled as one thing, so watchpr re-minted on every rejection and reported "token expired" for a permission boundary or an anonymous run that had no token to expire, sending the reader after the wrong problem. - Classify a 401/403 as a rejected credential, a permission denial, or a request that carried no token, and re-mint only the first - Reject a re-minted empty token instead of replaying anonymously - Report the classified cause from `--once` as well as from the watch loop - Document watchpr's exit behaviour per cause
unkin-agent added 1 commit 2026-09-19 16:13:48 +10:00
Name the cause when a watch stops on an auth failure
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
90ce747a61 
A 401/403 was handled as one thing, so watchpr re-minted on every
rejection and reported "token expired" for a permission boundary or an
anonymous run that had no token to expire, sending the reader after the
wrong problem.

Classify a 401/403 as a rejected credential, a permission denial, or a
request that carried no token, and re-mint only the first.
Reject a re-minted empty token instead of replaying anonymously.
Report the classified cause from --once as well as from the watch loop.
Document watchpr's exit behaviour per cause.
unkin-agent added 1 commit 2026-09-19 16:40:50 +10:00
Merge main into watchpr auth failure branch
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ff8ac5ea2d 
Keep both sides' additions to client_test.go and adopt main's
EditPROptions -> EditOptions rename.
benvin merged commit d77607c4f0 into main 2026-09-19 17:04:18 +10:00
benvin deleted branch benvin/watchpr-auth-failure 2026-09-19 17:04:19 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/agent-tools#18
Delete Branch "benvin/watchpr-auth-failure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?