unkin/argocd-apps
2
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(traefik): add instance labels to GatewayClasses #137

Merged
unkinben merged 1 commits from benvin/fix-gatewayclass-labels into main 2026-05-23 00:23:19 +10:00
Conversation 0 Commits 1 Files Changed 2
+4
unkinben commented 2026-05-23 00:19:47 +10:00
Owner
Copy Link
Copy Source

Problem

GatewayClasses were Unknown even after controllerName was fixed. The kubernetesGateway labelSelector applies to all watched resources, including GatewayClasses themselves. Since neither GatewayClass had a traefik.io/instance label, both Traefik instances filtered them out and never accepted them.

Fix

  • gatewayclass-internal.yaml: add traefik.io/instance: internal
  • gatewayclass-external.yaml: add traefik.io/instance: external

Test plan

  • kubectl get gatewayclass shows both as Accepted: True
## Problem GatewayClasses were `Unknown` even after controllerName was fixed. The `kubernetesGateway` `labelSelector` applies to all watched resources, including GatewayClasses themselves. Since neither GatewayClass had a `traefik.io/instance` label, both Traefik instances filtered them out and never accepted them. ## Fix - `gatewayclass-internal.yaml`: add `traefik.io/instance: internal` - `gatewayclass-external.yaml`: add `traefik.io/instance: external` ## Test plan - [ ] `kubectl get gatewayclass` shows both as `Accepted: True`
unkinben added 1 commit 2026-05-23 00:19:47 +10:00
fix(traefik): add instance labels to GatewayClasses
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/kubeconform Pipeline was successful
Details
a5f1fefe1d 
The kubernetesGateway labelSelector applies to all watched resources
including GatewayClasses. Without traefik.io/instance labels, neither
Traefik instance could see or accept its own GatewayClass.
unkinben merged commit 64dc5a0242 into main 2026-05-23 00:23:19 +10:00
unkinben deleted branch benvin/fix-gatewayclass-labels 2026-05-23 00:23:19 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/argocd-apps#137
Delete Branch "benvin/fix-gatewayclass-labels"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?