fix: show local-repo files in the cached-objects UI (#99)

## Why

Local repos store uploaded files in the \`local_files\` table, whereas remote/proxy repos cache into the \`artifacts\` table. The shared **Cached Objects** page always queried the artifacts table via \`/api/v2/remotes/{name}/objects\`, so files uploaded to a local repo (e.g. an internal RPM) were fully stored and servable but showed as **0 objects** in the UI.

## Changes

- Add \`ListLocalArtifacts\`, joining \`local_files\` with \`blobs\` and returning \`models.Artifact\`-shaped rows (size from the blob; access/fetch counters zero and timestamps derived from \`created_at\`, since local files track no access).
- Add \`LocalRoutes\` to the objects handler: \`listLocal\` reads \`local_files\`, \`evictLocal\` deletes via \`DeleteLocalFile\`. Extract shared page/per_page parsing into \`pageBounds\`.
- Mount \`/api/v2/locals/{name}/objects\` (GET + DELETE) in the server.
- Add \`listLocalObjects\`/\`evictLocalObject\` to the UI client and route the Objects page to them when viewing a local repo.
- Cover the listing and eviction paths with a dockerised test.

## Notes

Generated \`repodata/*\` files are not listed — they are produced on the fly from \`rpm_metadata\` and never stored in \`local_files\`, which matches how the repo serves them.

Reviewed-on: #99
Co-authored-by: Ben Vincent <ben@unkin.net>
Co-committed-by: Ben Vincent <ben@unkin.net>

internal/api/v2/local.go

@@ -185,35 +185,13 @@ func (h *LocalHandler) remove(w http.ResponseWriter, r *http.Request) {
 	repoName := chi.URLParam(r, "name")
 	filePath := chi.URLParam(r, "*")
 
-	if err := deleteLocalFile(r.Context(), h.db, repoName, filePath); err != nil {
+	if err := h.db.DeleteLocalFile(r.Context(), repoName, filePath); err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
 	w.WriteHeader(http.StatusNoContent)
 }
 
-// deleteLocalFile removes a local file and runs the provider's post-delete hook,
-// so provider-derived state (e.g. RPM metadata that feeds generated repodata)
-// stops referencing a package that no longer exists.
-func deleteLocalFile(ctx context.Context, db *database.DB, repoName, filePath string) error {
-	if err := db.DeleteLocalFile(ctx, repoName, filePath); err != nil {
-		return err
-	}
-
-	remote, err := db.GetRemote(ctx, repoName)
-	if err != nil {
-		return nil // file is gone; no repo left to resolve a cleanup hook from
-	}
-	prov, err := provider.Get(remote.PackageType)
-	if err != nil {
-		return nil
-	}
-	if hook, ok := prov.(provider.PostDeleteHook); ok {
-		return hook.AfterDelete(ctx, repoName, filePath, db)
-	}
-	return nil
-}
-
 func (h *LocalHandler) DB() *database.DB {
 	return h.db
 }

internal/api/v2/local_evict_cleanup_test.go

@@ -1,75 +0,0 @@
-package v2
-
-import (
-	"context"
-	"net/http/httptest"
-	"testing"
-
-	"github.com/go-chi/chi/v5"
-
-	"git.unkin.net/unkin/artifactapi/internal/database"
-	"git.unkin.net/unkin/artifactapi/internal/provider"
-	_ "git.unkin.net/unkin/artifactapi/internal/provider/rpm" // register the rpm provider so its PostDeleteHook runs
-	"git.unkin.net/unkin/artifactapi/pkg/models"
-)
-
-// TestLocalEvictCleansRPMMetadata verifies that evicting an RPM from a local
-// repo also removes the derived rpm_metadata row, so generated repodata stops
-// listing the deleted package.
-func TestLocalEvictCleansRPMMetadata(t *testing.T) {
-	if testDSN == "" {
-		t.Skip("Docker unavailable")
-	}
-	ctx := context.Background()
-	db, err := database.New(testDSN)
-	if err != nil {
-		t.Fatal(err)
-	}
-	defer db.Close()
-
-	const repo = "rpm-evict-cleanup"
-	if err := db.CreateRemote(ctx, &models.Remote{Name: repo, PackageType: models.PackageRPM, RepoType: models.RepoTypeLocal}); err != nil {
-		t.Fatal(err)
-	}
-
-	const hash = "sha256:bb22"
-	const path = "Packages/example-0.1.0-1.x86_64.rpm"
-	if err := db.UpsertBlob(ctx, hash, "blobs/bb/22", 2048, "application/x-rpm"); err != nil {
-		t.Fatal(err)
-	}
-	if err := db.CreateLocalFile(ctx, repo, path, hash); err != nil {
-		t.Fatal(err)
-	}
-	if err := db.InsertRPMMetadata(ctx, &provider.RPMMetadata{
-		RepoName: repo, FilePath: path, ContentHash: hash,
-		Name: "example", Version: "0.1.0", Release: "1", Arch: "x86_64",
-		Requires: []provider.RPMDep{}, Provides: []provider.RPMDep{},
-		Files: []provider.RPMFile{}, Changelogs: []provider.RPMChangelog{},
-	}); err != nil {
-		t.Fatal(err)
-	}
-
-	h := NewObjectsHandler(db)
-	router := chi.NewRouter()
-	router.Route("/locals/{name}/objects", func(r chi.Router) {
-		r.Delete("/*", h.LocalRoutes().ServeHTTP)
-	})
-
-	del := httptest.NewRequest("DELETE", "/locals/"+repo+"/objects/"+path, nil)
-	dw := httptest.NewRecorder()
-	router.ServeHTTP(dw, del)
-	if dw.Code != 204 {
-		t.Fatalf("evict = %d, want 204", dw.Code)
-	}
-
-	if f, _ := db.GetLocalFile(ctx, repo, path); f != nil {
-		t.Fatalf("local file still present after evict: %+v", f)
-	}
-	entries, err := db.ListRPMMetadataEntries(ctx, repo)
-	if err != nil {
-		t.Fatal(err)
-	}
-	if len(entries) != 0 {
-		t.Fatalf("rpm_metadata still present after evict: %+v", entries)
-	}
-}

internal/api/v2/objects.go

@@ -75,7 +75,7 @@ func (h *ObjectsHandler) evictLocal(w http.ResponseWriter, r *http.Request) {
 	repoName := chi.URLParam(r, "name")
 	path := chi.URLParam(r, "*")
 
-	if err := deleteLocalFile(r.Context(), h.db, repoName, path); err != nil {
+	if err := h.db.DeleteLocalFile(r.Context(), repoName, path); err != nil {
 		http.Error(w, fmt.Sprintf("evict failed: %v", err), http.StatusInternalServerError)
 		return
 	}

internal/database/rpm_metadata.go

@@ -32,11 +32,6 @@ func (db *DB) InsertRPMMetadata(ctx context.Context, meta *provider.RPMMetadata)
 	return err
 }
 
-func (db *DB) DeleteRPMMetadata(ctx context.Context, repoName, filePath string) error {
-	_, err := db.Pool.Exec(ctx, `DELETE FROM rpm_metadata WHERE repo_name = $1 AND file_path = $2`, repoName, filePath)
-	return err
-}
-
 type RPMMetadataRow struct {
 	RepoName      string
 	FilePath      string

internal/provider/provider.go

@@ -53,20 +53,10 @@ type PostUploadHook interface {
 	AfterUpload(ctx context.Context, repoName, storagePath, contentHash string, blobs BlobReader, db MetadataStore)
 }
 
-// PostDeleteHook lets a provider clean up derived state (e.g. RPM metadata that
-// feeds generated repodata) after a local file is removed.
-type PostDeleteHook interface {
-	AfterDelete(ctx context.Context, repoName, storagePath string, db MetadataDeleter) error
-}
-
 type MetadataStore interface {
 	InsertRPMMetadata(ctx context.Context, meta *RPMMetadata) error
 }
 
-type MetadataDeleter interface {
-	DeleteRPMMetadata(ctx context.Context, repoName, filePath string) error
-}
-
 type RPMMetadataReader interface {
 	ListRPMMetadataEntries(ctx context.Context, repoName string) ([]RPMMetadata, error)
 }

internal/provider/rpm/rpm.go

@@ -151,15 +151,6 @@ func (p *Provider) AfterUpload(ctx context.Context, repoName, storagePath, conte
 	slog.Info("rpm metadata: parsed", "repo", repoName, "name", meta.Name, "version", meta.Version, "arch", meta.Arch)
 }
 
-func (p *Provider) AfterDelete(ctx context.Context, repoName, storagePath string, db provider.MetadataDeleter) error {
-	if err := db.DeleteRPMMetadata(ctx, repoName, storagePath); err != nil {
-		slog.Error("rpm metadata: delete failed", "repo", repoName, "path", storagePath, "error", err)
-		return err
-	}
-	slog.Info("rpm metadata: deleted", "repo", repoName, "path", storagePath)
-	return nil
-}
-
 func rpmDepFromEntry(e rpmlib.Dependency) provider.RPMDep {
 	dep := provider.RPMDep{Name: e.Name()}
 	if e.Flags() != 0 {