Compare commits
7 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| e5313342ba | |||
| f0ee593164 | |||
| 6cf84c4f6c | |||
| cfb1f93d48 | |||
| 9294686ea6 | |||
| fe9de81afa | |||
| 2905ec99e4 |
@@ -23,10 +23,11 @@ API: `http://localhost:8000` | Frontend: `http://localhost:5173`
|
|||||||
Providers classify paths automatically. Users only configure what to proxy and TTLs.
|
Providers classify paths automatically. Users only configure what to proxy and TTLs.
|
||||||
|
|
||||||
Classification precedence, TTLs and eviction for every remote: [docs/common/caching.md](docs/common/caching.md).
|
Classification precedence, TTLs and eviction for every remote: [docs/common/caching.md](docs/common/caching.md).
|
||||||
|
Write authentication and per-client token usage: [docs/common/auth.md](docs/common/auth.md).
|
||||||
|
|
||||||
Each type's paths, Terraform examples and local/virtual behaviour are in `docs/<type>/`:
|
Each type's paths, Terraform examples and local/virtual behaviour are in `docs/<type>/`:
|
||||||
|
|
||||||
- `alpine`: [remote](docs/alpine/remote.md), [remote-github](docs/alpine/remote-github.md)
|
- `alpine`: [remote](docs/alpine/remote.md), [remote-github](docs/alpine/remote-github.md), [virtual](docs/alpine/virtual.md)
|
||||||
- `ansible`: [remote](docs/ansible/remote.md), [local](docs/ansible/local.md), [virtual](docs/ansible/virtual.md)
|
- `ansible`: [remote](docs/ansible/remote.md), [local](docs/ansible/local.md), [virtual](docs/ansible/virtual.md)
|
||||||
- `cargo`: [remote](docs/cargo/remote.md)
|
- `cargo`: [remote](docs/cargo/remote.md)
|
||||||
- `deb`: [remote](docs/deb/remote.md), [remote-github](docs/deb/remote-github.md), [virtual](docs/deb/virtual.md)
|
- `deb`: [remote](docs/deb/remote.md), [remote-github](docs/deb/remote-github.md), [virtual](docs/deb/virtual.md)
|
||||||
@@ -41,6 +42,7 @@ Each type's paths, Terraform examples and local/virtual behaviour are in `docs/<
|
|||||||
- `pypi`: [remote](docs/pypi/remote.md)
|
- `pypi`: [remote](docs/pypi/remote.md)
|
||||||
- `rpm`: [remote](docs/rpm/remote.md), [remote-github](docs/rpm/remote-github.md)
|
- `rpm`: [remote](docs/rpm/remote.md), [remote-github](docs/rpm/remote-github.md)
|
||||||
- `terraform`: [remote](docs/terraform/remote.md), [local](docs/terraform/local.md)
|
- `terraform`: [remote](docs/terraform/remote.md), [local](docs/terraform/local.md)
|
||||||
|
- `vcs`: [remote](docs/vcs/remote.md)
|
||||||
|
|
||||||
### GitHub authentication
|
### GitHub authentication
|
||||||
|
|
||||||
@@ -207,8 +209,9 @@ additive and idempotent for the same reason; a test enforces it.
|
|||||||
| `GITHUB_APP_INSTALLATION_ID` | | GitHub App installation id |
|
| `GITHUB_APP_INSTALLATION_ID` | | GitHub App installation id |
|
||||||
| `GITHUB_APP_PRIVATE_KEY` | | GitHub App private key, inline PEM |
|
| `GITHUB_APP_PRIVATE_KEY` | | GitHub App private key, inline PEM |
|
||||||
| `GITHUB_APP_PRIVATE_KEY_PATH` | | GitHub App private key, file path (alternative to inline PEM) |
|
| `GITHUB_APP_PRIVATE_KEY_PATH` | | GitHub App private key, file path (alternative to inline PEM) |
|
||||||
| `ARTIFACTAPI_OIDC_ISSUER` | | OIDC issuer URL (e.g. Vault `https://vault.service.consul:8200/v1/identity/oidc`). When set, `POST /api/v2/remotes`, `POST /api/v2/virtuals` and `PUT`/`DELETE` on `/api/v2/{remotes,virtuals}/{name}` require `Authorization: Bearer <jwt>` verified against the issuer's JWKS. Uploads, object/file deletes, probe, reads and `/v2` stay open. Unset = no auth |
|
| `ARTIFACTAPI_OIDC_ISSUER` | | OIDC issuer URL (e.g. Vault `https://vault.example.com/v1/identity/oidc`). When set, `POST /api/v2/remotes`, `POST /api/v2/virtuals` and `PUT`/`DELETE` on `/api/v2/{remotes,virtuals}/{name}` require a token verified against the issuer's JWKS. Unset = no auth. See [docs/common/auth.md](docs/common/auth.md) |
|
||||||
| `ARTIFACTAPI_OIDC_AUDIENCE` | | Comma-separated allowed `aud` values (e.g. the Vault OIDC role's client_id). Required when `ARTIFACTAPI_OIDC_ISSUER` is set |
|
| `ARTIFACTAPI_OIDC_AUDIENCE` | | Comma-separated allowed `aud` values (e.g. the Vault OIDC role's client_id). Required when `ARTIFACTAPI_OIDC_ISSUER` is set |
|
||||||
|
| `ARTIFACTAPI_AUTH_UPLOADS` | `false` | Also require a token for every local repo write: file uploads/deletes, object evictions, `/api/v1/local` publishes and `/v2` push. Requires `ARTIFACTAPI_OIDC_ISSUER` |
|
||||||
|
|
||||||
## Development
|
## Development
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,30 @@
|
|||||||
|
# `alpine` virtual
|
||||||
|
|
||||||
|
An alpine virtual serves one apk repository over local and remote alpine
|
||||||
|
members at `/api/v1/virtual/<name>/`.
|
||||||
|
|
||||||
|
- `<dir>/APKINDEX.tar.gz` merges each member's index for the same `<dir>`
|
||||||
|
(e.g. `x86_64/`); on a duplicate (P, V, A) the earlier member wins. A member
|
||||||
|
that 404s for that directory is skipped.
|
||||||
|
- apk builds download paths itself (`<dir>/<P>-<V>.apk`), so the virtual 302s
|
||||||
|
each download to the member whose index listed it.
|
||||||
|
- The merged index is unsigned, like local and `github_alpine` indexes: clients
|
||||||
|
need `--allow-untrusted` (packages keep their own signatures).
|
||||||
|
- Any other member error fails the request with 502. Merges are cached for 60s
|
||||||
|
per directory, up to 32 directories per virtual.
|
||||||
|
|
||||||
|
```hcl
|
||||||
|
resource "artifactapi_virtual" "alpine" {
|
||||||
|
name = "alpine"
|
||||||
|
package_type = "alpine"
|
||||||
|
members = [artifactapi_local_alpine.internal.name, artifactapi_remote_github_alpine.tool.name]
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
```sh
|
||||||
|
echo https://artifactapi.example.com/api/v1/virtual/alpine >> /etc/apk/repositories
|
||||||
|
apk update --allow-untrusted
|
||||||
|
apk add --allow-untrusted mytool
|
||||||
|
```
|
||||||
|
|
||||||
|
Upload to the local member directly; the virtual is read-only.
|
||||||
@@ -2,7 +2,7 @@
|
|||||||
|
|
||||||
A local `ansible` repo is a Galaxy v3 server: `ansible-galaxy collection publish`
|
A local `ansible` repo is a Galaxy v3 server: `ansible-galaxy collection publish`
|
||||||
and `ansible-galaxy collection install` work against `/api/v1/local/<repo>`.
|
and `ansible-galaxy collection install` work against `/api/v1/local/<repo>`.
|
||||||
`publish` needs an API key; any value works.
|
`publish` needs an API key; any value works unless [uploads are gated](../common/auth.md).
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
ansible-galaxy collection build
|
ansible-galaxy collection build
|
||||||
|
|||||||
@@ -0,0 +1,53 @@
|
|||||||
|
# Write authentication
|
||||||
|
|
||||||
|
artifactapi verifies writes against an OIDC issuer's JWKS, such as a Vault
|
||||||
|
identity OIDC role. Reads, probes and anonymous pulls never need a token.
|
||||||
|
|
||||||
|
| Variable | Gates |
|
||||||
|
|---|---|
|
||||||
|
| `ARTIFACTAPI_OIDC_ISSUER` + `ARTIFACTAPI_OIDC_AUDIENCE` | creating, updating and deleting remotes and virtuals |
|
||||||
|
| `ARTIFACTAPI_AUTH_UPLOADS=true` | also every local repo write: `PUT`/`DELETE /api/v2/remotes/<name>/files/*`, `DELETE /api/v2/{remotes,locals}/<name>/objects/*`, `PUT`/`POST`/`DELETE /api/v1/local/<repo>/*` (npm publish, gem push/yank, ansible-galaxy publish) and Docker Registry V2 push/delete under `/v2` |
|
||||||
|
|
||||||
|
Any token from the issuer whose `aud` is in `ARTIFACTAPI_OIDC_AUDIENCE` may
|
||||||
|
write to every repo.
|
||||||
|
|
||||||
|
## Minting a token
|
||||||
|
|
||||||
|
```sh
|
||||||
|
vault read -field=token identity/oidc/token/<role> > token
|
||||||
|
```
|
||||||
|
|
||||||
|
The role's `client_id` must be one of the configured audiences.
|
||||||
|
|
||||||
|
## Passing the token
|
||||||
|
|
||||||
|
The token is accepted as `Authorization: Bearer <token>`, as `Token <token>`,
|
||||||
|
as the password of HTTP Basic credentials with any username, or as a bare
|
||||||
|
header value.
|
||||||
|
|
||||||
|
```sh
|
||||||
|
# curl
|
||||||
|
curl -fsSL -H "Authorization: Bearer $(cat token)" --upload-file f.tgz \
|
||||||
|
https://artifactapi.example.com/api/v2/remotes/<repo>/files/f.tgz
|
||||||
|
curl -fsSL -u "ci:$(cat token)" --upload-file f.tgz \
|
||||||
|
https://artifactapi.example.com/api/v2/remotes/<repo>/files/f.tgz
|
||||||
|
|
||||||
|
# docker / podman / helm (OCI): any username, token as password
|
||||||
|
docker login artifactapi.example.com -u ci --password-stdin < token
|
||||||
|
helm registry login artifactapi.example.com -u ci --password-stdin < token
|
||||||
|
|
||||||
|
# npm (.npmrc)
|
||||||
|
//artifactapi.example.com/api/v1/local/<repo>/:_authToken=<token>
|
||||||
|
|
||||||
|
# gem
|
||||||
|
GEM_HOST_API_KEY="$(cat token)" gem push --host https://artifactapi.example.com/api/v1/local/<repo> mygem-1.0.0.gem
|
||||||
|
|
||||||
|
# ansible-galaxy
|
||||||
|
ansible-galaxy collection publish c.tar.gz \
|
||||||
|
--server https://artifactapi.example.com/api/v1/local/<repo>/ --api-key "$(cat token)"
|
||||||
|
```
|
||||||
|
|
||||||
|
With uploads gated, `/v2/` answers anonymous requests with a Bearer challenge
|
||||||
|
pointing at `/v2/token`. That endpoint returns the verified Basic password as
|
||||||
|
the registry token, or an anonymous token that only reads, so `docker pull`
|
||||||
|
keeps working without a login.
|
||||||
+21
-2
@@ -15,7 +15,8 @@ Every proxied request on a remote is classified as **denied**, **immutable** or
|
|||||||
| `mutable_ttl` | Seconds a mutable path stays fresh. `0` also means never expires. Omitted on create, it defaults to `3600`; omitted on update, the stored value is kept. |
|
| `mutable_ttl` | Seconds a mutable path stays fresh. `0` also means never expires. Omitted on create, it defaults to `3600`; omitted on update, the stored value is kept. |
|
||||||
| `check_mutable` | When a mutable path's `mutable_ttl` expires, sends a conditional `HEAD` (`If-None-Match`) with the stored upstream ETag. A `304` re-arms the TTL and serves the stored copy; anything else refetches in full. The ETag is kept for `max(10 × mutable_ttl, 7 days)`, re-armed on each `304`, so idle paths age out. It is only stored when `check_mutable` is set and `mutable_ttl` is non-zero, and never for immutable paths. |
|
| `check_mutable` | When a mutable path's `mutable_ttl` expires, sends a conditional `HEAD` (`If-None-Match`) with the stored upstream ETag. A `304` re-arms the TTL and serves the stored copy; anything else refetches in full. The ETag is kept for `max(10 × mutable_ttl, 7 days)`, re-armed on each `304`, so idle paths age out. It is only stored when `check_mutable` is set and `mutable_ttl` is non-zero, and never for immutable paths. |
|
||||||
| `stale_on_error` | On an upstream network error, serve the stored copy instead of failing. |
|
| `stale_on_error` | On an upstream network error, serve the stored copy instead of failing. |
|
||||||
| `quarantine_enabled` / `quarantine_days` | Stored on the remote but not enforced by the proxy yet. |
|
| `serve_stale` | rpm/deb/alpine virtual members only. When a virtual re-merges, use this member's previous index at once and refresh it in the background; the next merge picks up the refresh. The first merge still waits, and so does any merge once the previous index is over an hour old, so a member that keeps failing surfaces its error. Default `false`. |
|
||||||
|
| `quarantine_enabled` / `quarantine_days` | Refuses immutable artifacts published less than `quarantine_days` (default `3`) ago. See [Quarantine](#quarantine). |
|
||||||
| `mirrorlist` / `mirror_strategy` | rpm/deb/alpine only. Upstream pool is `[base_url] + mirrorlist`; `round_robin` (default) rotates the starting mirror, `least_conn` starts at the one with the fewest in-flight requests. Network errors and 5xx fail over to the next mirror; other statuses return as-is. |
|
| `mirrorlist` / `mirror_strategy` | rpm/deb/alpine only. Upstream pool is `[base_url] + mirrorlist`; `round_robin` (default) rotates the starting mirror, `least_conn` starts at the one with the fewest in-flight requests. Network errors and 5xx fail over to the next mirror; other statuses return as-is. |
|
||||||
|
|
||||||
## Precedence
|
## Precedence
|
||||||
@@ -52,6 +53,24 @@ So `blocklist` beats the allowlist, and `immutable_patterns` beats
|
|||||||
Concurrent misses on one path share a fetch lock. Waiters poll the store for
|
Concurrent misses on one path share a fetch lock. Waiters poll the store for
|
||||||
up to 5s instead of all going upstream.
|
up to 5s instead of all going upstream.
|
||||||
|
|
||||||
|
## Quarantine
|
||||||
|
|
||||||
|
With `quarantine_enabled`, an uncached **immutable** path whose upstream copy
|
||||||
|
was published less than `quarantine_days` ago answers `403` and is not cached:
|
||||||
|
|
||||||
|
```json
|
||||||
|
{"error": "quarantined: published 2026-10-24T09:00:00Z, available from 2026-10-27T09:00:00Z",
|
||||||
|
"published": "2026-10-24T09:00:00Z", "available": "2026-10-27T09:00:00Z"}
|
||||||
|
```
|
||||||
|
|
||||||
|
- `quarantine_days` must be at least `1` when quarantine is enabled.
|
||||||
|
- The publish time is the upstream `Last-Modified` header (capped at now), else the first time artifactapi was asked for the path.
|
||||||
|
- If that first-seen lookup fails, the path answers `503` with `Retry-After` instead.
|
||||||
|
- Mutable paths (indexes, metadata) are never quarantined.
|
||||||
|
- Paths already cached keep serving, including ones cached before quarantine was enabled.
|
||||||
|
- A virtual redirects to the member that owns the path, so its `403` reaches the client. A goproxy virtual probing for an unlisted version skips a quarantining member and only redirects to it when no other member serves the version.
|
||||||
|
- Indexes still list fresh versions, so a client resolving "latest" may pick one and get the `403`.
|
||||||
|
|
||||||
## Eviction
|
## Eviction
|
||||||
|
|
||||||
```sh
|
```sh
|
||||||
@@ -98,4 +117,4 @@ Each type's page lists its auto-detected mutable and immutable paths:
|
|||||||
[docker](../docker/remote.md), [generic](../generic/remote.md), [gems](../gems/remote.md), [goproxy](../goproxy/remote.md),
|
[docker](../docker/remote.md), [generic](../generic/remote.md), [gems](../gems/remote.md), [goproxy](../goproxy/remote.md),
|
||||||
[helm](../helm/remote.md), [npm](../npm/remote.md), [nuget](../nuget/remote.md),
|
[helm](../helm/remote.md), [npm](../npm/remote.md), [nuget](../nuget/remote.md),
|
||||||
[puppet](../puppet/remote.md), [pypi](../pypi/remote.md), [rpm](../rpm/remote.md),
|
[puppet](../puppet/remote.md), [pypi](../pypi/remote.md), [rpm](../rpm/remote.md),
|
||||||
[rpm github](../rpm/remote-github.md), [terraform](../terraform/remote.md).
|
[rpm github](../rpm/remote-github.md), [terraform](../terraform/remote.md), [vcs](../vcs/remote.md).
|
||||||
|
|||||||
@@ -10,6 +10,9 @@ docker push artifactapi.example.com/docker-internal/myapp:latest
|
|||||||
docker pull artifactapi.example.com/docker-internal/myapp:latest
|
docker pull artifactapi.example.com/docker-internal/myapp:latest
|
||||||
```
|
```
|
||||||
|
|
||||||
|
With [uploads gated](../common/auth.md), `docker login` with any username and
|
||||||
|
a token as the password before pushing; pulls stay anonymous.
|
||||||
|
|
||||||
The first path segment after `/v2/` is the artifactapi repo name; the remainder
|
The first path segment after `/v2/` is the artifactapi repo name; the remainder
|
||||||
is the image name. Blobs and manifests are stored through the shared
|
is the image name. Blobs and manifests are stored through the shared
|
||||||
content-addressable store (deduplicated by digest, reaped by GC once
|
content-addressable store (deduplicated by digest, reaped by GC once
|
||||||
|
|||||||
+1
-1
@@ -2,7 +2,7 @@
|
|||||||
|
|
||||||
A local `gems` repo is a RubyGems source: `gem push`, `gem yank`, `gem install`
|
A local `gems` repo is a RubyGems source: `gem push`, `gem yank`, `gem install`
|
||||||
and `bundle install` work against `/api/v1/local/<repo>`. `gem push` needs an
|
and `bundle install` work against `/api/v1/local/<repo>`. `gem push` needs an
|
||||||
API key; any value works.
|
API key; any value works unless [uploads are gated](../common/auth.md).
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
GEM_HOST_API_KEY=unused gem push --host https://artifactapi.example.com/api/v1/local/<repo> mygem-1.0.0.gem
|
GEM_HOST_API_KEY=unused gem push --host https://artifactapi.example.com/api/v1/local/<repo> mygem-1.0.0.gem
|
||||||
|
|||||||
+2
-1
@@ -2,7 +2,8 @@
|
|||||||
|
|
||||||
A local `npm` repo is a real npm registry: `npm publish` (scoped and unscoped)
|
A local `npm` repo is a real npm registry: `npm publish` (scoped and unscoped)
|
||||||
and `npm install` work against `/api/v1/local/<repo>/`. npm requires an
|
and `npm install` work against `/api/v1/local/<repo>/`. npm requires an
|
||||||
`_authToken` for the registry before it will publish; any value works.
|
`_authToken` for the registry before it will publish; any value works unless
|
||||||
|
[uploads are gated](../common/auth.md).
|
||||||
|
|
||||||
```ini
|
```ini
|
||||||
# .npmrc
|
# .npmrc
|
||||||
|
|||||||
@@ -0,0 +1,29 @@
|
|||||||
|
# `vcs` remote
|
||||||
|
|
||||||
|
Shared classification, TTL and eviction rules: [caching](../common/caching.md).
|
||||||
|
|
||||||
|
Caches source archives and release assets from GitHub (`base_url = "https://github.com"`) or Gitea (any other `base_url`). GitHub Enterprise is not supported: a non-github.com host is treated as Gitea. Only the paths below are served; anything else is a 404.
|
||||||
|
|
||||||
|
| Path | Behaviour |
|
||||||
|
|---|---|
|
||||||
|
| `<owner>/<repo>/archive/refs/tags/<tag>.(tar.gz\|zip)` | immutable |
|
||||||
|
| `<owner>/<repo>/archive/<40-char sha>.(tar.gz\|zip)` | immutable |
|
||||||
|
| `<owner>/<repo>/releases/download/<tag>/<asset>` | immutable |
|
||||||
|
| `<owner>/<repo>/releases/latest/download/<asset>` | mutable |
|
||||||
|
| `<owner>/<repo>/archive/refs/heads/<branch>.(tar.gz\|zip)` | `302` to the archive of the branch's current commit, resolved via the provider's branch API and reused for `mutable_ttl` |
|
||||||
|
|
||||||
|
Branch archives redirect, so `curl` needs `-L`; pip and npm follow redirects. The archive is the host's commit archive (GitHub names its top-level directory `<repo>-<sha>`). `patterns` and `blocklist` match both the branch path and the commit path it redirects to, so allowlist repos by prefix (`^cli/cli/`); a branch whose commit path is denied is a `403`. A missing branch is a `404`, cached for `mutable_ttl` (at least 60s). An API rate limit (`429`, or `403` with rate-limit headers) is a `503` with `Retry-After`, unless `stale_on_error` serves the last known commit. Each remote caches up to 4096 branch lookups. GitHub API calls use the [server GitHub credential](../../README.md#github-authentication); Gitea API calls use the remote's `username`/`password`.
|
||||||
|
|
||||||
|
```hcl
|
||||||
|
resource "artifactapi_remote_vcs" "github" {
|
||||||
|
name = "github-vcs"
|
||||||
|
base_url = "https://github.com"
|
||||||
|
mutable_ttl = 600
|
||||||
|
patterns = ["^cli/cli/", "^psf/requests/"]
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
```bash
|
||||||
|
curl -fsSLO https://artifactapi.example/api/v1/remote/github-vcs/cli/cli/archive/refs/tags/v2.60.0.tar.gz
|
||||||
|
pip install https://artifactapi.example/api/v1/remote/github-vcs/psf/requests/archive/refs/tags/v2.32.3.tar.gz
|
||||||
|
```
|
||||||
@@ -0,0 +1,105 @@
|
|||||||
|
//go:build dockere2e
|
||||||
|
|
||||||
|
package e2edocker
|
||||||
|
|
||||||
|
import (
|
||||||
|
"net/http"
|
||||||
|
"os"
|
||||||
|
"os/exec"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// abuildScript builds a real, abuild-signed $N-$V-r0.apk and writes it to stdout.
|
||||||
|
const abuildScript = `set -eu
|
||||||
|
apk add -q abuild >&2
|
||||||
|
adduser -D b && addgroup b abuild
|
||||||
|
su b -c 'set -eu; abuild-keygen -an >&2; mkdir -p ~/p && cd ~/p
|
||||||
|
printf "%s\n" "pkgname=$N" "pkgver=$V" pkgrel=0 "pkgdesc=\"e2e\"" "url=\"https://example.com\"" "arch=\"x86_64\"" "license=\"MIT\"" "options=\"!check\"" \
|
||||||
|
"package() { mkdir -p \"\$pkgdir/usr/share/$N\"; echo ok > \"\$pkgdir/usr/share/$N/ok\"; }" > APKBUILD
|
||||||
|
abuild -d >&2 || true'
|
||||||
|
cat /home/b/packages/*/x86_64/$N-$V-r0.apk`
|
||||||
|
|
||||||
|
func buildApk(t *testing.T, name, version string) []byte {
|
||||||
|
t.Helper()
|
||||||
|
cmd := exec.Command("docker", "run", "--rm", "-e", "N="+name, "-e", "V="+version, "alpine:3.20", "sh", "-c", abuildScript)
|
||||||
|
var stderr strings.Builder
|
||||||
|
cmd.Stderr = &stderr
|
||||||
|
out, err := cmd.Output()
|
||||||
|
if err != nil || len(out) == 0 {
|
||||||
|
t.Fatalf("abuild %s-%s: %v\n%s", name, version, err, stderr.String())
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestVirtualAlpineMerge merges two local alpine repos carrying the same
|
||||||
|
// abuild-built package: the first member wins the duplicate and its download,
|
||||||
|
// and a real apk installs packages from both members through the virtual.
|
||||||
|
func TestVirtualAlpineMerge(t *testing.T) {
|
||||||
|
network := os.Getenv("COMPOSE_NETWORK")
|
||||||
|
internal := os.Getenv("ARTIFACTAPI_INTERNAL")
|
||||||
|
if network == "" || internal == "" {
|
||||||
|
t.Skip("COMPOSE_NETWORK/ARTIFACTAPI_INTERNAL not set; skipping real apk")
|
||||||
|
}
|
||||||
|
if _, err := exec.LookPath("docker"); err != nil {
|
||||||
|
t.Skip("docker not available on the test host")
|
||||||
|
}
|
||||||
|
one, two := buildApk(t, "vapk-one", "1.0"), buildApk(t, "vapk-two", "2.0")
|
||||||
|
|
||||||
|
createRepo(t, `{"name":"vapk-a","package_type":"alpine","repo_type":"local"}`)
|
||||||
|
createRepo(t, `{"name":"vapk-b","package_type":"alpine","repo_type":"local"}`)
|
||||||
|
defer deleteRepo(t, "vapk-a")
|
||||||
|
defer deleteRepo(t, "vapk-b")
|
||||||
|
|
||||||
|
const apkType = "application/vnd.android.package-archive"
|
||||||
|
uploadFile(t, "vapk-a", "x86_64/vapk-one-1.0-r0.apk", one, apkType)
|
||||||
|
uploadFile(t, "vapk-b", "x86_64/vapk-one-1.0-r0.apk", one, apkType)
|
||||||
|
uploadFile(t, "vapk-b", "x86_64/vapk-two-2.0-r0.apk", two, apkType)
|
||||||
|
|
||||||
|
// Local indexes list uploads once their metadata is parsed asynchronously,
|
||||||
|
// and the virtual caches its merge, so merge only once both members list all.
|
||||||
|
for _, m := range []struct{ repo, pkg string }{{"vapk-a", "P:vapk-one\n"}, {"vapk-b", "P:vapk-two\n"}} {
|
||||||
|
var idx string
|
||||||
|
for deadline := time.Now().Add(15 * time.Second); !strings.Contains(idx, m.pkg) && time.Now().Before(deadline); time.Sleep(250 * time.Millisecond) {
|
||||||
|
_, body := doRequest(t, http.MethodGet, api("/api/v1/local/"+m.repo+"/x86_64/APKINDEX.tar.gz"), nil, "")
|
||||||
|
idx = apkIndexText(t, body)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
createVirtual(t, `{"name":"vapk","package_type":"alpine","members":["vapk-a","vapk-b"]}`)
|
||||||
|
defer deleteVirtual(t, "vapk")
|
||||||
|
|
||||||
|
resp, body := doRequest(t, http.MethodGet, api("/api/v1/virtual/vapk/x86_64/APKINDEX.tar.gz"), nil, "")
|
||||||
|
if resp.StatusCode != http.StatusOK {
|
||||||
|
t.Fatalf("virtual APKINDEX: status %d: %s", resp.StatusCode, body)
|
||||||
|
}
|
||||||
|
index := apkIndexText(t, body)
|
||||||
|
if strings.Count(index, "P:vapk-one\n") != 1 || !strings.Contains(index, "P:vapk-two\n") {
|
||||||
|
t.Fatalf("merged APKINDEX should hold vapk-one once and vapk-two:\n%s", index)
|
||||||
|
}
|
||||||
|
|
||||||
|
noRedirect := &http.Client{CheckRedirect: func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }}
|
||||||
|
for pkg, member := range map[string]string{"vapk-one-1.0-r0.apk": "vapk-a", "vapk-two-2.0-r0.apk": "vapk-b"} {
|
||||||
|
resp, err := noRedirect.Get(api("/api/v1/virtual/vapk/x86_64/" + pkg))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
resp.Body.Close()
|
||||||
|
if loc := resp.Header.Get("Location"); resp.StatusCode != http.StatusFound || !strings.HasSuffix(loc, "/api/v1/local/"+member+"/x86_64/"+pkg) {
|
||||||
|
t.Fatalf("%s: want 302 to %s, got %d %q", pkg, member, resp.StatusCode, loc)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
script := "set -eu; " +
|
||||||
|
"echo \"$URL\" > /etc/apk/repositories; " +
|
||||||
|
"apk update --allow-untrusted; " +
|
||||||
|
"apk add --allow-untrusted vapk-one vapk-two; " +
|
||||||
|
"test -f /usr/share/vapk-one/ok && test -f /usr/share/vapk-two/ok"
|
||||||
|
out, err := exec.Command("docker", "run", "--rm", "--network", network,
|
||||||
|
"-e", "URL="+strings.TrimRight(internal, "/")+"/api/v1/virtual/vapk",
|
||||||
|
"alpine:3.20", "sh", "-c", script).CombinedOutput()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("real apk against alpine virtual failed: %v\n%s", err, out)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,7 @@
|
|||||||
|
//go:build dockere2e
|
||||||
|
|
||||||
|
package e2edocker
|
||||||
|
|
||||||
|
func init() {
|
||||||
|
cachingCases = append(cachingCases, cachingCase{"vcs", "octo/repo/archive/refs/tags/v1.0.0.tar.gz", "octo/repo/archive/refs/tags/v1.0.0.tar.gz"})
|
||||||
|
}
|
||||||
Binary file not shown.
+30
-24
@@ -150,31 +150,15 @@ func TestLocalAlpineIndex(t *testing.T) {
|
|||||||
apk := testsupport.MinimalApk("e2e-testpkg", "1.0-r0", "x86_64")
|
apk := testsupport.MinimalApk("e2e-testpkg", "1.0-r0", "x86_64")
|
||||||
uploadFile(t, "local-alpine", "x86_64/e2e-testpkg-1.0-r0.apk", apk, "application/vnd.android.package-archive")
|
uploadFile(t, "local-alpine", "x86_64/e2e-testpkg-1.0-r0.apk", apk, "application/vnd.android.package-archive")
|
||||||
|
|
||||||
// The index is generated asynchronously after upload; poll for it.
|
// The index is served (empty) at once but lists the package only once the
|
||||||
resp, body := getEventually(t, api("/api/v1/local/local-alpine/x86_64/APKINDEX.tar.gz"), 15*time.Second)
|
// upload's metadata is parsed asynchronously; poll until it does.
|
||||||
if resp.StatusCode != http.StatusOK {
|
|
||||||
t.Fatalf("APKINDEX: status %d: %s", resp.StatusCode, body)
|
|
||||||
}
|
|
||||||
|
|
||||||
zr, err := gzip.NewReader(bytes.NewReader(body))
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("APKINDEX not gzip: %v", err)
|
|
||||||
}
|
|
||||||
tarBytes, _ := io.ReadAll(zr)
|
|
||||||
tr := tar.NewReader(bytes.NewReader(tarBytes))
|
|
||||||
var index string
|
var index string
|
||||||
for {
|
for deadline := time.Now().Add(15 * time.Second); !strings.Contains(index, "P:e2e-testpkg") && time.Now().Before(deadline); time.Sleep(250 * time.Millisecond) {
|
||||||
hdr, err := tr.Next()
|
resp, body := doRequest(t, http.MethodGet, api("/api/v1/local/local-alpine/x86_64/APKINDEX.tar.gz"), nil, "")
|
||||||
if err == io.EOF {
|
if resp.StatusCode != http.StatusOK {
|
||||||
break
|
t.Fatalf("APKINDEX: status %d: %s", resp.StatusCode, body)
|
||||||
}
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("APKINDEX not tar: %v", err)
|
|
||||||
}
|
|
||||||
if hdr.Name == "APKINDEX" {
|
|
||||||
b, _ := io.ReadAll(tr)
|
|
||||||
index = string(b)
|
|
||||||
}
|
}
|
||||||
|
index = apkIndexText(t, body)
|
||||||
}
|
}
|
||||||
for _, want := range []string{"P:e2e-testpkg", "V:1.0-r0", "A:x86_64", "C:Q1", "S:", "I:"} {
|
for _, want := range []string{"P:e2e-testpkg", "V:1.0-r0", "A:x86_64", "C:Q1", "S:", "I:"} {
|
||||||
if !strings.Contains(index, want) {
|
if !strings.Contains(index, want) {
|
||||||
@@ -183,7 +167,7 @@ func TestLocalAlpineIndex(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// The .apk downloads back byte-identical from its arch path.
|
// The .apk downloads back byte-identical from its arch path.
|
||||||
resp, body = doRequest(t, http.MethodGet, api("/api/v1/local/local-alpine/x86_64/e2e-testpkg-1.0-r0.apk"), nil, "")
|
resp, body := doRequest(t, http.MethodGet, api("/api/v1/local/local-alpine/x86_64/e2e-testpkg-1.0-r0.apk"), nil, "")
|
||||||
if resp.StatusCode != http.StatusOK {
|
if resp.StatusCode != http.StatusOK {
|
||||||
t.Fatalf("download apk: status %d: %s", resp.StatusCode, body)
|
t.Fatalf("download apk: status %d: %s", resp.StatusCode, body)
|
||||||
}
|
}
|
||||||
@@ -191,3 +175,25 @@ func TestLocalAlpineIndex(t *testing.T) {
|
|||||||
t.Fatalf("apk content mismatch")
|
t.Fatalf("apk content mismatch")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func apkIndexText(t *testing.T, body []byte) string {
|
||||||
|
t.Helper()
|
||||||
|
zr, err := gzip.NewReader(bytes.NewReader(body))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("APKINDEX not gzip: %v", err)
|
||||||
|
}
|
||||||
|
tr := tar.NewReader(zr)
|
||||||
|
for {
|
||||||
|
hdr, err := tr.Next()
|
||||||
|
if err == io.EOF {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("APKINDEX not tar: %v", err)
|
||||||
|
}
|
||||||
|
if hdr.Name == "APKINDEX" {
|
||||||
|
b, _ := io.ReadAll(tr)
|
||||||
|
return string(b)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ package v1
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"bytes"
|
"bytes"
|
||||||
|
"encoding/json"
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
@@ -11,6 +12,7 @@ import (
|
|||||||
"net/url"
|
"net/url"
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
|
"time"
|
||||||
|
|
||||||
"github.com/go-chi/chi/v5"
|
"github.com/go-chi/chi/v5"
|
||||||
|
|
||||||
@@ -121,7 +123,7 @@ func (h *ProxyHandler) serveFetch(w http.ResponseWriter, r *http.Request, remote
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
var proxyErr *proxy.ProxyError
|
var proxyErr *proxy.ProxyError
|
||||||
if errors.As(err, &proxyErr) {
|
if errors.As(err, &proxyErr) {
|
||||||
http.Error(w, proxyErr.Message, proxyErr.Status)
|
writeProxyError(w, proxyErr)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
slog.Error("proxy fetch failed", "remote", remote.Name, "path", path, "error", err)
|
slog.Error("proxy fetch failed", "remote", remote.Name, "path", path, "error", err)
|
||||||
@@ -149,6 +151,24 @@ func (h *ProxyHandler) serveFetch(w http.ResponseWriter, r *http.Request, remote
|
|||||||
io.Copy(w, body)
|
io.Copy(w, body)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// writeProxyError answers a quarantine refusal as JSON and anything else as text.
|
||||||
|
func writeProxyError(w http.ResponseWriter, pe *proxy.ProxyError) {
|
||||||
|
if pe.RetryAfter > 0 {
|
||||||
|
w.Header().Set("Retry-After", strconv.Itoa(pe.RetryAfter))
|
||||||
|
}
|
||||||
|
if pe.Published.IsZero() {
|
||||||
|
http.Error(w, pe.Message, pe.Status)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
w.Header().Set("Content-Type", "application/json")
|
||||||
|
w.WriteHeader(pe.Status)
|
||||||
|
_ = json.NewEncoder(w).Encode(map[string]string{
|
||||||
|
"error": pe.Message,
|
||||||
|
"published": pe.Published.Format(time.RFC3339),
|
||||||
|
"available": pe.Available.Format(time.RFC3339),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
func rewritesMutable(prov provider.Provider, path string) bool {
|
func rewritesMutable(prov provider.Provider, path string) bool {
|
||||||
_, sr := prov.(provider.ServeRewriter)
|
_, sr := prov.(provider.ServeRewriter)
|
||||||
_, rr := prov.(provider.ResponseRewriter)
|
_, rr := prov.(provider.ResponseRewriter)
|
||||||
@@ -176,7 +196,7 @@ func (h *ProxyHandler) handleProxyHead(w http.ResponseWriter, r *http.Request) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
var proxyErr *proxy.ProxyError
|
var proxyErr *proxy.ProxyError
|
||||||
if errors.As(err, &proxyErr) {
|
if errors.As(err, &proxyErr) {
|
||||||
http.Error(w, proxyErr.Message, proxyErr.Status)
|
writeProxyError(w, proxyErr)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
slog.Error("proxy head failed", "remote", remote.Name, "path", path, "error", err)
|
slog.Error("proxy head failed", "remote", remote.Name, "path", path, "error", err)
|
||||||
|
|||||||
@@ -0,0 +1,16 @@
|
|||||||
|
package v1
|
||||||
|
|
||||||
|
import (
|
||||||
|
"net/http/httptest"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/proxy"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestWriteProxyErrorRetryAfter(t *testing.T) {
|
||||||
|
w := httptest.NewRecorder()
|
||||||
|
writeProxyError(w, &proxy.ProxyError{Status: 503, Message: "quarantine check unavailable", RetryAfter: 30})
|
||||||
|
if w.Code != 503 || w.Header().Get("Retry-After") != "30" {
|
||||||
|
t.Errorf("code %d, Retry-After %q", w.Code, w.Header().Get("Retry-After"))
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -72,7 +72,7 @@ func (h *RemotesHandler) get(w http.ResponseWriter, r *http.Request) {
|
|||||||
const defaultMutableTTL = 3600
|
const defaultMutableTTL = 3600
|
||||||
|
|
||||||
func (h *RemotesHandler) create(w http.ResponseWriter, r *http.Request) {
|
func (h *RemotesHandler) create(w http.ResponseWriter, r *http.Request) {
|
||||||
remote := models.Remote{MutableTTL: defaultMutableTTL}
|
remote := models.Remote{MutableTTL: defaultMutableTTL, QuarantineDays: models.DefaultQuarantineDays}
|
||||||
if err := json.NewDecoder(r.Body).Decode(&remote); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&remote); err != nil {
|
||||||
http.Error(w, "invalid json", http.StatusBadRequest)
|
http.Error(w, "invalid json", http.StatusBadRequest)
|
||||||
return
|
return
|
||||||
@@ -104,6 +104,10 @@ func (h *RemotesHandler) create(w http.ResponseWriter, r *http.Request) {
|
|||||||
http.Error(w, err.Error(), http.StatusBadRequest)
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
if err := remote.ValidateQuarantine(); err != nil {
|
||||||
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
||||||
|
return
|
||||||
|
}
|
||||||
if err := h.db.CreateRemote(r.Context(), &remote); err != nil {
|
if err := h.db.CreateRemote(r.Context(), &remote); err != nil {
|
||||||
http.Error(w, err.Error(), http.StatusInternalServerError)
|
http.Error(w, err.Error(), http.StatusInternalServerError)
|
||||||
return
|
return
|
||||||
@@ -126,6 +130,7 @@ func (h *RemotesHandler) update(w http.ResponseWriter, r *http.Request) {
|
|||||||
var remote models.Remote
|
var remote models.Remote
|
||||||
if oldKnown {
|
if oldKnown {
|
||||||
remote.MutableTTL = existing.MutableTTL
|
remote.MutableTTL = existing.MutableTTL
|
||||||
|
remote.QuarantineDays = existing.QuarantineDays
|
||||||
}
|
}
|
||||||
if err := json.NewDecoder(r.Body).Decode(&remote); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&remote); err != nil {
|
||||||
http.Error(w, "invalid json", http.StatusBadRequest)
|
http.Error(w, "invalid json", http.StatusBadRequest)
|
||||||
@@ -144,6 +149,10 @@ func (h *RemotesHandler) update(w http.ResponseWriter, r *http.Request) {
|
|||||||
http.Error(w, err.Error(), http.StatusBadRequest)
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
if err := remote.ValidateQuarantine(); err != nil {
|
||||||
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
||||||
|
return
|
||||||
|
}
|
||||||
if err := h.db.UpdateRemote(r.Context(), &remote); err != nil {
|
if err := h.db.UpdateRemote(r.Context(), &remote); err != nil {
|
||||||
http.Error(w, err.Error(), http.StatusInternalServerError)
|
http.Error(w, err.Error(), http.StatusInternalServerError)
|
||||||
return
|
return
|
||||||
|
|||||||
@@ -55,3 +55,67 @@ func TestMutableTTLOmittedVsZero(t *testing.T) {
|
|||||||
t.Errorf("explicit 0 stored as %d", got)
|
t.Errorf("explicit 0 stored as %d", got)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestQuarantineDaysDefault(t *testing.T) {
|
||||||
|
if testDSN == "" {
|
||||||
|
t.Skip("Docker unavailable")
|
||||||
|
}
|
||||||
|
db, err := database.New(testDSN)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer db.Close()
|
||||||
|
h := NewRemotesHandler(db, nil, nil).Routes()
|
||||||
|
days := func() int {
|
||||||
|
t.Helper()
|
||||||
|
r, err := db.GetRemote(context.Background(), "q-days")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return r.QuarantineDays
|
||||||
|
}
|
||||||
|
const body = `"package_type":"npm","base_url":"https://example.com","quarantine_enabled":true`
|
||||||
|
for i, s := range []struct {
|
||||||
|
method, path, json string
|
||||||
|
want int
|
||||||
|
}{
|
||||||
|
{"POST", "/", `{"name":"q-days",` + body + `}`, 3},
|
||||||
|
{"PUT", "/q-days", `{` + body + `,"quarantine_days":14}`, 14},
|
||||||
|
{"PUT", "/q-days", `{` + body + `}`, 14},
|
||||||
|
} {
|
||||||
|
if c := do(t, h, s.method, s.path, s.json); c/100 != 2 {
|
||||||
|
t.Fatalf("step %d = %d", i, c)
|
||||||
|
}
|
||||||
|
if got := days(); got != s.want {
|
||||||
|
t.Errorf("step %d: quarantine_days = %d, want %d", i, got, s.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineDaysValidation(t *testing.T) {
|
||||||
|
if testDSN == "" {
|
||||||
|
t.Skip("Docker unavailable")
|
||||||
|
}
|
||||||
|
db, err := database.New(testDSN)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer db.Close()
|
||||||
|
h := NewRemotesHandler(db, nil, nil).Routes()
|
||||||
|
const body = `"package_type":"npm","base_url":"https://example.com"`
|
||||||
|
for i, s := range []struct {
|
||||||
|
method, path, json string
|
||||||
|
want int
|
||||||
|
}{
|
||||||
|
{"POST", "/", `{"name":"q-val",` + body + `,"quarantine_enabled":true,"quarantine_days":0}`, 400},
|
||||||
|
{"POST", "/", `{"name":"q-val",` + body + `,"quarantine_enabled":true,"quarantine_days":-1}`, 400},
|
||||||
|
{"POST", "/", `{"name":"q-val",` + body + `,"quarantine_days":0}`, 201},
|
||||||
|
{"PUT", "/q-val", `{` + body + `,"quarantine_enabled":true}`, 400},
|
||||||
|
{"PUT", "/q-val", `{` + body + `,"quarantine_enabled":true,"quarantine_days":1}`, 200},
|
||||||
|
{"PUT", "/q-val", `{` + body + `,"quarantine_enabled":true,"quarantine_days":0}`, 400},
|
||||||
|
} {
|
||||||
|
if c := do(t, h, s.method, s.path, s.json); c != s.want {
|
||||||
|
t.Errorf("step %d %s %s = %d, want %d", i, s.method, s.path, c, s.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -0,0 +1,56 @@
|
|||||||
|
package v2
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"net/http/httptest"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/database"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestVirtualParallelFetchRoundTrip(t *testing.T) {
|
||||||
|
if testDSN == "" {
|
||||||
|
t.Skip("Docker unavailable")
|
||||||
|
}
|
||||||
|
db, err := database.New(testDSN)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer db.Close()
|
||||||
|
h := NewVirtualsHandler(db).Routes()
|
||||||
|
parallel := func() bool {
|
||||||
|
t.Helper()
|
||||||
|
w := httptest.NewRecorder()
|
||||||
|
h.ServeHTTP(w, httptest.NewRequest("GET", "/vpf", nil))
|
||||||
|
var got map[string]any
|
||||||
|
if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil || w.Code != 200 {
|
||||||
|
t.Fatalf("get = %d %s", w.Code, w.Body)
|
||||||
|
}
|
||||||
|
v, ok := got["parallel_fetch"].(bool)
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("parallel_fetch missing from %s", w.Body)
|
||||||
|
}
|
||||||
|
return v
|
||||||
|
}
|
||||||
|
const body = `"package_type":"rpm","members":["a"]`
|
||||||
|
|
||||||
|
steps := []struct {
|
||||||
|
method, path, json string
|
||||||
|
want bool
|
||||||
|
}{
|
||||||
|
{"POST", "/", `{"name":"vpf",` + body + `}`, false},
|
||||||
|
{"PUT", "/vpf", `{` + body + `,"parallel_fetch":true}`, true},
|
||||||
|
{"PUT", "/vpf", `{` + body + `,"parallel_fetch":false}`, false},
|
||||||
|
}
|
||||||
|
for i, s := range steps {
|
||||||
|
if c := do(t, h, s.method, s.path, s.json); c/100 != 2 {
|
||||||
|
t.Fatalf("step %d %s %s = %d", i, s.method, s.path, c)
|
||||||
|
}
|
||||||
|
if got := parallel(); got != s.want {
|
||||||
|
t.Errorf("step %d: parallel_fetch = %v, want %v", i, got, s.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if c := do(t, h, "DELETE", "/vpf", ""); c != 204 {
|
||||||
|
t.Fatalf("delete = %d", c)
|
||||||
|
}
|
||||||
|
}
|
||||||
+93
-17
@@ -2,7 +2,9 @@ package auth
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
|
"encoding/json"
|
||||||
"errors"
|
"errors"
|
||||||
|
"fmt"
|
||||||
"log/slog"
|
"log/slog"
|
||||||
"net/http"
|
"net/http"
|
||||||
"slices"
|
"slices"
|
||||||
@@ -104,42 +106,116 @@ func (b *BearerOIDC) discoverOnce(done chan struct{}) (v *oidc.IDTokenVerifier,
|
|||||||
// Require gates every request through next on a valid token. A nil receiver
|
// Require gates every request through next on a valid token. A nil receiver
|
||||||
// passes everything through.
|
// passes everything through.
|
||||||
func (b *BearerOIDC) Require(next http.Handler) http.Handler {
|
func (b *BearerOIDC) Require(next http.Handler) http.Handler {
|
||||||
|
return b.require(next, "Bearer")
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *BearerOIDC) require(next http.Handler, challenge string) http.Handler {
|
||||||
if b == nil {
|
if b == nil {
|
||||||
return next
|
return next
|
||||||
}
|
}
|
||||||
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
scheme, raw, _ := strings.Cut(strings.TrimSpace(r.Header.Get("Authorization")), " ")
|
raw := token(r)
|
||||||
raw = strings.TrimSpace(raw)
|
if raw == "" {
|
||||||
if !strings.EqualFold(scheme, "Bearer") || raw == "" {
|
unauthorized(w, challenge, "missing token")
|
||||||
unauthorized(w, "missing bearer token")
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
v, err := b.getVerifier(r.Context())
|
sub, err := b.verify(r.Context(), raw)
|
||||||
if err != nil {
|
if errors.Is(err, errIssuerUnavailable) {
|
||||||
w.Header().Set("Content-Type", "application/json")
|
w.Header().Set("Content-Type", "application/json")
|
||||||
w.WriteHeader(http.StatusServiceUnavailable)
|
w.WriteHeader(http.StatusServiceUnavailable)
|
||||||
_, _ = w.Write([]byte(`{"error":"token issuer unavailable"}`))
|
_, _ = w.Write([]byte(`{"error":"token issuer unavailable"}`))
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
tok, err := v.Verify(r.Context(), raw)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
slog.Info("bearer token rejected", "error", err)
|
slog.Info("bearer token rejected", "error", err)
|
||||||
unauthorized(w, "invalid token")
|
unauthorized(w, challenge, "invalid token")
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
if len(b.audiences) > 0 && !slices.ContainsFunc(tok.Audience, func(a string) bool { return slices.Contains(b.audiences, a) }) {
|
slog.Info("bearer token accepted", "sub", sub, "method", r.Method, "path", r.URL.Path)
|
||||||
slog.Info("bearer token rejected", "error", "audience not allowed", "aud", tok.Audience)
|
|
||||||
unauthorized(w, "invalid token")
|
|
||||||
return
|
|
||||||
}
|
|
||||||
slog.Info("bearer token accepted", "sub", tok.Subject, "method", r.Method, "path", r.URL.Path)
|
|
||||||
next.ServeHTTP(w, r)
|
next.ServeHTTP(w, r)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (b *BearerOIDC) verify(ctx context.Context, raw string) (string, error) {
|
||||||
|
v, err := b.getVerifier(ctx)
|
||||||
|
if err != nil {
|
||||||
|
return "", errIssuerUnavailable
|
||||||
|
}
|
||||||
|
tok, err := v.Verify(ctx, raw)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
if len(b.audiences) > 0 && !slices.ContainsFunc(tok.Audience, func(a string) bool { return slices.Contains(b.audiences, a) }) {
|
||||||
|
return "", fmt.Errorf("audience %v not allowed", tok.Audience)
|
||||||
|
}
|
||||||
|
return tok.Subject, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// token reads the JWT from `Bearer`/`Token` credentials, the password of
|
||||||
|
// `Basic` credentials (any username), or a bare header value as `gem push`
|
||||||
|
// sends its API key.
|
||||||
|
func token(r *http.Request) string {
|
||||||
|
if _, pass, ok := r.BasicAuth(); ok {
|
||||||
|
return pass
|
||||||
|
}
|
||||||
|
scheme, raw, found := strings.Cut(strings.TrimSpace(r.Header.Get("Authorization")), " ")
|
||||||
|
if !found {
|
||||||
|
return scheme
|
||||||
|
}
|
||||||
|
if strings.EqualFold(scheme, "Bearer") || strings.EqualFold(scheme, "Token") {
|
||||||
|
return strings.TrimSpace(raw)
|
||||||
|
}
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
|
||||||
// RequireWrites gates only mutating methods.
|
// RequireWrites gates only mutating methods.
|
||||||
func (b *BearerOIDC) RequireWrites(next http.Handler) http.Handler {
|
func (b *BearerOIDC) RequireWrites(next http.Handler) http.Handler {
|
||||||
gated := b.Require(next)
|
return writesOnly(next, b.Require(next))
|
||||||
|
}
|
||||||
|
|
||||||
|
// RequireRegistryWrites gates Docker Registry V2 writes behind the token flow
|
||||||
|
// Docker clients need: an unauthenticated ping gets a Bearer challenge naming
|
||||||
|
// realm, which serves the Basic password back as the token once verified, or
|
||||||
|
// an anonymous token so pulls stay open.
|
||||||
|
func (b *BearerOIDC) RequireRegistryWrites(next http.Handler, realm func(*http.Request) string) http.Handler {
|
||||||
|
if b == nil {
|
||||||
|
return next
|
||||||
|
}
|
||||||
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
challenge := `Bearer realm="` + realm(r) + `",service="artifactapi"`
|
||||||
|
hasAuth := r.Header.Get("Authorization") != ""
|
||||||
|
switch {
|
||||||
|
case r.URL.Path == "/v2/token":
|
||||||
|
writeToken(w, b.registryToken(r))
|
||||||
|
case r.URL.Path == "/v2/" && !hasAuth:
|
||||||
|
unauthorized(w, challenge, "authentication required")
|
||||||
|
default:
|
||||||
|
writesOnly(next, b.require(next, challenge)).ServeHTTP(w, r)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// registryToken echoes a valid credential back as the registry token. Missing
|
||||||
|
// or invalid credentials (e.g. an expired `docker login`) get the anonymous
|
||||||
|
// token so pulls keep working; writes are still verified per request.
|
||||||
|
func (b *BearerOIDC) registryToken(r *http.Request) string {
|
||||||
|
raw := token(r)
|
||||||
|
if raw == "" {
|
||||||
|
return "anonymous"
|
||||||
|
}
|
||||||
|
if _, err := b.verify(r.Context(), raw); err != nil {
|
||||||
|
slog.Info("registry credential rejected, issuing anonymous token", "error", err)
|
||||||
|
return "anonymous"
|
||||||
|
}
|
||||||
|
return raw
|
||||||
|
}
|
||||||
|
|
||||||
|
func writeToken(w http.ResponseWriter, tok string) {
|
||||||
|
w.Header().Set("Content-Type", "application/json")
|
||||||
|
_ = json.NewEncoder(w).Encode(map[string]string{"token": tok, "access_token": tok})
|
||||||
|
}
|
||||||
|
|
||||||
|
func writesOnly(next, gated http.Handler) http.Handler {
|
||||||
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
switch r.Method {
|
switch r.Method {
|
||||||
case http.MethodGet, http.MethodHead, http.MethodOptions:
|
case http.MethodGet, http.MethodHead, http.MethodOptions:
|
||||||
@@ -150,9 +226,9 @@ func (b *BearerOIDC) RequireWrites(next http.Handler) http.Handler {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
func unauthorized(w http.ResponseWriter, msg string) {
|
func unauthorized(w http.ResponseWriter, challenge, msg string) {
|
||||||
w.Header().Set("Content-Type", "application/json")
|
w.Header().Set("Content-Type", "application/json")
|
||||||
w.Header().Set("WWW-Authenticate", "Bearer")
|
w.Header().Set("WWW-Authenticate", challenge)
|
||||||
w.WriteHeader(http.StatusUnauthorized)
|
w.WriteHeader(http.StatusUnauthorized)
|
||||||
_, _ = w.Write([]byte(`{"error":"` + msg + `"}`))
|
_, _ = w.Write([]byte(`{"error":"` + msg + `"}`))
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ import (
|
|||||||
"net/http"
|
"net/http"
|
||||||
"net/http/httptest"
|
"net/http/httptest"
|
||||||
"strconv"
|
"strconv"
|
||||||
|
"strings"
|
||||||
"sync"
|
"sync"
|
||||||
"sync/atomic"
|
"sync/atomic"
|
||||||
"testing"
|
"testing"
|
||||||
@@ -253,3 +254,90 @@ func TestRequireWritesLeavesReadsOpen(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func basic(user, pass string) string {
|
||||||
|
return "Basic " + base64.StdEncoding.EncodeToString([]byte(user+":"+pass))
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestTokenSchemes(t *testing.T) {
|
||||||
|
iss := testsupport.NewOIDCIssuer()
|
||||||
|
defer iss.Close()
|
||||||
|
h := NewBearerOIDC(iss.URL, []string{"artifactapi"}).RequireWrites(ok)
|
||||||
|
valid := iss.Token(nil, "artifactapi", "ci", time.Hour)
|
||||||
|
cases := []struct {
|
||||||
|
name string
|
||||||
|
authz string
|
||||||
|
want int
|
||||||
|
}{
|
||||||
|
{"bearer", "Bearer " + valid, http.StatusNoContent},
|
||||||
|
{"token scheme", "Token " + valid, http.StatusNoContent},
|
||||||
|
{"basic password", basic("anyone", valid), http.StatusNoContent},
|
||||||
|
{"basic empty user", basic("", valid), http.StatusNoContent},
|
||||||
|
{"bare jwt", valid, http.StatusNoContent},
|
||||||
|
{"basic wrong aud", basic("ci", iss.Token(nil, "nope", "ci", time.Hour)), http.StatusUnauthorized},
|
||||||
|
{"basic token as user", basic(valid, "x"), http.StatusUnauthorized},
|
||||||
|
{"bare garbage", "garbage", http.StatusUnauthorized},
|
||||||
|
{"unknown scheme", "Digest " + valid, http.StatusUnauthorized},
|
||||||
|
}
|
||||||
|
for _, c := range cases {
|
||||||
|
if got := serveAuth(h, http.MethodPut, c.authz); got != c.want {
|
||||||
|
t.Errorf("%s: status %d, want %d", c.name, got, c.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestRequireRegistryWrites(t *testing.T) {
|
||||||
|
iss := testsupport.NewOIDCIssuer()
|
||||||
|
defer iss.Close()
|
||||||
|
h := NewBearerOIDC(iss.URL, []string{"artifactapi"}).RequireRegistryWrites(ok, func(*http.Request) string { return "https://reg.example/v2/token" })
|
||||||
|
valid := iss.Token(nil, "artifactapi", "ci", time.Hour)
|
||||||
|
do := func(method, path, authz string) *httptest.ResponseRecorder {
|
||||||
|
r := httptest.NewRequest(method, path, nil)
|
||||||
|
if authz != "" {
|
||||||
|
r.Header.Set("Authorization", authz)
|
||||||
|
}
|
||||||
|
w := httptest.NewRecorder()
|
||||||
|
h.ServeHTTP(w, r)
|
||||||
|
return w
|
||||||
|
}
|
||||||
|
challenge := `Bearer realm="https://reg.example/v2/token",service="artifactapi"`
|
||||||
|
|
||||||
|
w := do(http.MethodGet, "/v2/", "")
|
||||||
|
if w.Code != http.StatusUnauthorized || w.Header().Get("WWW-Authenticate") != challenge {
|
||||||
|
t.Errorf("anonymous ping: %d %q", w.Code, w.Header().Get("WWW-Authenticate"))
|
||||||
|
}
|
||||||
|
if w := do(http.MethodGet, "/v2/", "Bearer anonymous"); w.Code != http.StatusNoContent {
|
||||||
|
t.Errorf("ping with token: %d", w.Code)
|
||||||
|
}
|
||||||
|
if w := do(http.MethodGet, "/v2/token", ""); w.Code != http.StatusOK || !strings.Contains(w.Body.String(), `"token":"anonymous"`) {
|
||||||
|
t.Errorf("anonymous token: %d %s", w.Code, w.Body)
|
||||||
|
}
|
||||||
|
if w := do(http.MethodGet, "/v2/token", basic("ci", valid)); w.Code != http.StatusOK || !strings.Contains(w.Body.String(), `"token":"`+valid+`"`) {
|
||||||
|
t.Errorf("token exchange: %d %s", w.Code, w.Body)
|
||||||
|
}
|
||||||
|
expired := iss.Token(nil, "artifactapi", "ci", -time.Minute)
|
||||||
|
for _, authz := range []string{basic("ci", "bogus"), basic("ci", expired), "Bearer " + expired} {
|
||||||
|
if w := do(http.MethodGet, "/v2/token", authz); w.Code != http.StatusOK || !strings.Contains(w.Body.String(), `"token":"anonymous"`) {
|
||||||
|
t.Errorf("rejected credential %q: %d %s", authz, w.Code, w.Body)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, m := range []string{http.MethodGet, http.MethodHead} {
|
||||||
|
if w := do(m, "/v2/repo/img/manifests/t", ""); w.Code != http.StatusNoContent {
|
||||||
|
t.Errorf("anonymous %s: %d", m, w.Code)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, m := range []string{http.MethodPost, http.MethodPatch, http.MethodPut, http.MethodDelete} {
|
||||||
|
w := do(m, "/v2/repo/img/blobs/uploads/", "Bearer anonymous")
|
||||||
|
if w.Code != http.StatusUnauthorized || w.Header().Get("WWW-Authenticate") != challenge {
|
||||||
|
t.Errorf("anonymous %s: %d %q", m, w.Code, w.Header().Get("WWW-Authenticate"))
|
||||||
|
}
|
||||||
|
for _, authz := range []string{"Bearer " + valid, basic("ci", valid)} {
|
||||||
|
if w := do(m, "/v2/repo/img/blobs/uploads/", authz); w.Code != http.StatusNoContent {
|
||||||
|
t.Errorf("authenticated %s: %d", m, w.Code)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if got := serve(NewBearerOIDC("", nil).RequireRegistryWrites(ok, nil), http.MethodPut, ""); got != http.StatusNoContent {
|
||||||
|
t.Errorf("disabled: status %d", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
Vendored
+14
@@ -84,6 +84,20 @@ func (r *Redis) GetETag(ctx context.Context, remote, path string) (string, error
|
|||||||
return val, err
|
return val, err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// FirstSeen records now as the first sighting of path unless one is already
|
||||||
|
// stored, and returns the stored sighting.
|
||||||
|
func (r *Redis) FirstSeen(ctx context.Context, remote, path string, ttl time.Duration) (time.Time, error) {
|
||||||
|
key := fmt.Sprintf("firstseen:%s:%s", remote, path)
|
||||||
|
if err := r.client.SetNX(ctx, key, time.Now().Unix(), ttl).Err(); err != nil {
|
||||||
|
return time.Time{}, err
|
||||||
|
}
|
||||||
|
sec, err := r.client.Get(ctx, key).Int64()
|
||||||
|
if err != nil {
|
||||||
|
return time.Time{}, err
|
||||||
|
}
|
||||||
|
return time.Unix(sec, 0), nil
|
||||||
|
}
|
||||||
|
|
||||||
func (r *Redis) GetToken(ctx context.Context, key string) (string, error) {
|
func (r *Redis) GetToken(ctx context.Context, key string) (string, error) {
|
||||||
val, err := r.client.Get(ctx, "token:"+key).Result()
|
val, err := r.client.Get(ctx, "token:"+key).Result()
|
||||||
if err == redis.Nil {
|
if err == redis.Nil {
|
||||||
|
|||||||
@@ -61,6 +61,8 @@ type Config struct {
|
|||||||
// Bearer-JWT auth on configuration writes; empty issuer disables it.
|
// Bearer-JWT auth on configuration writes; empty issuer disables it.
|
||||||
OIDCIssuer string
|
OIDCIssuer string
|
||||||
OIDCAudiences []string
|
OIDCAudiences []string
|
||||||
|
// AuthUploads extends that auth to local repo uploads, deletes and evictions.
|
||||||
|
AuthUploads bool
|
||||||
}
|
}
|
||||||
|
|
||||||
func (c *Config) DatabaseDSN() string {
|
func (c *Config) DatabaseDSN() string {
|
||||||
@@ -105,6 +107,13 @@ func Load() (*Config, error) {
|
|||||||
if oidcIssuer != "" && len(oidcAudiences) == 0 {
|
if oidcIssuer != "" && len(oidcAudiences) == 0 {
|
||||||
return nil, fmt.Errorf("ARTIFACTAPI_OIDC_AUDIENCE is required when ARTIFACTAPI_OIDC_ISSUER is set")
|
return nil, fmt.Errorf("ARTIFACTAPI_OIDC_AUDIENCE is required when ARTIFACTAPI_OIDC_ISSUER is set")
|
||||||
}
|
}
|
||||||
|
authUploads, err := strconv.ParseBool(getenv("ARTIFACTAPI_AUTH_UPLOADS", "false"))
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("invalid ARTIFACTAPI_AUTH_UPLOADS: %w", err)
|
||||||
|
}
|
||||||
|
if authUploads && oidcIssuer == "" {
|
||||||
|
return nil, fmt.Errorf("ARTIFACTAPI_OIDC_ISSUER is required when ARTIFACTAPI_AUTH_UPLOADS is set")
|
||||||
|
}
|
||||||
|
|
||||||
cfg := &Config{
|
cfg := &Config{
|
||||||
ListenAddr: getenv("LISTEN_ADDR", ":8000"),
|
ListenAddr: getenv("LISTEN_ADDR", ":8000"),
|
||||||
@@ -142,6 +151,7 @@ func Load() (*Config, error) {
|
|||||||
|
|
||||||
OIDCIssuer: oidcIssuer,
|
OIDCIssuer: oidcIssuer,
|
||||||
OIDCAudiences: oidcAudiences,
|
OIDCAudiences: oidcAudiences,
|
||||||
|
AuthUploads: authUploads,
|
||||||
}
|
}
|
||||||
|
|
||||||
return cfg, nil
|
return cfg, nil
|
||||||
|
|||||||
@@ -81,3 +81,23 @@ func TestLoadOIDC(t *testing.T) {
|
|||||||
t.Error("expected error for issuer without audience")
|
t.Error("expected error for issuer without audience")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestLoadAuthUploads(t *testing.T) {
|
||||||
|
cfg, err := Load()
|
||||||
|
if err != nil || cfg.AuthUploads {
|
||||||
|
t.Fatalf("default: %v, AuthUploads=%v", err, cfg.AuthUploads)
|
||||||
|
}
|
||||||
|
t.Setenv("ARTIFACTAPI_AUTH_UPLOADS", "true")
|
||||||
|
if _, err := Load(); err == nil {
|
||||||
|
t.Error("expected error for AUTH_UPLOADS without issuer")
|
||||||
|
}
|
||||||
|
t.Setenv("ARTIFACTAPI_OIDC_ISSUER", "https://vault.example/v1/identity/oidc")
|
||||||
|
t.Setenv("ARTIFACTAPI_OIDC_AUDIENCE", "artifactapi")
|
||||||
|
if cfg, err := Load(); err != nil || !cfg.AuthUploads {
|
||||||
|
t.Fatalf("enabled: %v, AuthUploads=%v", err, cfg.AuthUploads)
|
||||||
|
}
|
||||||
|
t.Setenv("ARTIFACTAPI_AUTH_UPLOADS", "maybe")
|
||||||
|
if _, err := Load(); err == nil {
|
||||||
|
t.Error("expected error for invalid ARTIFACTAPI_AUTH_UPLOADS")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -307,6 +307,68 @@ func TestLocalFiles(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A repo recreated under a deleted repo's name must not inherit its files or
|
||||||
|
// metadata, or re-uploading the same path 409s.
|
||||||
|
func TestDeleteRemoteDropsLocalFiles(t *testing.T) {
|
||||||
|
requireDB(t)
|
||||||
|
seedRemote(t, "r-recreate")
|
||||||
|
hash := seedBlob(t, "recreatehash")
|
||||||
|
if err := testDB.CreateLocalFile(ctx(), "r-recreate", "x86_64/a-1.0-r0.apk", hash); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := testDB.InsertAlpineMetadata(ctx(), &provider.AlpineMetadata{RepoName: "r-recreate", FilePath: "x86_64/a-1.0-r0.apk", ContentHash: hash, Name: "a", Version: "1.0-r0", Arch: "x86_64"}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := testDB.DeleteRemote(ctx(), "r-recreate"); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
seedRemote(t, "r-recreate")
|
||||||
|
defer testDB.DeleteRemote(ctx(), "r-recreate")
|
||||||
|
if f, err := testDB.GetLocalFile(ctx(), "r-recreate", "x86_64/a-1.0-r0.apk"); err != nil || f != nil {
|
||||||
|
t.Fatalf("recreated repo inherited local file: %v %v", f, err)
|
||||||
|
}
|
||||||
|
if rows, err := testDB.ListAlpineMetadataEntries(ctx(), "r-recreate"); err != nil || len(rows) != 0 {
|
||||||
|
t.Fatalf("recreated repo inherited alpine metadata: %v %v", rows, err)
|
||||||
|
}
|
||||||
|
if err := testDB.CreateLocalFile(ctx(), "r-recreate", "x86_64/a-1.0-r0.apk", hash); err != nil {
|
||||||
|
t.Fatalf("re-upload after recreate: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestVirtualParallelFetchRoundTrip(t *testing.T) {
|
||||||
|
requireDB(t)
|
||||||
|
if err := testDB.CreateVirtual(ctx(), &models.Virtual{
|
||||||
|
Name: "v-parallel", PackageType: models.PackageRPM, Members: []string{"a"}, ParallelFetch: true,
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer func() { _ = testDB.DeleteVirtual(ctx(), "v-parallel") }()
|
||||||
|
v, err := testDB.GetVirtual(ctx(), "v-parallel")
|
||||||
|
if err != nil || !v.ParallelFetch {
|
||||||
|
t.Fatalf("created parallel_fetch = %v, %v; want true", v, err)
|
||||||
|
}
|
||||||
|
v.ParallelFetch = false
|
||||||
|
if err := testDB.UpdateVirtual(ctx(), v); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
vs, err := testDB.ListVirtuals(ctx())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
for _, l := range vs {
|
||||||
|
if l.Name == "v-parallel" && l.ParallelFetch {
|
||||||
|
t.Fatal("updated parallel_fetch not persisted")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err := testDB.CreateVirtual(ctx(), &models.Virtual{Name: "v-serial", PackageType: models.PackageRPM, Members: []string{"a"}}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer func() { _ = testDB.DeleteVirtual(ctx(), "v-serial") }()
|
||||||
|
if v, err := testDB.GetVirtual(ctx(), "v-serial"); err != nil || v.ParallelFetch {
|
||||||
|
t.Fatalf("default parallel_fetch = %v, %v; want false", v, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestVirtualsCRUD(t *testing.T) {
|
func TestVirtualsCRUD(t *testing.T) {
|
||||||
requireDB(t)
|
requireDB(t)
|
||||||
if err := testDB.CreateVirtual(ctx(), &models.Virtual{
|
if err := testDB.CreateVirtual(ctx(), &models.Virtual{
|
||||||
|
|||||||
@@ -3,6 +3,8 @@ package database
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
|
|
||||||
|
"github.com/jackc/pgx/v5"
|
||||||
|
|
||||||
"git.unkin.net/unkin/artifactapi/pkg/models"
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -13,7 +15,7 @@ const remoteCols = `name, package_type, repo_type, base_url, mirrorlist, mirror_
|
|||||||
quarantine_enabled, quarantine_days, stale_on_error,
|
quarantine_enabled, quarantine_days, stale_on_error,
|
||||||
releases_remote, managed_by,
|
releases_remote, managed_by,
|
||||||
upstream_dial_timeout, upstream_tls_timeout, upstream_response_header_timeout,
|
upstream_dial_timeout, upstream_tls_timeout, upstream_response_header_timeout,
|
||||||
created_at, updated_at`
|
serve_stale, created_at, updated_at`
|
||||||
|
|
||||||
// normalizeMirrorStrategy maps an empty strategy to the round_robin default so
|
// normalizeMirrorStrategy maps an empty strategy to the round_robin default so
|
||||||
// the NOT NULL mirror_strategy column always stores a canonical value.
|
// the NOT NULL mirror_strategy column always stores a canonical value.
|
||||||
@@ -33,7 +35,7 @@ func scanRemote(scanner interface{ Scan(...any) error }, r *models.Remote) error
|
|||||||
&r.QuarantineEnabled, &r.QuarantineDays, &r.StaleOnError,
|
&r.QuarantineEnabled, &r.QuarantineDays, &r.StaleOnError,
|
||||||
&r.ReleasesRemote, &r.ManagedBy,
|
&r.ReleasesRemote, &r.ManagedBy,
|
||||||
&r.UpstreamDialTimeout, &r.UpstreamTLSTimeout, &r.UpstreamResponseHeaderTimeout,
|
&r.UpstreamDialTimeout, &r.UpstreamTLSTimeout, &r.UpstreamResponseHeaderTimeout,
|
||||||
&r.CreatedAt, &r.UpdatedAt,
|
&r.ServeStale, &r.CreatedAt, &r.UpdatedAt,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -74,8 +76,8 @@ func (db *DB) CreateRemote(ctx context.Context, r *models.Remote) error {
|
|||||||
quarantine_enabled, quarantine_days, stale_on_error,
|
quarantine_enabled, quarantine_days, stale_on_error,
|
||||||
releases_remote, managed_by,
|
releases_remote, managed_by,
|
||||||
upstream_dial_timeout, upstream_tls_timeout, upstream_response_header_timeout,
|
upstream_dial_timeout, upstream_tls_timeout, upstream_response_header_timeout,
|
||||||
mirror_strategy
|
mirror_strategy, serve_stale
|
||||||
) VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19,$20,$21,$22,$23,$24,$25,$26)
|
) VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19,$20,$21,$22,$23,$24,$25,$26,$27)
|
||||||
`,
|
`,
|
||||||
r.Name, r.PackageType, r.RepoType, r.BaseURL, r.Mirrorlist, r.Description, r.Username, r.Password,
|
r.Name, r.PackageType, r.RepoType, r.BaseURL, r.Mirrorlist, r.Description, r.Username, r.Password,
|
||||||
r.ImmutableTTL, r.MutableTTL, r.CheckMutable,
|
r.ImmutableTTL, r.MutableTTL, r.CheckMutable,
|
||||||
@@ -84,7 +86,7 @@ func (db *DB) CreateRemote(ctx context.Context, r *models.Remote) error {
|
|||||||
r.QuarantineEnabled, r.QuarantineDays, r.StaleOnError,
|
r.QuarantineEnabled, r.QuarantineDays, r.StaleOnError,
|
||||||
r.ReleasesRemote, r.ManagedBy,
|
r.ReleasesRemote, r.ManagedBy,
|
||||||
r.UpstreamDialTimeout, r.UpstreamTLSTimeout, r.UpstreamResponseHeaderTimeout,
|
r.UpstreamDialTimeout, r.UpstreamTLSTimeout, r.UpstreamResponseHeaderTimeout,
|
||||||
normalizeMirrorStrategy(r.MirrorStrategy),
|
normalizeMirrorStrategy(r.MirrorStrategy), r.ServeStale,
|
||||||
)
|
)
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -99,7 +101,7 @@ func (db *DB) UpdateRemote(ctx context.Context, r *models.Remote) error {
|
|||||||
quarantine_enabled=$17, quarantine_days=$18, stale_on_error=$19,
|
quarantine_enabled=$17, quarantine_days=$18, stale_on_error=$19,
|
||||||
releases_remote=$20, managed_by=$21,
|
releases_remote=$20, managed_by=$21,
|
||||||
upstream_dial_timeout=$22, upstream_tls_timeout=$23, upstream_response_header_timeout=$24,
|
upstream_dial_timeout=$22, upstream_tls_timeout=$23, upstream_response_header_timeout=$24,
|
||||||
mirror_strategy=$26,
|
mirror_strategy=$26, serve_stale=$27,
|
||||||
updated_at=NOW()
|
updated_at=NOW()
|
||||||
WHERE name=$1
|
WHERE name=$1
|
||||||
`,
|
`,
|
||||||
@@ -111,12 +113,21 @@ func (db *DB) UpdateRemote(ctx context.Context, r *models.Remote) error {
|
|||||||
r.ReleasesRemote, r.ManagedBy,
|
r.ReleasesRemote, r.ManagedBy,
|
||||||
r.UpstreamDialTimeout, r.UpstreamTLSTimeout, r.UpstreamResponseHeaderTimeout,
|
r.UpstreamDialTimeout, r.UpstreamTLSTimeout, r.UpstreamResponseHeaderTimeout,
|
||||||
r.Mirrorlist,
|
r.Mirrorlist,
|
||||||
normalizeMirrorStrategy(r.MirrorStrategy),
|
normalizeMirrorStrategy(r.MirrorStrategy), r.ServeStale,
|
||||||
)
|
)
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// DeleteRemote drops a remote with its local files and package metadata, so a
|
||||||
|
// repo recreated under the same name starts empty.
|
||||||
func (db *DB) DeleteRemote(ctx context.Context, name string) error {
|
func (db *DB) DeleteRemote(ctx context.Context, name string) error {
|
||||||
_, err := db.Pool.Exec(ctx, `DELETE FROM remotes WHERE name = $1`, name)
|
return pgx.BeginFunc(ctx, db.Pool, func(tx pgx.Tx) error {
|
||||||
return err
|
for _, table := range []string{"local_files", "rpm_metadata", "deb_metadata", "alpine_metadata", "puppet_metadata", "helm_metadata"} {
|
||||||
|
if _, err := tx.Exec(ctx, `DELETE FROM `+table+` WHERE repo_name = $1`, name); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
_, err := tx.Exec(ctx, `DELETE FROM remotes WHERE name = $1`, name)
|
||||||
|
return err
|
||||||
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -8,12 +8,12 @@ import (
|
|||||||
|
|
||||||
func (db *DB) GetVirtual(ctx context.Context, name string) (*models.Virtual, error) {
|
func (db *DB) GetVirtual(ctx context.Context, name string) (*models.Virtual, error) {
|
||||||
row := db.Pool.QueryRow(ctx, `
|
row := db.Pool.QueryRow(ctx, `
|
||||||
SELECT name, package_type, description, members, managed_by, created_at, updated_at
|
SELECT name, package_type, description, members, managed_by, parallel_fetch, created_at, updated_at
|
||||||
FROM virtuals WHERE name = $1
|
FROM virtuals WHERE name = $1
|
||||||
`, name)
|
`, name)
|
||||||
|
|
||||||
var v models.Virtual
|
var v models.Virtual
|
||||||
err := row.Scan(&v.Name, &v.PackageType, &v.Description, &v.Members, &v.ManagedBy, &v.CreatedAt, &v.UpdatedAt)
|
err := row.Scan(&v.Name, &v.PackageType, &v.Description, &v.Members, &v.ManagedBy, &v.ParallelFetch, &v.CreatedAt, &v.UpdatedAt)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -22,7 +22,7 @@ func (db *DB) GetVirtual(ctx context.Context, name string) (*models.Virtual, err
|
|||||||
|
|
||||||
func (db *DB) ListVirtuals(ctx context.Context) ([]models.Virtual, error) {
|
func (db *DB) ListVirtuals(ctx context.Context) ([]models.Virtual, error) {
|
||||||
rows, err := db.Pool.Query(ctx, `
|
rows, err := db.Pool.Query(ctx, `
|
||||||
SELECT name, package_type, description, members, managed_by, created_at, updated_at
|
SELECT name, package_type, description, members, managed_by, parallel_fetch, created_at, updated_at
|
||||||
FROM virtuals ORDER BY name
|
FROM virtuals ORDER BY name
|
||||||
`)
|
`)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -33,7 +33,7 @@ func (db *DB) ListVirtuals(ctx context.Context) ([]models.Virtual, error) {
|
|||||||
var virtuals []models.Virtual
|
var virtuals []models.Virtual
|
||||||
for rows.Next() {
|
for rows.Next() {
|
||||||
var v models.Virtual
|
var v models.Virtual
|
||||||
if err := rows.Scan(&v.Name, &v.PackageType, &v.Description, &v.Members, &v.ManagedBy, &v.CreatedAt, &v.UpdatedAt); err != nil {
|
if err := rows.Scan(&v.Name, &v.PackageType, &v.Description, &v.Members, &v.ManagedBy, &v.ParallelFetch, &v.CreatedAt, &v.UpdatedAt); err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
virtuals = append(virtuals, v)
|
virtuals = append(virtuals, v)
|
||||||
@@ -43,18 +43,18 @@ func (db *DB) ListVirtuals(ctx context.Context) ([]models.Virtual, error) {
|
|||||||
|
|
||||||
func (db *DB) CreateVirtual(ctx context.Context, v *models.Virtual) error {
|
func (db *DB) CreateVirtual(ctx context.Context, v *models.Virtual) error {
|
||||||
_, err := db.Pool.Exec(ctx, `
|
_, err := db.Pool.Exec(ctx, `
|
||||||
INSERT INTO virtuals (name, package_type, description, members, managed_by)
|
INSERT INTO virtuals (name, package_type, description, members, managed_by, parallel_fetch)
|
||||||
VALUES ($1, $2, $3, $4, $5)
|
VALUES ($1, $2, $3, $4, $5, $6)
|
||||||
`, v.Name, v.PackageType, v.Description, v.Members, v.ManagedBy)
|
`, v.Name, v.PackageType, v.Description, v.Members, v.ManagedBy, v.ParallelFetch)
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
func (db *DB) UpdateVirtual(ctx context.Context, v *models.Virtual) error {
|
func (db *DB) UpdateVirtual(ctx context.Context, v *models.Virtual) error {
|
||||||
_, err := db.Pool.Exec(ctx, `
|
_, err := db.Pool.Exec(ctx, `
|
||||||
UPDATE virtuals SET
|
UPDATE virtuals SET
|
||||||
package_type=$2, description=$3, members=$4, managed_by=$5, updated_at=NOW()
|
package_type=$2, description=$3, members=$4, managed_by=$5, parallel_fetch=$6, updated_at=NOW()
|
||||||
WHERE name=$1
|
WHERE name=$1
|
||||||
`, v.Name, v.PackageType, v.Description, v.Members, v.ManagedBy)
|
`, v.Name, v.PackageType, v.Description, v.Members, v.ManagedBy, v.ParallelFetch)
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,3 @@
|
|||||||
|
package all
|
||||||
|
|
||||||
|
import _ "git.unkin.net/unkin/artifactapi/internal/provider/vcs"
|
||||||
@@ -71,7 +71,7 @@ func (p *Provider) AuthHeaders(ctx context.Context, remote models.Remote) (http.
|
|||||||
h.Set("Authorization", "Basic "+base64.StdEncoding.EncodeToString([]byte(remote.Username+":"+remote.Password)))
|
h.Set("Authorization", "Basic "+base64.StdEncoding.EncodeToString([]byte(remote.Username+":"+remote.Password)))
|
||||||
return h, nil
|
return h, nil
|
||||||
}
|
}
|
||||||
if isGitHubHost(remote.BaseURL) {
|
if IsGitHubHost(remote.BaseURL) {
|
||||||
if c := githubauth.Server(); c != nil {
|
if c := githubauth.Server(); c != nil {
|
||||||
tok, err := c.Token(ctx)
|
tok, err := c.Token(ctx)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -85,11 +85,11 @@ func (p *Provider) AuthHeaders(ctx context.Context, remote models.Remote) (http.
|
|||||||
return h, nil
|
return h, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// isGitHubHost reports whether rawURL targets a GitHub API/download host that
|
// IsGitHubHost reports whether rawURL targets a GitHub API/download host that
|
||||||
// accepts the server credential. objects.githubusercontent.com is deliberately
|
// accepts the server credential. objects.githubusercontent.com is deliberately
|
||||||
// excluded: release-asset downloads 302-redirect there with a pre-signed URL
|
// excluded: release-asset downloads 302-redirect there with a pre-signed URL
|
||||||
// that must not carry an Authorization header.
|
// that must not carry an Authorization header.
|
||||||
func isGitHubHost(rawURL string) bool {
|
func IsGitHubHost(rawURL string) bool {
|
||||||
u, err := url.Parse(rawURL)
|
u, err := url.Parse(rawURL)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return false
|
return false
|
||||||
|
|||||||
@@ -0,0 +1,309 @@
|
|||||||
|
// Package vcs caches source archives and release assets from GitHub or Gitea,
|
||||||
|
// keyed by ref: tags, commits and release assets are immutable, and branch
|
||||||
|
// archives redirect to the archive of the commit the branch currently points at.
|
||||||
|
package vcs
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"net/http"
|
||||||
|
"net/url"
|
||||||
|
"regexp"
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"golang.org/x/sync/singleflight"
|
||||||
|
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/provider"
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/provider/generic"
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/proxy"
|
||||||
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
||||||
|
)
|
||||||
|
|
||||||
|
func init() {
|
||||||
|
provider.Register(New())
|
||||||
|
}
|
||||||
|
|
||||||
|
type kind int
|
||||||
|
|
||||||
|
const (
|
||||||
|
tagArchive kind = iota + 1
|
||||||
|
branchArchive
|
||||||
|
commitArchive
|
||||||
|
releaseAsset
|
||||||
|
latestReleaseAsset
|
||||||
|
)
|
||||||
|
|
||||||
|
// target is a parsed vcs request path.
|
||||||
|
type target struct {
|
||||||
|
Kind kind
|
||||||
|
Owner, Repo string
|
||||||
|
Name string // tag, branch, commit or asset
|
||||||
|
Ext string
|
||||||
|
}
|
||||||
|
|
||||||
|
var (
|
||||||
|
segmentRe = regexp.MustCompile(`^[A-Za-z0-9._+-]+$`)
|
||||||
|
commitRe = regexp.MustCompile(`^[0-9a-f]{40}$`)
|
||||||
|
)
|
||||||
|
|
||||||
|
var errNotFound = errors.New("ref not found")
|
||||||
|
|
||||||
|
const (
|
||||||
|
maxRefs = 4096
|
||||||
|
negativeTTL = time.Minute
|
||||||
|
)
|
||||||
|
|
||||||
|
// Provider embeds generic for upstream URLs, content types and GitHub/Basic auth.
|
||||||
|
type Provider struct {
|
||||||
|
generic.Provider
|
||||||
|
|
||||||
|
client *http.Client
|
||||||
|
githubAPI string
|
||||||
|
|
||||||
|
group singleflight.Group
|
||||||
|
mu sync.Mutex
|
||||||
|
refs map[string]map[string]resolved
|
||||||
|
}
|
||||||
|
|
||||||
|
// resolved is a branch lookup; an empty commit records a missing branch.
|
||||||
|
type resolved struct {
|
||||||
|
commit string
|
||||||
|
at time.Time
|
||||||
|
}
|
||||||
|
|
||||||
|
func New() *Provider {
|
||||||
|
return &Provider{
|
||||||
|
client: &http.Client{Timeout: 30 * time.Second},
|
||||||
|
githubAPI: "https://api.github.com",
|
||||||
|
refs: map[string]map[string]resolved{},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (p *Provider) Type() models.PackageType { return models.PackageVCS }
|
||||||
|
|
||||||
|
func (p *Provider) Classify(path string) provider.Mutability {
|
||||||
|
if ref, ok := parsePath(path); ok && (ref.Kind == branchArchive || ref.Kind == latestReleaseAsset) {
|
||||||
|
return provider.Mutable
|
||||||
|
}
|
||||||
|
return provider.Immutable
|
||||||
|
}
|
||||||
|
|
||||||
|
// parsePath accepts only the archive and release-download shapes, rejecting
|
||||||
|
// any segment that could escape owner/repo or a ref.
|
||||||
|
func parsePath(path string) (target, bool) {
|
||||||
|
parts := strings.SplitN(strings.TrimPrefix(path, "/"), "/", 3)
|
||||||
|
if len(parts) != 3 || !validSegment(parts[0]) || !validSegment(parts[1]) {
|
||||||
|
return target{}, false
|
||||||
|
}
|
||||||
|
ref := target{Owner: parts[0], Repo: parts[1]}
|
||||||
|
rest := parts[2]
|
||||||
|
switch {
|
||||||
|
case strings.HasPrefix(rest, "archive/"):
|
||||||
|
name, ext, ok := archiveName(strings.TrimPrefix(rest, "archive/"))
|
||||||
|
if !ok {
|
||||||
|
return target{}, false
|
||||||
|
}
|
||||||
|
ref.Ext = ext
|
||||||
|
switch {
|
||||||
|
case strings.HasPrefix(name, "refs/tags/"):
|
||||||
|
ref.Kind, ref.Name = tagArchive, strings.TrimPrefix(name, "refs/tags/")
|
||||||
|
case strings.HasPrefix(name, "refs/heads/"):
|
||||||
|
ref.Kind, ref.Name = branchArchive, strings.TrimPrefix(name, "refs/heads/")
|
||||||
|
case commitRe.MatchString(name):
|
||||||
|
return target{Kind: commitArchive, Owner: ref.Owner, Repo: ref.Repo, Name: name, Ext: ext}, true
|
||||||
|
default:
|
||||||
|
return target{}, false
|
||||||
|
}
|
||||||
|
return ref, validRefName(ref.Name)
|
||||||
|
case strings.HasPrefix(rest, "releases/latest/download/"):
|
||||||
|
ref.Kind, ref.Name = latestReleaseAsset, strings.TrimPrefix(rest, "releases/latest/download/")
|
||||||
|
return ref, validSegment(ref.Name)
|
||||||
|
case strings.HasPrefix(rest, "releases/download/"):
|
||||||
|
tagAsset := strings.TrimPrefix(rest, "releases/download/")
|
||||||
|
i := strings.LastIndex(tagAsset, "/")
|
||||||
|
if i < 0 {
|
||||||
|
return target{}, false
|
||||||
|
}
|
||||||
|
ref.Kind, ref.Name = releaseAsset, tagAsset[i+1:]
|
||||||
|
return ref, validRefName(tagAsset[:i]) && validSegment(ref.Name)
|
||||||
|
}
|
||||||
|
return target{}, false
|
||||||
|
}
|
||||||
|
|
||||||
|
func archiveName(s string) (string, string, bool) {
|
||||||
|
for _, ext := range []string{".tar.gz", ".zip"} {
|
||||||
|
if name, ok := strings.CutSuffix(s, ext); ok && name != "" {
|
||||||
|
return name, ext, true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return "", "", false
|
||||||
|
}
|
||||||
|
|
||||||
|
func validSegment(s string) bool {
|
||||||
|
return segmentRe.MatchString(s) && s != "." && s != ".." && !strings.Contains(s, "..")
|
||||||
|
}
|
||||||
|
|
||||||
|
func validRefName(s string) bool {
|
||||||
|
for _, seg := range strings.Split(s, "/") {
|
||||||
|
if !validSegment(seg) || strings.HasPrefix(seg, ".") {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// ServeRemote rejects unsupported paths and redirects branch archives to the
|
||||||
|
// immutable archive of the branch's current commit; everything else is proxied.
|
||||||
|
func (p *Provider) ServeRemote(w http.ResponseWriter, r *http.Request, remote models.Remote, path, proxyBaseURL string, _ provider.RemoteMetadataStore) bool {
|
||||||
|
ref, ok := parsePath(path)
|
||||||
|
if !ok {
|
||||||
|
http.Error(w, "unsupported vcs path", http.StatusNotFound)
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
if ref.Kind != branchArchive {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
classifier := proxy.NewClassifier(p)
|
||||||
|
if classifier.Classify(remote, path) == proxy.ClassDenied {
|
||||||
|
http.Error(w, "access denied", http.StatusForbidden)
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
commit, err := p.resolve(r.Context(), remote, ref)
|
||||||
|
var se *provider.UpstreamStatusError
|
||||||
|
switch {
|
||||||
|
case errors.Is(err, errNotFound):
|
||||||
|
http.Error(w, "branch not found", http.StatusNotFound)
|
||||||
|
return true
|
||||||
|
case errors.As(err, &se) && (se.Status == http.StatusTooManyRequests || se.Status == http.StatusForbidden && !se.RetryAt.IsZero()):
|
||||||
|
secs := 60
|
||||||
|
if !se.RetryAt.IsZero() {
|
||||||
|
secs = max(1, int(time.Until(se.RetryAt).Seconds()+1))
|
||||||
|
}
|
||||||
|
w.Header().Set("Retry-After", strconv.Itoa(secs))
|
||||||
|
http.Error(w, "upstream rate limited", http.StatusServiceUnavailable)
|
||||||
|
return true
|
||||||
|
case err != nil:
|
||||||
|
http.Error(w, "bad gateway", http.StatusBadGateway)
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
target := ref.Owner + "/" + ref.Repo + "/archive/" + commit + ref.Ext
|
||||||
|
if classifier.Classify(remote, target) == proxy.ClassDenied {
|
||||||
|
http.Error(w, "access denied", http.StatusForbidden)
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
http.Redirect(w, r, strings.TrimRight(proxyBaseURL, "/")+provider.RemoteMountPath+remote.Name+"/"+target, http.StatusFound)
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// resolve maps a branch to its commit, reusing the answer for mutable_ttl (a
|
||||||
|
// missing branch for at least negativeTTL) and, with stale_on_error, past an
|
||||||
|
// upstream failure. Concurrent lookups of one branch share a single API call.
|
||||||
|
func (p *Provider) resolve(ctx context.Context, remote models.Remote, ref target) (string, error) {
|
||||||
|
key := ref.Owner + "/" + ref.Repo + "\x00" + ref.Name
|
||||||
|
ttl := time.Duration(remote.MutableTTL) * time.Second
|
||||||
|
p.mu.Lock()
|
||||||
|
prev, ok := p.refs[remote.Name][key]
|
||||||
|
p.mu.Unlock()
|
||||||
|
if ok && prev.commit != "" && time.Since(prev.at) < ttl {
|
||||||
|
return prev.commit, nil
|
||||||
|
}
|
||||||
|
if ok && prev.commit == "" && time.Since(prev.at) < max(ttl, negativeTTL) {
|
||||||
|
return "", errNotFound
|
||||||
|
}
|
||||||
|
v, err, _ := p.group.Do(remote.Name+"\x00"+key, func() (any, error) {
|
||||||
|
commit, err := p.lookup(context.WithoutCancel(ctx), remote, ref)
|
||||||
|
if err == nil || errors.Is(err, errNotFound) {
|
||||||
|
p.store(remote.Name, key, commit)
|
||||||
|
}
|
||||||
|
return commit, err
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
if ok && prev.commit != "" && remote.StaleOnError && !errors.Is(err, errNotFound) {
|
||||||
|
return prev.commit, nil
|
||||||
|
}
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return v.(string), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// store records a lookup, evicting the remote's oldest entry once it holds maxRefs.
|
||||||
|
func (p *Provider) store(remote, key, commit string) {
|
||||||
|
p.mu.Lock()
|
||||||
|
defer p.mu.Unlock()
|
||||||
|
m := p.refs[remote]
|
||||||
|
if m == nil {
|
||||||
|
m = map[string]resolved{}
|
||||||
|
p.refs[remote] = m
|
||||||
|
}
|
||||||
|
if _, ok := m[key]; !ok && len(m) >= maxRefs {
|
||||||
|
var oldest string
|
||||||
|
for k, e := range m {
|
||||||
|
if oldest == "" || e.at.Before(m[oldest].at) {
|
||||||
|
oldest = k
|
||||||
|
}
|
||||||
|
}
|
||||||
|
delete(m, oldest)
|
||||||
|
}
|
||||||
|
m[key] = resolved{commit: commit, at: time.Now()}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (p *Provider) lookup(ctx context.Context, remote models.Remote, ref target) (string, error) {
|
||||||
|
segs := strings.Split(ref.Name, "/")
|
||||||
|
for i, s := range segs {
|
||||||
|
segs[i] = url.PathEscape(s)
|
||||||
|
}
|
||||||
|
branch := strings.Join(segs, "/")
|
||||||
|
github := generic.IsGitHubHost(remote.BaseURL)
|
||||||
|
api := strings.TrimRight(remote.BaseURL, "/") + "/api/v1/repos/" + ref.Owner + "/" + ref.Repo + "/branches/" + branch
|
||||||
|
if github {
|
||||||
|
api = p.githubAPI + "/repos/" + ref.Owner + "/" + ref.Repo + "/git/ref/heads/" + branch
|
||||||
|
}
|
||||||
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, api, nil)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
h, err := p.AuthHeaders(ctx, remote)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
req.Header = h
|
||||||
|
if github {
|
||||||
|
req.Header.Set("Accept", "application/vnd.github+json")
|
||||||
|
}
|
||||||
|
resp, err := p.client.Do(req)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
defer func() { _ = resp.Body.Close() }()
|
||||||
|
if resp.StatusCode == http.StatusNotFound || resp.StatusCode == http.StatusUnprocessableEntity {
|
||||||
|
return "", errNotFound
|
||||||
|
}
|
||||||
|
if resp.StatusCode != http.StatusOK {
|
||||||
|
return "", provider.NewUpstreamStatusError(api, resp)
|
||||||
|
}
|
||||||
|
var b struct {
|
||||||
|
Commit struct {
|
||||||
|
ID string `json:"id"`
|
||||||
|
} `json:"commit"`
|
||||||
|
Object struct {
|
||||||
|
SHA string `json:"sha"`
|
||||||
|
} `json:"object"`
|
||||||
|
}
|
||||||
|
if err := json.NewDecoder(io.LimitReader(resp.Body, 1<<20)).Decode(&b); err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
commit := b.Commit.ID
|
||||||
|
if github {
|
||||||
|
commit = b.Object.SHA
|
||||||
|
}
|
||||||
|
if !commitRe.MatchString(commit) {
|
||||||
|
return "", fmt.Errorf("branch lookup %s: unexpected commit %q", api, commit)
|
||||||
|
}
|
||||||
|
return commit, nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,378 @@
|
|||||||
|
package vcs
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"fmt"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"sync/atomic"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/githubauth"
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/provider"
|
||||||
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
||||||
|
)
|
||||||
|
|
||||||
|
const (
|
||||||
|
shaA = "4f2cfe92e3499f8581bf39db77e0a1431fa7b55c"
|
||||||
|
shaB = "7fa5434dbc083c853eef435d1915020345219d2f"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestParsePath(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
path string
|
||||||
|
ok bool
|
||||||
|
kind kind
|
||||||
|
name string
|
||||||
|
}{
|
||||||
|
{"cli/cli/archive/refs/tags/v2.60.0.tar.gz", true, tagArchive, "v2.60.0"},
|
||||||
|
{"/cli/cli/archive/refs/tags/v2.60.0.zip", true, tagArchive, "v2.60.0"},
|
||||||
|
{"o/r/archive/refs/tags/release/1.0.tar.gz", true, tagArchive, "release/1.0"},
|
||||||
|
{"o/r/archive/refs/heads/feature/x.tar.gz", true, branchArchive, "feature/x"},
|
||||||
|
{"o/r/archive/" + shaA + ".tar.gz", true, commitArchive, shaA},
|
||||||
|
{"o/r/releases/download/v1.0/tool_linux_amd64.tar.gz", true, releaseAsset, "tool_linux_amd64.tar.gz"},
|
||||||
|
{"o/r/releases/latest/download/tool.zip", true, latestReleaseAsset, "tool.zip"},
|
||||||
|
{"o/r/archive/main.tar.gz", false, 0, ""},
|
||||||
|
{"o/r/archive/" + shaA[:7] + ".tar.gz", false, 0, ""},
|
||||||
|
{"o/r/archive/refs/tags/v1.tar.bz2", false, 0, ""},
|
||||||
|
{"o/r/archive/refs/tags/.tar.gz", false, 0, ""},
|
||||||
|
{"../r/archive/refs/tags/v1.tar.gz", false, 0, ""},
|
||||||
|
{"o/../archive/refs/tags/v1.tar.gz", false, 0, ""},
|
||||||
|
{"o/r/archive/refs/tags/../../../etc/passwd.tar.gz", false, 0, ""},
|
||||||
|
{"o/r/archive/refs/heads/a//b.tar.gz", false, 0, ""},
|
||||||
|
{"o/r/archive/refs/heads/.hidden.tar.gz", false, 0, ""},
|
||||||
|
{"o/r/archive/refs/heads/a..b.tar.gz", false, 0, ""},
|
||||||
|
{"o/r/archive/refs/tags/v1%2f.tar.gz", false, 0, ""},
|
||||||
|
{"o/r/releases/download/v1/../x", false, 0, ""},
|
||||||
|
{"o/r/releases/download/asset", false, 0, ""},
|
||||||
|
{"o/r/raw/main/README.md", false, 0, ""},
|
||||||
|
{"o/r", false, 0, ""},
|
||||||
|
}
|
||||||
|
for _, tt := range tests {
|
||||||
|
ref, ok := parsePath(tt.path)
|
||||||
|
if ok != tt.ok || (ok && (ref.Kind != tt.kind || ref.Name != tt.name)) {
|
||||||
|
t.Errorf("parsePath(%q) = %+v, %v; want kind %v name %q ok %v", tt.path, ref, ok, tt.kind, tt.name, tt.ok)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestClassify(t *testing.T) {
|
||||||
|
p := New()
|
||||||
|
for path, want := range map[string]provider.Mutability{
|
||||||
|
"o/r/archive/refs/tags/v1.tar.gz": provider.Immutable,
|
||||||
|
"o/r/archive/" + shaA + ".zip": provider.Immutable,
|
||||||
|
"o/r/releases/download/v1/a.bin": provider.Immutable,
|
||||||
|
"o/r/archive/refs/heads/main.tar.gz": provider.Mutable,
|
||||||
|
"o/r/releases/latest/download/webui.zip": provider.Mutable,
|
||||||
|
} {
|
||||||
|
if got := p.Classify(path); got != want {
|
||||||
|
t.Errorf("Classify(%q) = %v, want %v", path, got, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type upstream struct {
|
||||||
|
srv *httptest.Server
|
||||||
|
hits atomic.Int32
|
||||||
|
commit atomic.Value
|
||||||
|
status atomic.Int32
|
||||||
|
header atomic.Value
|
||||||
|
accept atomic.Value
|
||||||
|
auth atomic.Value
|
||||||
|
path atomic.Value
|
||||||
|
gate chan struct{}
|
||||||
|
}
|
||||||
|
|
||||||
|
func newUpstream(t *testing.T, gitea bool) *upstream {
|
||||||
|
u := &upstream{}
|
||||||
|
u.commit.Store(shaA)
|
||||||
|
u.status.Store(http.StatusOK)
|
||||||
|
u.header.Store(http.Header{})
|
||||||
|
u.srv = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
u.hits.Add(1)
|
||||||
|
if u.gate != nil {
|
||||||
|
<-u.gate
|
||||||
|
}
|
||||||
|
u.accept.Store(r.Header.Get("Accept"))
|
||||||
|
u.auth.Store(r.Header.Get("Authorization"))
|
||||||
|
u.path.Store(r.URL.EscapedPath())
|
||||||
|
for k, v := range u.header.Load().(http.Header) {
|
||||||
|
w.Header()[k] = v
|
||||||
|
}
|
||||||
|
if s := int(u.status.Load()); s != http.StatusOK {
|
||||||
|
w.WriteHeader(s)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if gitea {
|
||||||
|
_, _ = w.Write([]byte(`{"name":"main","commit":{"id":"` + u.commit.Load().(string) + `"}}`))
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_, _ = w.Write([]byte(`{"ref":"refs/heads/main","object":{"sha":"` + u.commit.Load().(string) + `","type":"commit"}}`))
|
||||||
|
}))
|
||||||
|
t.Cleanup(u.srv.Close)
|
||||||
|
return u
|
||||||
|
}
|
||||||
|
|
||||||
|
func serve(p *Provider, remote models.Remote, path string) (*httptest.ResponseRecorder, bool) {
|
||||||
|
w := httptest.NewRecorder()
|
||||||
|
r := httptest.NewRequest(http.MethodGet, "/api/v1/remote/"+remote.Name+"/"+path, nil)
|
||||||
|
return w, p.ServeRemote(w, r, remote, path, "http://proxy", nil)
|
||||||
|
}
|
||||||
|
|
||||||
|
// age backdates every cached lookup of a remote by d.
|
||||||
|
func age(p *Provider, remote string, d time.Duration) {
|
||||||
|
p.mu.Lock()
|
||||||
|
defer p.mu.Unlock()
|
||||||
|
for k, e := range p.refs[remote] {
|
||||||
|
e.at = e.at.Add(-d)
|
||||||
|
p.refs[remote][k] = e
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type staticCred string
|
||||||
|
|
||||||
|
func (s staticCred) Token(context.Context) (string, error) { return string(s), nil }
|
||||||
|
|
||||||
|
func TestServeRemoteGiteaBranchRedirectsToCommit(t *testing.T) {
|
||||||
|
u := newUpstream(t, true)
|
||||||
|
p := New()
|
||||||
|
remote := models.Remote{Name: "gitea", BaseURL: u.srv.URL, MutableTTL: 3600, Username: "bot", Password: "pw"}
|
||||||
|
|
||||||
|
w, handled := serve(p, remote, "unkin/app/archive/refs/heads/feature/x.zip")
|
||||||
|
if !handled || w.Code != http.StatusFound {
|
||||||
|
t.Fatalf("handled=%v code=%d", handled, w.Code)
|
||||||
|
}
|
||||||
|
if got, want := w.Header().Get("Location"), "http://proxy/api/v1/remote/gitea/unkin/app/archive/"+shaA+".zip"; got != want {
|
||||||
|
t.Errorf("Location = %q, want %q", got, want)
|
||||||
|
}
|
||||||
|
if got := u.path.Load(); got != "/api/v1/repos/unkin/app/branches/feature/x" {
|
||||||
|
t.Errorf("api path = %q", got)
|
||||||
|
}
|
||||||
|
if got := u.auth.Load(); got != "Basic Ym90OnB3" {
|
||||||
|
t.Errorf("Authorization = %q, want remote basic auth", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteGitHubBranchUsesAPI(t *testing.T) {
|
||||||
|
githubauth.SetServer(staticCred("ghs_server"))
|
||||||
|
t.Cleanup(func() { githubauth.SetServer(nil) })
|
||||||
|
u := newUpstream(t, false)
|
||||||
|
p := New()
|
||||||
|
p.githubAPI = u.srv.URL
|
||||||
|
|
||||||
|
for _, base := range []string{"https://github.com", "https://www.github.com/", "https://api.github.com"} {
|
||||||
|
remote := models.Remote{Name: base, BaseURL: base, MutableTTL: 3600}
|
||||||
|
w, _ := serve(p, remote, "cli/cli/archive/refs/heads/feature/x.tar.gz")
|
||||||
|
if !strings.HasSuffix(w.Header().Get("Location"), "/cli/cli/archive/"+shaA+".tar.gz") {
|
||||||
|
t.Fatalf("%s: Location = %q", base, w.Header().Get("Location"))
|
||||||
|
}
|
||||||
|
if u.path.Load() != "/repos/cli/cli/git/ref/heads/feature/x" || u.accept.Load() != "application/vnd.github+json" {
|
||||||
|
t.Errorf("%s: api path %q accept %q", base, u.path.Load(), u.accept.Load())
|
||||||
|
}
|
||||||
|
if got := u.auth.Load(); got != "Bearer ghs_server" {
|
||||||
|
t.Errorf("%s: Authorization = %q, want server credential", base, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteBranchResolutionHonoursMutableTTL(t *testing.T) {
|
||||||
|
u := newUpstream(t, true)
|
||||||
|
p := New()
|
||||||
|
remote := models.Remote{Name: "g", BaseURL: u.srv.URL, MutableTTL: 600}
|
||||||
|
path := "o/r/archive/refs/heads/main.tar.gz"
|
||||||
|
|
||||||
|
serve(p, remote, path)
|
||||||
|
u.commit.Store(shaB)
|
||||||
|
age(p, remote.Name, 599*time.Second)
|
||||||
|
w, _ := serve(p, remote, path)
|
||||||
|
if u.hits.Load() != 1 || !strings.Contains(w.Header().Get("Location"), shaA) {
|
||||||
|
t.Fatalf("within ttl: hits=%d location=%q", u.hits.Load(), w.Header().Get("Location"))
|
||||||
|
}
|
||||||
|
|
||||||
|
age(p, remote.Name, 2*time.Second)
|
||||||
|
w, _ = serve(p, remote, path)
|
||||||
|
if u.hits.Load() != 2 || !strings.Contains(w.Header().Get("Location"), shaB) {
|
||||||
|
t.Fatalf("past ttl: hits=%d location=%q", u.hits.Load(), w.Header().Get("Location"))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteBranchUpstreamFailure(t *testing.T) {
|
||||||
|
path := "o/r/archive/refs/heads/main.tar.gz"
|
||||||
|
for _, tc := range []struct {
|
||||||
|
name string
|
||||||
|
stale bool
|
||||||
|
want int
|
||||||
|
}{
|
||||||
|
{"stale", true, http.StatusFound},
|
||||||
|
{"strict", false, http.StatusBadGateway},
|
||||||
|
} {
|
||||||
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
|
u := newUpstream(t, true)
|
||||||
|
p := New()
|
||||||
|
remote := models.Remote{Name: tc.name, BaseURL: u.srv.URL, StaleOnError: tc.stale}
|
||||||
|
serve(p, remote, path)
|
||||||
|
u.status.Store(http.StatusInternalServerError)
|
||||||
|
if w, _ := serve(p, remote, path); w.Code != tc.want {
|
||||||
|
t.Fatalf("code = %d, want %d", w.Code, tc.want)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteBranchRateLimited(t *testing.T) {
|
||||||
|
reset := strconv.FormatInt(time.Now().Add(120*time.Second).Unix(), 10)
|
||||||
|
for _, tc := range []struct {
|
||||||
|
name string
|
||||||
|
status int
|
||||||
|
header http.Header
|
||||||
|
want int
|
||||||
|
retry [2]int
|
||||||
|
}{
|
||||||
|
{"primary 403", http.StatusForbidden, http.Header{"X-Ratelimit-Remaining": {"0"}, "X-Ratelimit-Reset": {reset}}, http.StatusServiceUnavailable, [2]int{100, 122}},
|
||||||
|
{"secondary 403", http.StatusForbidden, http.Header{"Retry-After": {"30"}}, http.StatusServiceUnavailable, [2]int{30, 31}},
|
||||||
|
{"429", http.StatusTooManyRequests, http.Header{"Retry-After": {"5"}}, http.StatusServiceUnavailable, [2]int{5, 6}},
|
||||||
|
{"429 no hint", http.StatusTooManyRequests, http.Header{}, http.StatusServiceUnavailable, [2]int{60, 60}},
|
||||||
|
{"plain 403", http.StatusForbidden, http.Header{}, http.StatusBadGateway, [2]int{}},
|
||||||
|
} {
|
||||||
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
|
u := newUpstream(t, false)
|
||||||
|
u.status.Store(int32(tc.status))
|
||||||
|
u.header.Store(tc.header)
|
||||||
|
p := New()
|
||||||
|
p.githubAPI = u.srv.URL
|
||||||
|
w, _ := serve(p, models.Remote{Name: "gh", BaseURL: "https://github.com"}, "o/r/archive/refs/heads/main.tar.gz")
|
||||||
|
if w.Code != tc.want {
|
||||||
|
t.Fatalf("code = %d, want %d", w.Code, tc.want)
|
||||||
|
}
|
||||||
|
ra := w.Header().Get("Retry-After")
|
||||||
|
if tc.want != http.StatusServiceUnavailable {
|
||||||
|
if ra != "" {
|
||||||
|
t.Fatalf("Retry-After = %q on %d", ra, w.Code)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if n, err := strconv.Atoi(ra); err != nil || n < tc.retry[0] || n > tc.retry[1] {
|
||||||
|
t.Fatalf("Retry-After = %q, want %d..%d", ra, tc.retry[0], tc.retry[1])
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteBranchNotFoundIsCached(t *testing.T) {
|
||||||
|
u := newUpstream(t, false)
|
||||||
|
u.status.Store(http.StatusNotFound)
|
||||||
|
p := New()
|
||||||
|
p.githubAPI = u.srv.URL
|
||||||
|
remote := models.Remote{Name: "gh", BaseURL: "https://github.com"}
|
||||||
|
path := "o/r/archive/refs/heads/nope.tar.gz"
|
||||||
|
|
||||||
|
for range 3 {
|
||||||
|
if w, _ := serve(p, remote, path); w.Code != http.StatusNotFound {
|
||||||
|
t.Fatalf("code = %d, want 404", w.Code)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if u.hits.Load() != 1 {
|
||||||
|
t.Fatalf("hits = %d, want 1 within negative ttl", u.hits.Load())
|
||||||
|
}
|
||||||
|
u.status.Store(http.StatusOK)
|
||||||
|
age(p, remote.Name, negativeTTL)
|
||||||
|
if w, _ := serve(p, remote, path); w.Code != http.StatusFound || u.hits.Load() != 2 {
|
||||||
|
t.Fatalf("after negative ttl: code=%d hits=%d", w.Code, u.hits.Load())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteConcurrentLookupsShareOneCall(t *testing.T) {
|
||||||
|
u := newUpstream(t, true)
|
||||||
|
u.gate = make(chan struct{})
|
||||||
|
p := New()
|
||||||
|
remote := models.Remote{Name: "g", BaseURL: u.srv.URL, MutableTTL: 600}
|
||||||
|
|
||||||
|
var wg sync.WaitGroup
|
||||||
|
codes := make([]int, 20)
|
||||||
|
for i := range codes {
|
||||||
|
wg.Add(1)
|
||||||
|
go func() {
|
||||||
|
defer wg.Done()
|
||||||
|
w, _ := serve(p, remote, "o/r/archive/refs/heads/main.tar.gz")
|
||||||
|
codes[i] = w.Code
|
||||||
|
}()
|
||||||
|
}
|
||||||
|
for u.hits.Load() == 0 {
|
||||||
|
time.Sleep(time.Millisecond)
|
||||||
|
}
|
||||||
|
time.Sleep(50 * time.Millisecond)
|
||||||
|
close(u.gate)
|
||||||
|
wg.Wait()
|
||||||
|
if u.hits.Load() != 1 {
|
||||||
|
t.Fatalf("hits = %d, want 1", u.hits.Load())
|
||||||
|
}
|
||||||
|
for i, c := range codes {
|
||||||
|
if c != http.StatusFound {
|
||||||
|
t.Fatalf("request %d: code %d", i, c)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestStoreBoundsEntriesPerRemote(t *testing.T) {
|
||||||
|
p := New()
|
||||||
|
for i := range maxRefs + 10 {
|
||||||
|
p.store("a", fmt.Sprint(i), "")
|
||||||
|
}
|
||||||
|
p.store("b", "x", shaA)
|
||||||
|
if n := len(p.refs["a"]); n != maxRefs {
|
||||||
|
t.Fatalf("remote a holds %d entries, want %d", n, maxRefs)
|
||||||
|
}
|
||||||
|
if len(p.refs["b"]) != 1 {
|
||||||
|
t.Fatalf("remote b must keep its own budget")
|
||||||
|
}
|
||||||
|
if _, ok := p.refs["a"][fmt.Sprint(maxRefs+9)]; !ok {
|
||||||
|
t.Fatalf("newest entry evicted")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteRejectsBadCommit(t *testing.T) {
|
||||||
|
u := newUpstream(t, true)
|
||||||
|
u.commit.Store("../../etc")
|
||||||
|
w, _ := serve(New(), models.Remote{Name: "g", BaseURL: u.srv.URL}, "o/r/archive/refs/heads/main.tar.gz")
|
||||||
|
if w.Code != http.StatusBadGateway {
|
||||||
|
t.Fatalf("code = %d, want 502", w.Code)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteAllowlist(t *testing.T) {
|
||||||
|
u := newUpstream(t, true)
|
||||||
|
remote := models.Remote{Name: "g", BaseURL: u.srv.URL, Patterns: []string{"^allowed/repo/"}}
|
||||||
|
if w, _ := serve(New(), remote, "other/repo/archive/refs/heads/main.tar.gz"); w.Code != http.StatusForbidden {
|
||||||
|
t.Fatalf("code = %d, want 403", w.Code)
|
||||||
|
}
|
||||||
|
if u.hits.Load() != 0 {
|
||||||
|
t.Fatalf("denied branch must not hit the API")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemoteBlockedRedirectTarget(t *testing.T) {
|
||||||
|
u := newUpstream(t, true)
|
||||||
|
remote := models.Remote{Name: "g", BaseURL: u.srv.URL, Blocklist: []string{"/archive/" + shaA}}
|
||||||
|
w, _ := serve(New(), remote, "o/r/archive/refs/heads/main.tar.gz")
|
||||||
|
if w.Code != http.StatusForbidden || w.Header().Get("Location") != "" {
|
||||||
|
t.Fatalf("code = %d location %q, want 403 without redirect", w.Code, w.Header().Get("Location"))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeRemotePassesThroughAndRejects(t *testing.T) {
|
||||||
|
p := New()
|
||||||
|
remote := models.Remote{Name: "g", BaseURL: "https://github.com"}
|
||||||
|
if _, handled := serve(p, remote, "o/r/archive/refs/tags/v1.tar.gz"); handled {
|
||||||
|
t.Error("tag archives must go through the proxy engine")
|
||||||
|
}
|
||||||
|
if _, handled := serve(p, remote, "o/r/releases/download/v1/a.bin"); handled {
|
||||||
|
t.Error("release assets must go through the proxy engine")
|
||||||
|
}
|
||||||
|
if w, handled := serve(p, remote, "o/r/raw/main/x"); !handled || w.Code != http.StatusNotFound {
|
||||||
|
t.Errorf("unsupported path: handled=%v code=%d", handled, w.Code)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -325,12 +325,12 @@ func (e *Engine) Head(ctx context.Context, remote models.Remote, path string, pr
|
|||||||
return &HeadResult{ContentType: info.ContentType, Size: info.Size, Source: "cache"}, nil
|
return &HeadResult{ContentType: info.ContentType, Size: info.Size, Source: "cache"}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
return e.headUpstream(ctx, remote, path, prov)
|
return e.headUpstream(ctx, remote, path, prov, class)
|
||||||
}
|
}
|
||||||
|
|
||||||
// headUpstream issues an upstream HEAD, load-balancing across the remote's base
|
// headUpstream issues an upstream HEAD, load-balancing across the remote's base
|
||||||
// URLs and failing over to the next mirror on a network error or 5xx.
|
// URLs and failing over to the next mirror on a network error or 5xx.
|
||||||
func (e *Engine) headUpstream(ctx context.Context, remote models.Remote, path string, prov provider.Provider) (*HeadResult, error) {
|
func (e *Engine) headUpstream(ctx context.Context, remote models.Remote, path string, prov provider.Provider, class Classification) (*HeadResult, error) {
|
||||||
order := e.baseURLAttemptOrder(remote)
|
order := e.baseURLAttemptOrder(remote)
|
||||||
if len(order) == 0 {
|
if len(order) == 0 {
|
||||||
return nil, &ProxyError{Status: http.StatusBadGateway, Message: "no upstream base_url configured"}
|
return nil, &ProxyError{Status: http.StatusBadGateway, Message: "no upstream base_url configured"}
|
||||||
@@ -338,7 +338,7 @@ func (e *Engine) headUpstream(ctx context.Context, remote models.Remote, path st
|
|||||||
var lastErr error
|
var lastErr error
|
||||||
for i, url := range order {
|
for i, url := range order {
|
||||||
ctr := e.beginAttempt(remote, url)
|
ctr := e.beginAttempt(remote, url)
|
||||||
result, err := e.headUpstreamOnce(ctx, withBaseURL(remote, url), path, prov)
|
result, err := e.headUpstreamOnce(ctx, withBaseURL(remote, url), path, prov, class)
|
||||||
endAttempt(ctr)
|
endAttempt(ctr)
|
||||||
if err == nil {
|
if err == nil {
|
||||||
return result, nil
|
return result, nil
|
||||||
@@ -353,7 +353,7 @@ func (e *Engine) headUpstream(ctx context.Context, remote models.Remote, path st
|
|||||||
return nil, lastErr
|
return nil, lastErr
|
||||||
}
|
}
|
||||||
|
|
||||||
func (e *Engine) headUpstreamOnce(ctx context.Context, remote models.Remote, path string, prov provider.Provider) (*HeadResult, error) {
|
func (e *Engine) headUpstreamOnce(ctx context.Context, remote models.Remote, path string, prov provider.Provider, class Classification) (*HeadResult, error) {
|
||||||
url := prov.UpstreamURL(remote, path)
|
url := prov.UpstreamURL(remote, path)
|
||||||
|
|
||||||
authHeaders, err := prov.AuthHeaders(ctx, remote)
|
authHeaders, err := prov.AuthHeaders(ctx, remote)
|
||||||
@@ -400,6 +400,11 @@ func (e *Engine) headUpstreamOnce(ctx context.Context, remote models.Remote, pat
|
|||||||
if resp.StatusCode != http.StatusOK {
|
if resp.StatusCode != http.StatusOK {
|
||||||
return nil, &ProxyError{Status: resp.StatusCode, Message: fmt.Sprintf("upstream returned %d", resp.StatusCode)}
|
return nil, &ProxyError{Status: resp.StatusCode, Message: fmt.Sprintf("upstream returned %d", resp.StatusCode)}
|
||||||
}
|
}
|
||||||
|
if class == ClassImmutable {
|
||||||
|
if err := e.checkQuarantine(ctx, remote, path, resp.Header); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
contentType := prov.ContentType(path)
|
contentType := prov.ContentType(path)
|
||||||
if ct := resp.Header.Get("Content-Type"); ct != "" {
|
if ct := resp.Header.Get("Content-Type"); ct != "" {
|
||||||
@@ -527,6 +532,11 @@ func (e *Engine) fetchFromUpstreamOnce(ctx context.Context, remote models.Remote
|
|||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if err := e.checkQuarantine(ctx, remote, path, resp.Header); err != nil {
|
||||||
|
_ = resp.Body.Close()
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
// Immutable blobs are streamed through the content-addressable store
|
// Immutable blobs are streamed through the content-addressable store
|
||||||
// (tempfile -> sha256 -> S3) so arbitrarily large artifacts never sit
|
// (tempfile -> sha256 -> S3) so arbitrarily large artifacts never sit
|
||||||
// fully in memory. Immutable content is never rewritten in the proxy path.
|
// fully in memory. Immutable content is never rewritten in the proxy path.
|
||||||
@@ -663,6 +673,43 @@ func (e *Engine) checkUpstreamOnce(ctx context.Context, remote models.Remote, pa
|
|||||||
return resp.StatusCode == http.StatusNotModified, nil
|
return resp.StatusCode == http.StatusNotModified, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// checkQuarantine refuses an uncached immutable artifact published less than
|
||||||
|
// quarantine_days ago. The publish time is the upstream Last-Modified, capped
|
||||||
|
// at now, else the first time this path was seen.
|
||||||
|
func (e *Engine) checkQuarantine(ctx context.Context, remote models.Remote, path string, upstream http.Header) error {
|
||||||
|
if !remote.QuarantineEnabled {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
if a, err := e.db.GetArtifact(ctx, remote.Name, path); err == nil && a != nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
days := remote.QuarantineDays
|
||||||
|
if days < 1 {
|
||||||
|
days = models.DefaultQuarantineDays
|
||||||
|
}
|
||||||
|
window := time.Duration(days) * 24 * time.Hour
|
||||||
|
now := time.Now()
|
||||||
|
published, err := http.ParseTime(upstream.Get("Last-Modified"))
|
||||||
|
if err != nil {
|
||||||
|
if published, err = e.cache.FirstSeen(ctx, remote.Name, path, window+24*time.Hour); err != nil {
|
||||||
|
slog.Warn("first-seen lookup failed", "remote", remote.Name, "path", path, "error", err)
|
||||||
|
return &ProxyError{Status: http.StatusServiceUnavailable, Message: "quarantine check unavailable", RetryAfter: 30}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if published.After(now) {
|
||||||
|
published = now
|
||||||
|
}
|
||||||
|
if until := published.Add(window); now.Before(until) {
|
||||||
|
return &ProxyError{
|
||||||
|
Status: http.StatusForbidden,
|
||||||
|
Message: fmt.Sprintf("quarantined: published %s, available from %s", published.UTC().Format(time.RFC3339), until.UTC().Format(time.RFC3339)),
|
||||||
|
Published: published.UTC(),
|
||||||
|
Available: until.UTC(),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// etagTTL keeps a mutable path's ETag well past its freshness key so an expired
|
// etagTTL keeps a mutable path's ETag well past its freshness key so an expired
|
||||||
// path revalidates with a conditional HEAD, while idle paths still age out.
|
// path revalidates with a conditional HEAD, while idle paths still age out.
|
||||||
func etagTTL(ttl time.Duration) time.Duration {
|
func etagTTL(ttl time.Duration) time.Duration {
|
||||||
@@ -821,10 +868,21 @@ func fetchBearerToken(ctx context.Context, wwwAuth string, remote models.Remote)
|
|||||||
type ProxyError struct {
|
type ProxyError struct {
|
||||||
Status int
|
Status int
|
||||||
Message string
|
Message string
|
||||||
|
// Published and Available are set only on a quarantine refusal.
|
||||||
|
Published time.Time
|
||||||
|
Available time.Time
|
||||||
|
// RetryAfter, in seconds, is sent as Retry-After when set.
|
||||||
|
RetryAfter int
|
||||||
}
|
}
|
||||||
|
|
||||||
func (e *ProxyError) Error() string { return e.Message }
|
func (e *ProxyError) Error() string { return e.Message }
|
||||||
|
|
||||||
|
// Quarantined reports whether err is a quarantine refusal.
|
||||||
|
func Quarantined(err error) bool {
|
||||||
|
var pe *ProxyError
|
||||||
|
return errors.As(err, &pe) && !pe.Published.IsZero()
|
||||||
|
}
|
||||||
|
|
||||||
type UpstreamError struct {
|
type UpstreamError struct {
|
||||||
Err error
|
Err error
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -227,7 +227,7 @@ func TestHeadUpstreamUsesRemoteTimeout(t *testing.T) {
|
|||||||
r := models.Remote{Name: "slow-head", PackageType: models.PackageGeneric, BaseURL: slow.URL, UpstreamResponseHeaderTimeout: 1}
|
r := models.Remote{Name: "slow-head", PackageType: models.PackageGeneric, BaseURL: slow.URL, UpstreamResponseHeaderTimeout: 1}
|
||||||
|
|
||||||
start := time.Now()
|
start := time.Now()
|
||||||
_, err := (&Engine{}).headUpstreamOnce(context.Background(), r, "blob.bin", prov(t, models.PackageGeneric))
|
_, err := (&Engine{}).headUpstreamOnce(context.Background(), r, "blob.bin", prov(t, models.PackageGeneric), ClassImmutable)
|
||||||
if err == nil || time.Since(start) > 2*time.Second {
|
if err == nil || time.Since(start) > 2*time.Second {
|
||||||
t.Fatalf("HEAD ignored the remote's response header timeout: err=%v after %s", err, time.Since(start))
|
t.Fatalf("HEAD ignored the remote's response header timeout: err=%v after %s", err, time.Since(start))
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,186 @@
|
|||||||
|
package proxy
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/cache"
|
||||||
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
||||||
|
goredis "github.com/redis/go-redis/v9"
|
||||||
|
)
|
||||||
|
|
||||||
|
func must[T any](v T, err error) T {
|
||||||
|
if err != nil {
|
||||||
|
panic(err)
|
||||||
|
}
|
||||||
|
return v
|
||||||
|
}
|
||||||
|
|
||||||
|
func quarantineUpstream(t *testing.T) *httptest.Server {
|
||||||
|
t.Helper()
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
switch r.URL.Path {
|
||||||
|
case "/fresh.tgz":
|
||||||
|
w.Header().Set("Last-Modified", time.Now().Add(-time.Hour).UTC().Format(http.TimeFormat))
|
||||||
|
case "/old.tgz":
|
||||||
|
w.Header().Set("Last-Modified", time.Now().Add(-30*24*time.Hour).UTC().Format(http.TimeFormat))
|
||||||
|
case "/future.tgz":
|
||||||
|
w.Header().Set("Last-Modified", time.Now().Add(30*24*time.Hour).UTC().Format(http.TimeFormat))
|
||||||
|
case "/undated.tgz", "/pkg":
|
||||||
|
default:
|
||||||
|
http.NotFound(w, r)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_, _ = w.Write([]byte("body " + r.URL.Path))
|
||||||
|
}))
|
||||||
|
t.Cleanup(srv.Close)
|
||||||
|
return srv
|
||||||
|
}
|
||||||
|
|
||||||
|
func quarantineRemote(t *testing.T, name string, enabled bool) models.Remote {
|
||||||
|
r := models.Remote{Name: name, PackageType: models.PackageNPM, RepoType: models.RepoTypeRemote,
|
||||||
|
BaseURL: quarantineUpstream(t).URL, QuarantineEnabled: enabled, QuarantineDays: 3}
|
||||||
|
return seed(t, r)
|
||||||
|
}
|
||||||
|
|
||||||
|
func wantQuarantined(t *testing.T, err error) *ProxyError {
|
||||||
|
t.Helper()
|
||||||
|
var pe *ProxyError
|
||||||
|
if !errors.As(err, &pe) || pe.Status != http.StatusForbidden || !Quarantined(err) {
|
||||||
|
t.Fatalf("want quarantine 403, got %v", err)
|
||||||
|
}
|
||||||
|
return pe
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineBlocksFreshArtifact(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
r := quarantineRemote(t, "q-fresh", true)
|
||||||
|
pe := wantQuarantined(t, func() error { _, err := testEngine.Fetch(ctx, r, "fresh.tgz", prov(t, models.PackageNPM)); return err }())
|
||||||
|
if d := time.Until(pe.Available); d < 70*time.Hour || d > 72*time.Hour {
|
||||||
|
t.Errorf("available in %s, want ~71h", d)
|
||||||
|
}
|
||||||
|
if a, _ := testDB.GetArtifact(ctx, r.Name, "fresh.tgz"); a != nil {
|
||||||
|
t.Error("quarantined artifact was cached")
|
||||||
|
}
|
||||||
|
_, err := testEngine.Head(ctx, r, "fresh.tgz", prov(t, models.PackageNPM))
|
||||||
|
_ = wantQuarantined(t, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineServesOldArtifact(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
r := quarantineRemote(t, "q-old", true)
|
||||||
|
res, err := testEngine.Fetch(context.Background(), r, "old.tgz", prov(t, models.PackageNPM))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if got := readAll(t, res); got != "body /old.tgz" {
|
||||||
|
t.Errorf("body = %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineFallsBackToFirstSeen(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
r := quarantineRemote(t, "q-undated", true)
|
||||||
|
p := prov(t, models.PackageNPM)
|
||||||
|
_, err := testEngine.Fetch(ctx, r, "undated.tgz", p)
|
||||||
|
first := wantQuarantined(t, err).Published
|
||||||
|
if time.Since(first) > time.Minute {
|
||||||
|
t.Fatalf("first seen %s, want now", first)
|
||||||
|
}
|
||||||
|
_, err = testEngine.Fetch(ctx, r, "undated.tgz", p)
|
||||||
|
if again := wantQuarantined(t, err).Published; !again.Equal(first) {
|
||||||
|
t.Errorf("first seen moved: %s -> %s", first, again)
|
||||||
|
}
|
||||||
|
|
||||||
|
r.QuarantineDays = 1
|
||||||
|
c := goredis.NewClient(must(goredis.ParseURL(testRedis)))
|
||||||
|
defer func() { _ = c.Close() }()
|
||||||
|
if err := c.Set(ctx, "firstseen:q-undated:undated.tgz", time.Now().Add(-48*time.Hour).Unix(), time.Hour).Err(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := testEngine.Fetch(ctx, r, "undated.tgz", p); err != nil {
|
||||||
|
t.Errorf("seen 48h ago with 1 day quarantine: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineSkipsMutable(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
r := quarantineRemote(t, "q-mutable", true)
|
||||||
|
if _, err := testEngine.Fetch(context.Background(), r, "pkg", prov(t, models.PackageNPM)); err != nil {
|
||||||
|
t.Errorf("mutable index blocked: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineDisabled(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
r := quarantineRemote(t, "q-off", false)
|
||||||
|
if _, err := testEngine.Fetch(context.Background(), r, "fresh.tgz", prov(t, models.PackageNPM)); err != nil {
|
||||||
|
t.Errorf("disabled quarantine blocked: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineKeepsServingCached(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
r := quarantineRemote(t, "q-cached", false)
|
||||||
|
p := prov(t, models.PackageNPM)
|
||||||
|
if _, err := testEngine.Fetch(ctx, r, "fresh.tgz", p); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
r.QuarantineEnabled = true
|
||||||
|
expire(t, r.Name, "fresh.tgz")
|
||||||
|
if _, err := testEngine.Fetch(ctx, r, "fresh.tgz", p); err != nil {
|
||||||
|
t.Errorf("artifact cached before quarantine refused on refetch: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineCapsFutureLastModified(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
r := quarantineRemote(t, "q-future", true)
|
||||||
|
_, err := testEngine.Fetch(context.Background(), r, "future.tgz", prov(t, models.PackageNPM))
|
||||||
|
pe := wantQuarantined(t, err)
|
||||||
|
if d := time.Until(pe.Available); d < 71*time.Hour || d > 72*time.Hour {
|
||||||
|
t.Errorf("available in %s, want ~72h", d)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineRedisErrorUnavailable(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
r := quarantineRemote(t, "q-redis-down", true)
|
||||||
|
r.StaleOnError = true
|
||||||
|
down := must(cache.NewRedis(testRedis))
|
||||||
|
_ = down.Close()
|
||||||
|
eng := NewEngine(testDB, down, testEngine.store)
|
||||||
|
_, err := eng.Fetch(ctx, r, "undated.tgz", prov(t, models.PackageNPM))
|
||||||
|
var pe *ProxyError
|
||||||
|
if !errors.As(err, &pe) || pe.Status != http.StatusServiceUnavailable || pe.RetryAfter == 0 || Quarantined(err) {
|
||||||
|
t.Fatalf("want 503 with Retry-After, got %#v", err)
|
||||||
|
}
|
||||||
|
if a, _ := testDB.GetArtifact(ctx, r.Name, "undated.tgz"); a != nil {
|
||||||
|
t.Error("artifact cached while quarantine check unavailable")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQuarantineStaleOnErrorServesNothingUncached(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
r := quarantineRemote(t, "q-stale", true)
|
||||||
|
r.StaleOnError = true
|
||||||
|
p := prov(t, models.PackageNPM)
|
||||||
|
_, err := testEngine.Fetch(ctx, r, "fresh.tgz", p)
|
||||||
|
_ = wantQuarantined(t, err)
|
||||||
|
r.BaseURL = "http://127.0.0.1:1"
|
||||||
|
if _, err := testEngine.Fetch(ctx, r, "fresh.tgz", p); err == nil {
|
||||||
|
t.Error("stale_on_error served an uncached quarantined path")
|
||||||
|
}
|
||||||
|
if a, _ := testDB.GetArtifact(ctx, r.Name, "fresh.tgz"); a != nil {
|
||||||
|
t.Error("quarantined artifact was cached")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,6 +1,7 @@
|
|||||||
package server
|
package server
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"encoding/base64"
|
||||||
"io"
|
"io"
|
||||||
"net/http"
|
"net/http"
|
||||||
"net/http/httptest"
|
"net/http/httptest"
|
||||||
@@ -78,3 +79,98 @@ func TestServerOIDCWriteAuth(t *testing.T) {
|
|||||||
expect(204, "DELETE", "/api/v2/virtuals/srv-oidc-v", "", good)
|
expect(204, "DELETE", "/api/v2/virtuals/srv-oidc-v", "", good)
|
||||||
expect(204, "DELETE", "/api/v2/remotes/srv-oidc", "", good)
|
expect(204, "DELETE", "/api/v2/remotes/srv-oidc", "", good)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestServerAuthUploads(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
iss := testsupport.NewOIDCIssuer()
|
||||||
|
defer iss.Close()
|
||||||
|
|
||||||
|
cfg := *testSrv.cfg
|
||||||
|
cfg.OIDCIssuer = iss.URL
|
||||||
|
cfg.OIDCAudiences = []string{"artifactapi"}
|
||||||
|
cfg.AuthUploads = true
|
||||||
|
s := *testSrv
|
||||||
|
s.cfg = &cfg
|
||||||
|
ts := httptest.NewServer(s.routes())
|
||||||
|
defer ts.Close()
|
||||||
|
|
||||||
|
good := iss.Token(nil, "artifactapi", "ci", time.Hour)
|
||||||
|
do := func(method, path, body, authz string) int {
|
||||||
|
t.Helper()
|
||||||
|
rq, _ := http.NewRequest(method, ts.URL+path, strings.NewReader(body))
|
||||||
|
rq.Header.Set("Content-Type", "application/json")
|
||||||
|
if authz != "" {
|
||||||
|
rq.Header.Set("Authorization", authz)
|
||||||
|
}
|
||||||
|
resp, err := http.DefaultClient.Do(rq)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("%s %s: %v", method, path, err)
|
||||||
|
}
|
||||||
|
_, _ = io.Copy(io.Discard, resp.Body)
|
||||||
|
_ = resp.Body.Close()
|
||||||
|
return resp.StatusCode
|
||||||
|
}
|
||||||
|
bearer := "Bearer " + good
|
||||||
|
for _, typ := range []string{"generic", "docker", "npm", "gems"} {
|
||||||
|
body := `{"name":"srv-up-` + typ + `","package_type":"` + typ + `","repo_type":"local"}`
|
||||||
|
if got := do("POST", "/api/v2/remotes", body, bearer); got != 201 {
|
||||||
|
t.Fatalf("create %s: status %d", typ, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
writes := []struct{ method, path, body string }{
|
||||||
|
{"PUT", "/api/v2/remotes/srv-up-generic/files/a.bin", "payload"},
|
||||||
|
{"DELETE", "/api/v2/remotes/srv-up-generic/files/a.bin", ""},
|
||||||
|
{"DELETE", "/api/v2/remotes/srv-up-generic/objects/a.bin", ""},
|
||||||
|
{"DELETE", "/api/v2/locals/srv-up-generic/objects/a.bin", ""},
|
||||||
|
{"PUT", "/api/v1/local/srv-up-npm/pkg", "{}"},
|
||||||
|
{"POST", "/api/v1/local/srv-up-gems/api/v1/gems", "x"},
|
||||||
|
{"DELETE", "/api/v1/local/srv-up-gems/api/v1/gems/yank", ""},
|
||||||
|
{"POST", "/v2/srv-up-docker/img/blobs/uploads/", ""},
|
||||||
|
{"PATCH", "/v2/srv-up-docker/img/blobs/uploads/x", ""},
|
||||||
|
{"PUT", "/v2/srv-up-docker/img/manifests/t", "{}"},
|
||||||
|
{"DELETE", "/v2/srv-up-docker/img/manifests/t", ""},
|
||||||
|
}
|
||||||
|
for _, w := range writes {
|
||||||
|
if got := do(w.method, w.path, w.body, ""); got != 401 {
|
||||||
|
t.Errorf("anonymous %s %s: status %d, want 401", w.method, w.path, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if got := do("PUT", "/api/v2/remotes/srv-up-generic/files/a.bin", "payload", bearer); got != 201 {
|
||||||
|
t.Errorf("bearer upload: status %d", got)
|
||||||
|
}
|
||||||
|
if got := do("PUT", "/api/v2/remotes/srv-up-generic/files/b.bin", "payload", basic(good)); got != 201 {
|
||||||
|
t.Errorf("basic upload: status %d", got)
|
||||||
|
}
|
||||||
|
if got := do("POST", "/v2/srv-up-docker/img/blobs/uploads/", "", basic(good)); got != 202 {
|
||||||
|
t.Errorf("basic docker upload: status %d", got)
|
||||||
|
}
|
||||||
|
expectOpen := func(method, path string) {
|
||||||
|
t.Helper()
|
||||||
|
if got := do(method, path, "", ""); got >= 400 {
|
||||||
|
t.Errorf("anonymous %s %s: status %d", method, path, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
expectOpen("GET", "/api/v2/remotes/srv-up-generic/files/a.bin")
|
||||||
|
expectOpen("GET", "/api/v2/remotes/srv-up-generic/objects")
|
||||||
|
expectOpen("GET", "/api/v1/local/srv-up-generic/a.bin")
|
||||||
|
expectOpen("GET", "/v2/token")
|
||||||
|
if got := do("GET", "/v2/", "", ""); got != 401 {
|
||||||
|
t.Errorf("anonymous ping: status %d, want 401 challenge", got)
|
||||||
|
}
|
||||||
|
if got := do("POST", "/api/v2/probe", `{}`, ""); got == 401 {
|
||||||
|
t.Error("probe gated")
|
||||||
|
}
|
||||||
|
|
||||||
|
if got := do("DELETE", "/api/v2/remotes/srv-up-generic/files/a.bin", "", bearer); got >= 400 {
|
||||||
|
t.Errorf("bearer delete: status %d", got)
|
||||||
|
}
|
||||||
|
for _, typ := range []string{"generic", "docker", "npm", "gems"} {
|
||||||
|
do("DELETE", "/api/v2/remotes/srv-up-"+typ, "", bearer)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func basic(tok string) string {
|
||||||
|
return "Basic " + base64.StdEncoding.EncodeToString([]byte("ci:"+tok))
|
||||||
|
}
|
||||||
|
|||||||
@@ -169,8 +169,17 @@ func (s *Server) routes() chi.Router {
|
|||||||
s.virtEngine.NPMLocal = proxyHandler.LocalNPMPackument
|
s.virtEngine.NPMLocal = proxyHandler.LocalNPMPackument
|
||||||
s.virtEngine.GemsLocal = proxyHandler.LocalGemsIndex
|
s.virtEngine.GemsLocal = proxyHandler.LocalGemsIndex
|
||||||
s.virtEngine.AnsibleLocal = proxyHandler.LocalAnsible
|
s.virtEngine.AnsibleLocal = proxyHandler.LocalAnsible
|
||||||
r.Mount("/api/v1", proxyHandler.Routes())
|
writeAuth := auth.NewBearerOIDC(s.cfg.OIDCIssuer, s.cfg.OIDCAudiences)
|
||||||
r.Mount("/v2", proxyHandler.DockerV2Routes())
|
uploadAuth := passthrough
|
||||||
|
dockerV2 := http.Handler(proxyHandler.DockerV2Routes())
|
||||||
|
if s.cfg.AuthUploads {
|
||||||
|
uploadAuth = writeAuth.RequireWrites
|
||||||
|
dockerV2 = writeAuth.RequireRegistryWrites(dockerV2, func(r *http.Request) string {
|
||||||
|
return v1.Scheme(r) + "://" + r.Host + "/v2/token"
|
||||||
|
})
|
||||||
|
}
|
||||||
|
r.Mount("/api/v1", uploadAuth(proxyHandler.Routes()))
|
||||||
|
r.Mount("/v2", dockerV2)
|
||||||
|
|
||||||
remotesHandler := v2.NewRemotesHandler(s.db, s.cache, map[models.PackageType]v2.Primer{
|
remotesHandler := v2.NewRemotesHandler(s.db, s.cache, map[models.PackageType]v2.Primer{
|
||||||
models.PackageGitHubRPM: s.syncer,
|
models.PackageGitHubRPM: s.syncer,
|
||||||
@@ -182,7 +191,6 @@ func (s *Server) routes() chi.Router {
|
|||||||
statsHandler := v2.NewStatsHandler(s.db)
|
statsHandler := v2.NewStatsHandler(s.db)
|
||||||
eventsHandler := v2.NewEventsHandler()
|
eventsHandler := v2.NewEventsHandler()
|
||||||
probeHandler := v2.NewProbeHandler(s.engine, s.db)
|
probeHandler := v2.NewProbeHandler(s.engine, s.db)
|
||||||
writeAuth := auth.NewBearerOIDC(s.cfg.OIDCIssuer, s.cfg.OIDCAudiences)
|
|
||||||
|
|
||||||
r.Route("/api/v2", func(r chi.Router) {
|
r.Route("/api/v2", func(r chi.Router) {
|
||||||
r.Mount("/remotes", writeAuth.RequireWrites(remotesHandler.Routes()))
|
r.Mount("/remotes", writeAuth.RequireWrites(remotesHandler.Routes()))
|
||||||
@@ -192,19 +200,19 @@ func (s *Server) routes() chi.Router {
|
|||||||
r.Mount("/events", eventsHandler.Routes())
|
r.Mount("/events", eventsHandler.Routes())
|
||||||
r.Mount("/probe", probeHandler.Routes())
|
r.Mount("/probe", probeHandler.Routes())
|
||||||
|
|
||||||
r.Route("/remotes/{name}/objects", func(r chi.Router) {
|
r.With(uploadAuth).Route("/remotes/{name}/objects", func(r chi.Router) {
|
||||||
objHandler := v2.NewObjectsHandler(s.db)
|
objHandler := v2.NewObjectsHandler(s.db)
|
||||||
r.Get("/", objHandler.Routes(s.engine).ServeHTTP)
|
r.Get("/", objHandler.Routes(s.engine).ServeHTTP)
|
||||||
r.Delete("/*", objHandler.Routes(s.engine).ServeHTTP)
|
r.Delete("/*", objHandler.Routes(s.engine).ServeHTTP)
|
||||||
})
|
})
|
||||||
|
|
||||||
r.Route("/locals/{name}/objects", func(r chi.Router) {
|
r.With(uploadAuth).Route("/locals/{name}/objects", func(r chi.Router) {
|
||||||
objHandler := v2.NewObjectsHandler(s.db)
|
objHandler := v2.NewObjectsHandler(s.db)
|
||||||
r.Get("/", objHandler.LocalRoutes().ServeHTTP)
|
r.Get("/", objHandler.LocalRoutes().ServeHTTP)
|
||||||
r.Delete("/*", objHandler.LocalRoutes().ServeHTTP)
|
r.Delete("/*", objHandler.LocalRoutes().ServeHTTP)
|
||||||
})
|
})
|
||||||
|
|
||||||
r.Route("/remotes/{name}/files", func(r chi.Router) {
|
r.With(uploadAuth).Route("/remotes/{name}/files", func(r chi.Router) {
|
||||||
r.Put("/*", s.localHandler.Routes().ServeHTTP)
|
r.Put("/*", s.localHandler.Routes().ServeHTTP)
|
||||||
r.Get("/*", s.localHandler.Routes().ServeHTTP)
|
r.Get("/*", s.localHandler.Routes().ServeHTTP)
|
||||||
r.Delete("/*", s.localHandler.Routes().ServeHTTP)
|
r.Delete("/*", s.localHandler.Routes().ServeHTTP)
|
||||||
@@ -214,6 +222,8 @@ func (s *Server) routes() chi.Router {
|
|||||||
return r
|
return r
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func passthrough(h http.Handler) http.Handler { return h }
|
||||||
|
|
||||||
func (s *Server) handleHealth(w http.ResponseWriter, r *http.Request) {
|
func (s *Server) handleHealth(w http.ResponseWriter, r *http.Request) {
|
||||||
w.Header().Set("Content-Type", "application/json")
|
w.Header().Set("Content-Type", "application/json")
|
||||||
w.WriteHeader(http.StatusOK)
|
w.WriteHeader(http.StatusOK)
|
||||||
|
|||||||
@@ -416,6 +416,25 @@ func TestServerRemoteUpdateAndVirtualCRUD(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestServerRemoteServeStaleRoundTrip(t *testing.T) {
|
||||||
|
requireStack(t)
|
||||||
|
if resp, b := req(t, "POST", "/api/v2/remotes", `{"name":"srv-ss","package_type":"rpm","repo_type":"remote","base_url":"https://a.example.com","serve_stale":true}`); resp.StatusCode != 201 {
|
||||||
|
t.Fatalf("create remote: %d %s", resp.StatusCode, b)
|
||||||
|
}
|
||||||
|
defer req(t, "DELETE", "/api/v2/remotes/srv-ss", "")
|
||||||
|
get := func(want string) {
|
||||||
|
t.Helper()
|
||||||
|
if _, b := req(t, "GET", "/api/v2/remotes/srv-ss", ""); !strings.Contains(string(b), want) {
|
||||||
|
t.Errorf("get remote: want %s in %s", want, b)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
get(`"serve_stale":true`)
|
||||||
|
if resp, b := req(t, "PUT", "/api/v2/remotes/srv-ss", `{"package_type":"rpm","base_url":"https://a.example.com"}`); resp.StatusCode != 200 {
|
||||||
|
t.Fatalf("update remote: %d %s", resp.StatusCode, b)
|
||||||
|
}
|
||||||
|
get(`"serve_stale":false`)
|
||||||
|
}
|
||||||
|
|
||||||
func TestServerLocalRemoveAndMissing(t *testing.T) {
|
func TestServerLocalRemoveAndMissing(t *testing.T) {
|
||||||
requireStack(t)
|
requireStack(t)
|
||||||
req(t, "POST", "/api/v2/remotes", `{"name":"srv-rm","package_type":"generic","repo_type":"local"}`)
|
req(t, "POST", "/api/v2/remotes", `{"name":"srv-rm","package_type":"generic","repo_type":"local"}`)
|
||||||
|
|||||||
@@ -58,6 +58,7 @@ func (m *model) viewRemoteDetail() string {
|
|||||||
sb.WriteString(fmt.Sprintf(" Mutable TTL: %ds\n", r.MutableTTL))
|
sb.WriteString(fmt.Sprintf(" Mutable TTL: %ds\n", r.MutableTTL))
|
||||||
sb.WriteString(fmt.Sprintf(" Revalidation: %v\n", r.CheckMutable))
|
sb.WriteString(fmt.Sprintf(" Revalidation: %v\n", r.CheckMutable))
|
||||||
sb.WriteString(fmt.Sprintf(" Stale on Error: %v\n", r.StaleOnError))
|
sb.WriteString(fmt.Sprintf(" Stale on Error: %v\n", r.StaleOnError))
|
||||||
|
fmt.Fprintf(&sb, " Serve Stale: %v\n", r.ServeStale)
|
||||||
|
|
||||||
if len(r.Patterns) > 0 {
|
if len(r.Patterns) > 0 {
|
||||||
sb.WriteString(fmt.Sprintf(" Patterns: %s\n", strings.Join(r.Patterns, ", ")))
|
sb.WriteString(fmt.Sprintf(" Patterns: %s\n", strings.Join(r.Patterns, ", ")))
|
||||||
|
|||||||
@@ -0,0 +1,90 @@
|
|||||||
|
package virtual
|
||||||
|
|
||||||
|
import (
|
||||||
|
"archive/tar"
|
||||||
|
"bytes"
|
||||||
|
"compress/gzip"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// AlpineMember is one member's decompressed APKINDEX for a directory; Index is
|
||||||
|
// nil when the member does not serve that directory.
|
||||||
|
type AlpineMember struct {
|
||||||
|
RemoteName string
|
||||||
|
Index []byte
|
||||||
|
}
|
||||||
|
|
||||||
|
// AlpineRepo is a merged directory: its APKINDEX.tar.gz plus, per
|
||||||
|
// "<name>-<version>.apk" apk will request, the member that owns it.
|
||||||
|
type AlpineRepo struct {
|
||||||
|
Index []byte
|
||||||
|
Owners map[string][]byte
|
||||||
|
}
|
||||||
|
|
||||||
|
func (r *AlpineRepo) index() []byte { return r.Index }
|
||||||
|
func (r *AlpineRepo) files() map[string][]byte { return r.Owners }
|
||||||
|
|
||||||
|
// MergeAlpine merges members' APKINDEX records. Members are in priority order:
|
||||||
|
// the first to carry a (P, V, A) wins. The index is unsigned, like the local
|
||||||
|
// and github_alpine indexes it merges.
|
||||||
|
func MergeAlpine(members []AlpineMember) *AlpineRepo {
|
||||||
|
repo := &AlpineRepo{Owners: map[string][]byte{}}
|
||||||
|
seen := map[string]bool{}
|
||||||
|
var b bytes.Buffer
|
||||||
|
for _, m := range members {
|
||||||
|
for _, rec := range splitStanzas(m.Index) {
|
||||||
|
p, v, a := stanzaField(rec, "P"), stanzaField(rec, "V"), stanzaField(rec, "A")
|
||||||
|
key := p + "\x00" + v + "\x00" + a
|
||||||
|
if p == "" || v == "" || seen[key] {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
seen[key] = true
|
||||||
|
if _, ok := repo.Owners[p+"-"+v+".apk"]; !ok {
|
||||||
|
repo.Owners[p+"-"+v+".apk"] = []byte(m.RemoteName)
|
||||||
|
}
|
||||||
|
b.WriteString(rec)
|
||||||
|
b.WriteString("\n\n")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
var t bytes.Buffer
|
||||||
|
tw := tar.NewWriter(&t)
|
||||||
|
_ = tw.WriteHeader(&tar.Header{Name: "APKINDEX", Mode: 0o644, Size: int64(b.Len()), Typeflag: tar.TypeReg, ModTime: time.Unix(0, 0)})
|
||||||
|
_, _ = tw.Write(b.Bytes())
|
||||||
|
_ = tw.Close()
|
||||||
|
repo.Index = gzipDeterministic(t.Bytes())
|
||||||
|
return repo
|
||||||
|
}
|
||||||
|
|
||||||
|
// apkIndexText extracts the APKINDEX entry from an APKINDEX.tar.gz, skipping a
|
||||||
|
// leading signature stream if present.
|
||||||
|
func apkIndexText(body []byte) ([]byte, error) {
|
||||||
|
zr, err := gzip.NewReader(bytes.NewReader(body))
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
tr := tar.NewReader(zr)
|
||||||
|
for {
|
||||||
|
hdr, err := tr.Next()
|
||||||
|
if errors.Is(err, io.EOF) {
|
||||||
|
return nil, fmt.Errorf("no APKINDEX entry")
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if hdr.Name == "APKINDEX" {
|
||||||
|
return io.ReadAll(tr)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// alpinePath splits a request into its directory and file, or ok is false for
|
||||||
|
// anything but an APKINDEX.tar.gz or .apk.
|
||||||
|
func alpinePath(p string) (dir, file string, ok bool) {
|
||||||
|
i := strings.LastIndex(p, "/")
|
||||||
|
dir, file = p[:i+1], p[i+1:]
|
||||||
|
return dir, file, dir != "" && (file == "APKINDEX.tar.gz" || strings.HasSuffix(file, ".apk"))
|
||||||
|
}
|
||||||
@@ -0,0 +1,140 @@
|
|||||||
|
package virtual
|
||||||
|
|
||||||
|
import (
|
||||||
|
"archive/tar"
|
||||||
|
"bytes"
|
||||||
|
"compress/gzip"
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
||||||
|
)
|
||||||
|
|
||||||
|
func apkRec(p, v, a string) string {
|
||||||
|
return "C:Q1" + p + v + "\nP:" + p + "\nV:" + v + "\nA:" + a + "\nS:10\n"
|
||||||
|
}
|
||||||
|
|
||||||
|
func apkTarGz(t *testing.T, name string, body []byte, closeTar bool) []byte {
|
||||||
|
t.Helper()
|
||||||
|
var tb bytes.Buffer
|
||||||
|
tw := tar.NewWriter(&tb)
|
||||||
|
if err := tw.WriteHeader(&tar.Header{Name: name, Mode: 0o644, Size: int64(len(body)), Typeflag: tar.TypeReg}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
tw.Write(body)
|
||||||
|
if closeTar {
|
||||||
|
tw.Close()
|
||||||
|
} else {
|
||||||
|
tw.Flush()
|
||||||
|
}
|
||||||
|
var gb bytes.Buffer
|
||||||
|
gz := gzip.NewWriter(&gb)
|
||||||
|
gz.Write(tb.Bytes())
|
||||||
|
gz.Close()
|
||||||
|
return gb.Bytes()
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMergeAlpine(t *testing.T) {
|
||||||
|
repo := MergeAlpine([]AlpineMember{
|
||||||
|
{RemoteName: "a", Index: []byte(apkRec("foo", "1.0-r0", "x86_64") + "\n" + apkRec("bar", "1-r0", "noarch") + "\nC:Q1x\nV:9\n")},
|
||||||
|
{RemoteName: "b"},
|
||||||
|
{RemoteName: "c", Index: []byte(apkRec("foo", "1.0-r0", "x86_64") + "\n" + apkRec("foo", "2.0-r0", "x86_64") + "\n" + apkRec("bar", "1-r0", "x86_64"))},
|
||||||
|
})
|
||||||
|
idx, err := apkIndexText(repo.Index)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
recs := splitStanzas(idx)
|
||||||
|
if len(recs) != 4 || strings.Count(string(idx), "P:foo\nV:1.0-r0\n") != 1 {
|
||||||
|
t.Fatalf("want foo 1.0 once, foo 2.0 and bar for both arches, record without P dropped:\n%s", idx)
|
||||||
|
}
|
||||||
|
for file, want := range map[string]string{"foo-1.0-r0.apk": "a", "foo-2.0-r0.apk": "c", "bar-1-r0.apk": "a"} {
|
||||||
|
if got := string(repo.Owners[file]); got != want {
|
||||||
|
t.Errorf("%s owned by %q, want %q", file, got, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if again := MergeAlpine([]AlpineMember{{RemoteName: "a", Index: idx}}); !bytes.Equal(again.Index, MergeAlpine([]AlpineMember{{RemoteName: "a", Index: idx}}).Index) {
|
||||||
|
t.Fatal("merged index must be byte-stable across merges")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestApkIndexTextSkipsSignature(t *testing.T) {
|
||||||
|
signed := append(apkTarGz(t, ".SIGN.RSA.alpine.rsa.pub", []byte("sig"), false), apkTarGz(t, "APKINDEX", []byte(apkRec("foo", "1", "x86_64")), true)...)
|
||||||
|
idx, err := apkIndexText(signed)
|
||||||
|
if err != nil || !strings.Contains(string(idx), "P:foo\n") {
|
||||||
|
t.Fatalf("signed index: %v\n%s", err, idx)
|
||||||
|
}
|
||||||
|
if _, err := apkIndexText(apkTarGz(t, "DESCRIPTION", []byte("x"), true)); err == nil {
|
||||||
|
t.Fatal("index without APKINDEX entry should fail")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func alpineEngine(members map[string]string) *Engine {
|
||||||
|
e := fakeEngine(nil)
|
||||||
|
e.apkMember = func(_ context.Context, name, dir string) (*AlpineMember, error) {
|
||||||
|
idx, ok := members[name]
|
||||||
|
if !ok {
|
||||||
|
return nil, errors.New("upstream down")
|
||||||
|
}
|
||||||
|
if dir != "x86_64/" {
|
||||||
|
return &AlpineMember{RemoteName: name}, nil
|
||||||
|
}
|
||||||
|
return &AlpineMember{RemoteName: name, Index: []byte(idx)}, nil
|
||||||
|
}
|
||||||
|
return e
|
||||||
|
}
|
||||||
|
|
||||||
|
func alpineVirt(members ...string) models.Virtual {
|
||||||
|
return models.Virtual{Name: "v", PackageType: models.PackageAlpine, Members: members}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFetchAlpineIndexAndRedirect(t *testing.T) {
|
||||||
|
e := alpineEngine(map[string]string{"loc": apkRec("foo", "1-r0", "x86_64"), "gh": apkRec("foo", "1-r0", "x86_64") + "\n" + apkRec("tool", "2-r0", "x86_64")})
|
||||||
|
virt := alpineVirt("loc", "gh")
|
||||||
|
|
||||||
|
body, ct, err := e.Fetch(context.Background(), virt, "./x86_64/APKINDEX.tar.gz", "")
|
||||||
|
if err != nil || ct != "application/gzip" {
|
||||||
|
t.Fatalf("fetch index: %v %q", err, ct)
|
||||||
|
}
|
||||||
|
if idx, _ := apkIndexText(body); strings.Count(string(idx), "P:") != 2 {
|
||||||
|
t.Fatalf("merged index:\n%s", idx)
|
||||||
|
}
|
||||||
|
for _, tc := range []struct {
|
||||||
|
path, want string
|
||||||
|
ok bool
|
||||||
|
}{
|
||||||
|
{path: "x86_64/foo-1-r0.apk", ok: true, want: "http://h/api/v1/remote/loc/x86_64/foo-1-r0.apk"},
|
||||||
|
{path: "./x86_64/tool-2-r0.apk", ok: true, want: "http://h/api/v1/remote/gh/x86_64/tool-2-r0.apk"},
|
||||||
|
{path: "x86_64/../x86_64/tool-2-r0.apk", ok: true, want: "http://h/api/v1/remote/gh/x86_64/tool-2-r0.apk"},
|
||||||
|
{path: "x86_64/missing-1-r0.apk"},
|
||||||
|
{path: "aarch64/foo-1-r0.apk"},
|
||||||
|
{path: "x86_64/APKINDEX.tar.gz"},
|
||||||
|
{path: "foo-1-r0.apk"},
|
||||||
|
} {
|
||||||
|
got, ok, err := e.MemberRedirect(context.Background(), virt, tc.path, "", "http://h/")
|
||||||
|
if got != tc.want || ok != tc.ok || err != nil {
|
||||||
|
t.Errorf("%s: got (%q, %v, %v), want (%q, %v)", tc.path, got, ok, err, tc.want, tc.ok)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, p := range []string{"x86_64/missing-1-r0.apk", "x86_64/DESCRIPTION", "APKINDEX.tar.gz"} {
|
||||||
|
if _, _, err := e.Fetch(context.Background(), virt, p, ""); !errors.Is(err, ErrNotFound) {
|
||||||
|
t.Errorf("%s: want not found, got %v", p, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFetchAlpineFailsClosed(t *testing.T) {
|
||||||
|
e := alpineEngine(map[string]string{"a": apkRec("foo", "1-r0", "x86_64")})
|
||||||
|
virt := alpineVirt("a", "down")
|
||||||
|
if _, _, err := e.Fetch(context.Background(), virt, "x86_64/APKINDEX.tar.gz", ""); err == nil || errors.Is(err, ErrNotFound) {
|
||||||
|
t.Fatalf("index with a member down: want upstream error, got %v", err)
|
||||||
|
}
|
||||||
|
if _, ok, err := e.MemberRedirect(context.Background(), virt, "x86_64/foo-1-r0.apk", "", "http://h/"); ok || err != nil {
|
||||||
|
t.Fatalf("redirect with a member down must defer to Fetch: ok %v err %v", ok, err)
|
||||||
|
}
|
||||||
|
if _, _, err := e.Fetch(context.Background(), virt, "x86_64/foo-1-r0.apk", ""); err == nil || errors.Is(err, ErrNotFound) {
|
||||||
|
t.Fatalf("download with a member down: want upstream error, got %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
+242
-27
@@ -19,6 +19,7 @@ import (
|
|||||||
"git.unkin.net/unkin/artifactapi/internal/provider"
|
"git.unkin.net/unkin/artifactapi/internal/provider"
|
||||||
"git.unkin.net/unkin/artifactapi/internal/proxy"
|
"git.unkin.net/unkin/artifactapi/internal/proxy"
|
||||||
"git.unkin.net/unkin/artifactapi/pkg/models"
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
||||||
|
"golang.org/x/sync/errgroup"
|
||||||
"golang.org/x/sync/singleflight"
|
"golang.org/x/sync/singleflight"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -26,9 +27,11 @@ type Engine struct {
|
|||||||
db *database.DB
|
db *database.DB
|
||||||
proxyEngine *proxy.Engine
|
proxyEngine *proxy.Engine
|
||||||
getRemote func(context.Context, string) (*models.Remote, error)
|
getRemote func(context.Context, string) (*models.Remote, error)
|
||||||
rpmMember func(context.Context, string) (*RPMMember, error)
|
rpmMember func(ctx context.Context, name string, parallel bool) (*RPMMember, error)
|
||||||
debMember func(ctx context.Context, name, base string) (*DebMember, error)
|
debMember func(ctx context.Context, name, base string, parallel bool) (*DebMember, error)
|
||||||
|
apkMember func(ctx context.Context, name, dir string) (*AlpineMember, error)
|
||||||
npmMember func(ctx context.Context, name, pkg string) (*NPMMember, error)
|
npmMember func(ctx context.Context, name, pkg string) (*NPMMember, error)
|
||||||
|
memberPath func(ctx context.Context, remote models.Remote, path string) ([]byte, error)
|
||||||
|
|
||||||
// NPMLocal returns a local npm repo's packument with tarball paths relative
|
// NPMLocal returns a local npm repo's packument with tarball paths relative
|
||||||
// to the repo, or ErrNotFound.
|
// to the repo, or ErrNotFound.
|
||||||
@@ -54,8 +57,20 @@ type Engine struct {
|
|||||||
sf singleflight.Group
|
sf singleflight.Group
|
||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
gens map[string]*repoGen
|
gens map[string]*repoGen
|
||||||
|
// stale holds the last good fetch of each serve_stale member, keyed by
|
||||||
|
// merge key and member name.
|
||||||
|
stale map[string]*staleEntry
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type staleEntry struct {
|
||||||
|
m any
|
||||||
|
at time.Time
|
||||||
|
}
|
||||||
|
|
||||||
|
// maxStaleAge bounds how old a serve_stale member copy may be before merges
|
||||||
|
// block on the member again and surface its error.
|
||||||
|
const maxStaleAge = time.Hour
|
||||||
|
|
||||||
// mergedRepo is a merged index document plus the files it references.
|
// mergedRepo is a merged index document plus the files it references.
|
||||||
type mergedRepo interface {
|
type mergedRepo interface {
|
||||||
index() []byte
|
index() []byte
|
||||||
@@ -76,18 +91,21 @@ type repoGen struct {
|
|||||||
|
|
||||||
const rpmMergeTTL = 60 * time.Second
|
const rpmMergeTTL = 60 * time.Second
|
||||||
|
|
||||||
// maxDebSuites bounds the client-chosen suites cached per deb virtual.
|
// maxDebSuites bounds the client-chosen deb suites or alpine directories
|
||||||
|
// cached per virtual.
|
||||||
const maxDebSuites = 32
|
const maxDebSuites = 32
|
||||||
|
|
||||||
func NewEngine(db *database.DB, proxyEngine *proxy.Engine) *Engine {
|
func NewEngine(db *database.DB, proxyEngine *proxy.Engine) *Engine {
|
||||||
e := &Engine{db: db, proxyEngine: proxyEngine, getRemote: db.GetRemote, mergeTTL: rpmMergeTTL}
|
e := &Engine{db: db, proxyEngine: proxyEngine, getRemote: db.GetRemote, mergeTTL: rpmMergeTTL}
|
||||||
e.rpmMember = e.fetchRPMMember
|
e.rpmMember = e.fetchRPMMember
|
||||||
e.debMember = e.fetchDebMember
|
e.debMember = e.fetchDebMember
|
||||||
|
e.apkMember = e.fetchAlpineMember
|
||||||
e.npmMember = e.fetchNPMMember
|
e.npmMember = e.fetchNPMMember
|
||||||
e.gemsMember = e.fetchGemsMember
|
e.gemsMember = e.fetchGemsMember
|
||||||
e.ansibleDoc = e.ansibleMemberDoc
|
e.ansibleDoc = e.ansibleMemberDoc
|
||||||
e.goMember = e.fetchGoMember
|
e.goMember = e.fetchGoMember
|
||||||
e.puppetDoc = e.fetchMemberPath
|
e.puppetDoc = e.fetchMemberPath
|
||||||
|
e.memberPath = e.fetchMemberPath
|
||||||
return e
|
return e
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -97,6 +115,8 @@ func (e *Engine) Fetch(ctx context.Context, virt models.Virtual, path string, pr
|
|||||||
return e.fetchRPM(ctx, virt, path)
|
return e.fetchRPM(ctx, virt, path)
|
||||||
case models.PackageDeb:
|
case models.PackageDeb:
|
||||||
return e.fetchDeb(ctx, virt, path)
|
return e.fetchDeb(ctx, virt, path)
|
||||||
|
case models.PackageAlpine:
|
||||||
|
return e.fetchAlpine(ctx, virt, path)
|
||||||
}
|
}
|
||||||
|
|
||||||
merger, err := GetMerger(virt.PackageType)
|
merger, err := GetMerger(virt.PackageType)
|
||||||
@@ -216,8 +236,8 @@ var (
|
|||||||
)
|
)
|
||||||
|
|
||||||
// MemberRedirect maps an rpm, deb, npm or ansible virtual package path
|
// MemberRedirect maps an rpm, deb, npm or ansible virtual package path
|
||||||
// (<member>/<href>, as written by MergeRPM/MergeDeb/MergeNPM/AnsibleVersion)
|
// (<member>/<href>, as written by MergeRPM/MergeDeb/MergeNPM/AnsibleVersion),
|
||||||
// to the owning member's route. ok is false for any other path; ErrBadPath
|
// or an alpine <dir>/<name>-<version>.apk, to the owning member's route. ok is false for any other path; ErrBadPath
|
||||||
// means the path is absolute or escapes the member.
|
// means the path is absolute or escapes the member.
|
||||||
func (e *Engine) MemberRedirect(ctx context.Context, virt models.Virtual, path, rawQuery, proxyBaseURL string) (string, bool, error) {
|
func (e *Engine) MemberRedirect(ctx context.Context, virt models.Virtual, path, rawQuery, proxyBaseURL string) (string, bool, error) {
|
||||||
switch virt.PackageType {
|
switch virt.PackageType {
|
||||||
@@ -231,6 +251,8 @@ func (e *Engine) MemberRedirect(ctx context.Context, virt models.Virtual, path,
|
|||||||
if strings.HasPrefix(path, "dists/") {
|
if strings.HasPrefix(path, "dists/") {
|
||||||
return "", false, nil
|
return "", false, nil
|
||||||
}
|
}
|
||||||
|
case models.PackageAlpine:
|
||||||
|
return e.alpineRedirect(ctx, virt, path, rawQuery, proxyBaseURL)
|
||||||
case models.PackageNPM, models.PackageAnsible:
|
case models.PackageNPM, models.PackageAnsible:
|
||||||
default:
|
default:
|
||||||
return "", false, nil
|
return "", false, nil
|
||||||
@@ -318,6 +340,7 @@ func (e *Engine) merged(ctx context.Context, key string, merge func(context.Cont
|
|||||||
e.mu.Unlock()
|
e.mu.Unlock()
|
||||||
|
|
||||||
v, err, _ := e.sf.Do(key, func() (any, error) {
|
v, err, _ := e.sf.Do(key, func() (any, error) {
|
||||||
|
e.pruneStale()
|
||||||
repo, err := merge(context.WithoutCancel(ctx))
|
repo, err := merge(context.WithoutCancel(ctx))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
@@ -346,7 +369,9 @@ func (e *Engine) merged(ctx context.Context, key string, merge func(context.Cont
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (e *Engine) mergeRPM(ctx context.Context, virt models.Virtual) (*RPMRepo, error) {
|
func (e *Engine) mergeRPM(ctx context.Context, virt models.Virtual) (*RPMRepo, error) {
|
||||||
members, err := fetchMembers(virt, func(name string) (*RPMMember, error) { return e.rpmMember(ctx, name) })
|
members, err := fetchMembers(virt, func(name string) (*RPMMember, error) {
|
||||||
|
return staleMember(ctx, e, "rpm\x00"+virt.Name, name, func(ctx context.Context) (*RPMMember, error) { return e.rpmMember(ctx, name, virt.ParallelFetch) })
|
||||||
|
})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -395,7 +420,9 @@ func (e *Engine) fetchDeb(ctx context.Context, virt models.Virtual, reqPath stri
|
|||||||
}
|
}
|
||||||
|
|
||||||
repo, err := e.merged(ctx, key, func(ctx context.Context) (mergedRepo, error) {
|
repo, err := e.merged(ctx, key, func(ctx context.Context) (mergedRepo, error) {
|
||||||
members, err := fetchMembers(virt, func(name string) (*DebMember, error) { return e.debMember(ctx, name, base) })
|
members, err := fetchMembers(virt, func(name string) (*DebMember, error) {
|
||||||
|
return staleMember(ctx, e, key, name, func(ctx context.Context) (*DebMember, error) { return e.debMember(ctx, name, base, virt.ParallelFetch) })
|
||||||
|
})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -423,26 +450,160 @@ func debContentType(name string) string {
|
|||||||
|
|
||||||
// fetchDebMember reads a member's Release under base and each binary Packages
|
// fetchDebMember reads a member's Release under base and each binary Packages
|
||||||
// index it lists.
|
// index it lists.
|
||||||
func (e *Engine) fetchDebMember(ctx context.Context, name, base string) (*DebMember, error) {
|
func (e *Engine) fetchDebMember(ctx context.Context, name, base string, parallel bool) (*DebMember, error) {
|
||||||
remote, err := e.getRemote(ctx, name)
|
remote, err := e.getRemote(ctx, name)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, fmt.Errorf("remote %q: %w", name, err)
|
return nil, fmt.Errorf("remote %q: %w", name, err)
|
||||||
}
|
}
|
||||||
rel, err := e.fetchMemberPath(ctx, *remote, base+"Release")
|
rel, err := e.memberPath(ctx, *remote, base+"Release")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
m := &DebMember{RemoteName: name, Release: rel, Packages: map[string][]byte{}}
|
pkgs, err := fetchFiles(ctx, parallel, debIndexFiles(parseDebRelease(rel)), func(ctx context.Context, file string) ([]byte, error) {
|
||||||
for dir, file := range debIndexFiles(parseDebRelease(rel)) {
|
return e.fetchDecompressed(ctx, *remote, base, file)
|
||||||
raw, err := e.fetchMemberPath(ctx, *remote, base+file)
|
})
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return &DebMember{RemoteName: name, Release: rel, Packages: pkgs}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (e *Engine) mergedAlpine(ctx context.Context, virt models.Virtual, dir string) (mergedRepo, error) {
|
||||||
|
key := "alpine\x00" + virt.Name + "\x00" + dir
|
||||||
|
repo, err := e.merged(ctx, key, func(ctx context.Context) (mergedRepo, error) {
|
||||||
|
members, err := fetchMembers(virt, func(name string) (*AlpineMember, error) {
|
||||||
|
return staleMember(ctx, e, key, name, func(ctx context.Context) (*AlpineMember, error) { return e.apkMember(ctx, name, dir) })
|
||||||
|
})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
if m.Packages[dir], err = decompress(file, raw); err != nil {
|
return MergeAlpine(members), nil
|
||||||
return nil, fmt.Errorf("decompress %s: %w", file, err)
|
})
|
||||||
|
if err == nil {
|
||||||
|
e.evictLRU("alpine\x00"+virt.Name+"\x00", maxDebSuites)
|
||||||
|
}
|
||||||
|
return repo, err
|
||||||
|
}
|
||||||
|
|
||||||
|
func (e *Engine) fetchAlpine(ctx context.Context, virt models.Virtual, reqPath string) ([]byte, string, error) {
|
||||||
|
dir, file, ok := alpinePath(strings.TrimPrefix(path.Clean("/"+reqPath), "/"))
|
||||||
|
if !ok {
|
||||||
|
return nil, "", ErrNotFound
|
||||||
|
}
|
||||||
|
repo, err := e.mergedAlpine(ctx, virt, dir)
|
||||||
|
if err != nil {
|
||||||
|
return nil, "", err
|
||||||
|
}
|
||||||
|
if file != "APKINDEX.tar.gz" {
|
||||||
|
return nil, "", ErrNotFound
|
||||||
|
}
|
||||||
|
return repo.index(), "application/gzip", nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// alpineRedirect finds the member whose index lists the requested .apk; apk
|
||||||
|
// builds the download path itself, so the index cannot carry a member prefix.
|
||||||
|
// A failed merge returns ok=false so Fetch re-merges and fails with 502.
|
||||||
|
func (e *Engine) alpineRedirect(ctx context.Context, virt models.Virtual, reqPath, rawQuery, proxyBaseURL string) (string, bool, error) {
|
||||||
|
dir, file, ok := alpinePath(strings.TrimPrefix(path.Clean("/"+reqPath), "/"))
|
||||||
|
if !ok || file == "APKINDEX.tar.gz" {
|
||||||
|
return "", false, nil
|
||||||
|
}
|
||||||
|
owner, ok := e.cachedFile("alpine\x00"+virt.Name+"\x00"+dir, file)
|
||||||
|
if !ok {
|
||||||
|
repo, err := e.mergedAlpine(ctx, virt, dir)
|
||||||
|
if err != nil {
|
||||||
|
return "", false, nil
|
||||||
|
}
|
||||||
|
if owner, ok = repo.files()[file]; !ok {
|
||||||
|
return "", false, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return e.memberLocation(ctx, string(owner), dir+file, rawQuery, proxyBaseURL)
|
||||||
|
}
|
||||||
|
|
||||||
|
// fetchAlpineMember reads a member's APKINDEX under dir; a member without that
|
||||||
|
// directory contributes nothing.
|
||||||
|
func (e *Engine) fetchAlpineMember(ctx context.Context, name, dir string) (*AlpineMember, error) {
|
||||||
|
remote, err := e.getRemote(ctx, name)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("remote %q: %w", name, err)
|
||||||
|
}
|
||||||
|
raw, err := e.fetchMemberPath(ctx, *remote, dir+"APKINDEX.tar.gz")
|
||||||
|
var pe *proxy.ProxyError
|
||||||
|
if errors.Is(err, ErrNotFound) || errors.As(err, &pe) && pe.Status == http.StatusNotFound {
|
||||||
|
return &AlpineMember{RemoteName: name}, nil
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
idx, err := apkIndexText(raw)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("%s/%sAPKINDEX.tar.gz: %w", name, dir, err)
|
||||||
|
}
|
||||||
|
return &AlpineMember{RemoteName: name, Index: idx}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// staleMember fetches member name for the merge under key. A serve_stale member
|
||||||
|
// with a good fetch younger than maxStaleAge returns it at once and refreshes in
|
||||||
|
// the background, one refresh per member at a time; the next merge picks it up.
|
||||||
|
func staleMember[T any](ctx context.Context, e *Engine, key, name string, fetch func(context.Context) (*T, error)) (*T, error) {
|
||||||
|
sk := key + "\x00" + name
|
||||||
|
remote, err := e.getRemote(ctx, name)
|
||||||
|
if err != nil || !remote.ServeStale {
|
||||||
|
e.mu.Lock()
|
||||||
|
delete(e.stale, sk)
|
||||||
|
e.mu.Unlock()
|
||||||
|
return fetch(ctx)
|
||||||
|
}
|
||||||
|
e.mu.Lock()
|
||||||
|
if e.stale == nil {
|
||||||
|
e.stale = map[string]*staleEntry{}
|
||||||
|
}
|
||||||
|
prev := e.stale[sk]
|
||||||
|
// A cold fetch holds a placeholder so eviction or toggle-off during it is seen.
|
||||||
|
token := prev
|
||||||
|
if prev == nil || prev.m == nil {
|
||||||
|
prev, token = nil, &staleEntry{at: time.Now()}
|
||||||
|
e.stale[sk] = token
|
||||||
|
}
|
||||||
|
e.mu.Unlock()
|
||||||
|
refresh := func() (any, error) {
|
||||||
|
m, err := fetch(ctx)
|
||||||
|
e.mu.Lock()
|
||||||
|
// An evicted or replaced entry means this refresh is no longer wanted.
|
||||||
|
if e.stale[sk] == token {
|
||||||
|
if err == nil {
|
||||||
|
e.stale[sk] = &staleEntry{m: m, at: time.Now()}
|
||||||
|
} else if prev == nil {
|
||||||
|
delete(e.stale, sk)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
e.mu.Unlock()
|
||||||
|
return m, err
|
||||||
|
}
|
||||||
|
if prev == nil {
|
||||||
|
m, err := refresh()
|
||||||
|
return m.(*T), err
|
||||||
|
}
|
||||||
|
ch := e.sf.DoChan("stale\x00"+sk, refresh)
|
||||||
|
go func() {
|
||||||
|
if r := <-ch; r.Err != nil {
|
||||||
|
slog.Warn("virtual member background refresh failed", "member", name, "error", r.Err)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
return prev.m.(*T), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// pruneStale drops serve_stale copies past maxStaleAge, including those of
|
||||||
|
// removed members and virtuals.
|
||||||
|
func (e *Engine) pruneStale() {
|
||||||
|
e.mu.Lock()
|
||||||
|
defer e.mu.Unlock()
|
||||||
|
for k, se := range e.stale {
|
||||||
|
if time.Since(se.at) >= maxStaleAge {
|
||||||
|
delete(e.stale, k)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return m, nil
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// evictLRU drops the least recently used merges under prefix beyond keep.
|
// evictLRU drops the least recently used merges under prefix beyond keep.
|
||||||
@@ -458,6 +619,11 @@ func (e *Engine) evictLRU(prefix string, keep int) {
|
|||||||
slices.SortFunc(keys, func(a, b string) int { return e.gens[b].used.Compare(e.gens[a].used) })
|
slices.SortFunc(keys, func(a, b string) int { return e.gens[b].used.Compare(e.gens[a].used) })
|
||||||
for _, k := range keys[min(len(keys), keep):] {
|
for _, k := range keys[min(len(keys), keep):] {
|
||||||
delete(e.gens, k)
|
delete(e.gens, k)
|
||||||
|
for sk := range e.stale {
|
||||||
|
if strings.HasPrefix(sk, k+"\x00") {
|
||||||
|
delete(e.stale, sk)
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -480,12 +646,12 @@ func (e *Engine) cachedFile(key, path string) ([]byte, bool) {
|
|||||||
return nil, false
|
return nil, false
|
||||||
}
|
}
|
||||||
|
|
||||||
func (e *Engine) fetchRPMMember(ctx context.Context, name string) (*RPMMember, error) {
|
func (e *Engine) fetchRPMMember(ctx context.Context, name string, parallel bool) (*RPMMember, error) {
|
||||||
remote, err := e.getRemote(ctx, name)
|
remote, err := e.getRemote(ctx, name)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, fmt.Errorf("remote %q: %w", name, err)
|
return nil, fmt.Errorf("remote %q: %w", name, err)
|
||||||
}
|
}
|
||||||
repomd, err := e.fetchMemberPath(ctx, *remote, "repodata/repomd.xml")
|
repomd, err := e.memberPath(ctx, *remote, "repodata/repomd.xml")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -493,17 +659,66 @@ func (e *Engine) fetchRPMMember(ctx context.Context, name string) (*RPMMember, e
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
m := &RPMMember{RemoteName: name, Bases: remote.UpstreamPool(), Timestamp: ts, Data: map[string][]byte{}}
|
data, err := fetchFiles(ctx, parallel, locs, func(ctx context.Context, href string) ([]byte, error) {
|
||||||
for t, href := range locs {
|
return e.fetchDecompressed(ctx, *remote, "", href)
|
||||||
raw, err := e.fetchMemberPath(ctx, *remote, href)
|
})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
|
||||||
if m.Data[t], err = decompress(href, raw); err != nil {
|
|
||||||
return nil, fmt.Errorf("decompress %s: %w", href, err)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
return m, nil
|
return &RPMMember{RemoteName: name, Bases: remote.UpstreamPool(), Timestamp: ts, Data: data}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (e *Engine) fetchDecompressed(ctx context.Context, remote models.Remote, base, file string) ([]byte, error) {
|
||||||
|
raw, err := e.memberPath(ctx, remote, base+file)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
body, err := decompress(file, raw)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("decompress %s: %w", file, err)
|
||||||
|
}
|
||||||
|
return body, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// maxFileFetches bounds the concurrent index file fetches per member.
|
||||||
|
const maxFileFetches = 4
|
||||||
|
|
||||||
|
// fetchFiles fetches each key's file, one at a time or up to maxFileFetches at
|
||||||
|
// once, failing on the first error and cancelling the rest.
|
||||||
|
func fetchFiles(ctx context.Context, parallel bool, files map[string]string, fetch func(ctx context.Context, file string) ([]byte, error)) (map[string][]byte, error) {
|
||||||
|
out := make(map[string][]byte, len(files))
|
||||||
|
if !parallel {
|
||||||
|
for k, f := range files {
|
||||||
|
body, err := fetch(ctx, f)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
out[k] = body
|
||||||
|
}
|
||||||
|
return out, nil
|
||||||
|
}
|
||||||
|
var mu sync.Mutex
|
||||||
|
g, gctx := errgroup.WithContext(ctx)
|
||||||
|
g.SetLimit(maxFileFetches)
|
||||||
|
for k, f := range files {
|
||||||
|
g.Go(func() error {
|
||||||
|
if err := gctx.Err(); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
body, err := fetch(gctx, f)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
mu.Lock()
|
||||||
|
out[k] = body
|
||||||
|
mu.Unlock()
|
||||||
|
return nil
|
||||||
|
})
|
||||||
|
}
|
||||||
|
if err := g.Wait(); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return out, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// fetchMemberPath reads one path from a member the same way its own route
|
// fetchMemberPath reads one path from a member the same way its own route
|
||||||
|
|||||||
@@ -0,0 +1,330 @@
|
|||||||
|
package virtual
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"sync/atomic"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
||||||
|
)
|
||||||
|
|
||||||
|
func rpmPkgMember(name, ver string) *RPMMember {
|
||||||
|
return &RPMMember{RemoteName: name, Data: map[string][]byte{"primary": primaryXML(primaryPkgXML("foo", ver, "h"+ver, "foo-"+ver+".rpm"))}}
|
||||||
|
}
|
||||||
|
|
||||||
|
// staleEngine re-merges on every request; member "a" is fetched through fetch
|
||||||
|
// and has serve_stale set to stale.
|
||||||
|
func staleEngine(stale bool, fetch func() *RPMMember) (*Engine, *atomic.Int32) {
|
||||||
|
e, calls, _ := staleEngineErr(stale, func() (*RPMMember, error) { return fetch(), nil })
|
||||||
|
return e, calls
|
||||||
|
}
|
||||||
|
|
||||||
|
func staleEngineErr(stale bool, fetch func() (*RPMMember, error)) (*Engine, *atomic.Int32, *atomic.Bool) {
|
||||||
|
var calls atomic.Int32
|
||||||
|
var flag atomic.Bool
|
||||||
|
flag.Store(stale)
|
||||||
|
e := fakeEngine(nil)
|
||||||
|
e.getRemote = func(_ context.Context, name string) (*models.Remote, error) {
|
||||||
|
return &models.Remote{Name: name, RepoType: models.RepoTypeRemote, ServeStale: flag.Load()}, nil
|
||||||
|
}
|
||||||
|
e.rpmMember = func(_ context.Context, name string, _ bool) (*RPMMember, error) {
|
||||||
|
calls.Add(1)
|
||||||
|
return fetch()
|
||||||
|
}
|
||||||
|
return e, &calls, &flag
|
||||||
|
}
|
||||||
|
|
||||||
|
// waitRefresh blocks until the background refresh of sk, if any, has finished.
|
||||||
|
func waitRefresh(e *Engine, sk string) {
|
||||||
|
_, _, _ = e.sf.Do("stale\x00"+sk, func() (any, error) { return nil, nil })
|
||||||
|
}
|
||||||
|
|
||||||
|
const rpmStaleKey = "rpm\x00v\x00a"
|
||||||
|
|
||||||
|
func fetchRepomd(t *testing.T, e *Engine) string {
|
||||||
|
t.Helper()
|
||||||
|
b, _, err := e.Fetch(context.Background(), rpmVirt("a"), "repodata/repomd.xml", "")
|
||||||
|
if err != nil {
|
||||||
|
t.Error(err)
|
||||||
|
}
|
||||||
|
return string(b)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeStaleMemberDoesNotBlockMerge(t *testing.T) {
|
||||||
|
release := make(chan struct{})
|
||||||
|
var slow atomic.Bool
|
||||||
|
e, calls := staleEngine(true, func() *RPMMember {
|
||||||
|
if slow.Load() {
|
||||||
|
<-release
|
||||||
|
return rpmPkgMember("a", "2")
|
||||||
|
}
|
||||||
|
return rpmPkgMember("a", "1")
|
||||||
|
})
|
||||||
|
v1 := fetchRepomd(t, e)
|
||||||
|
slow.Store(true)
|
||||||
|
|
||||||
|
for range 3 {
|
||||||
|
done := make(chan string)
|
||||||
|
go func() { done <- fetchRepomd(t, e) }()
|
||||||
|
select {
|
||||||
|
case got := <-done:
|
||||||
|
if got != v1 {
|
||||||
|
t.Fatal("stale merge should serve the previous member copy")
|
||||||
|
}
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
t.Fatal("merge blocked on a serve_stale member refresh")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if n := calls.Load(); n != 2 {
|
||||||
|
t.Fatalf("member fetched %d times, want 2 (cold + one single-flighted refresh)", n)
|
||||||
|
}
|
||||||
|
|
||||||
|
close(release)
|
||||||
|
deadline := time.Now().Add(time.Second)
|
||||||
|
for fetchRepomd(t, e) == v1 {
|
||||||
|
if time.Now().After(deadline) {
|
||||||
|
t.Fatal("background refresh never reached a merge")
|
||||||
|
}
|
||||||
|
time.Sleep(5 * time.Millisecond)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func assertMergeBlocks(t *testing.T, e *Engine, release chan struct{}) {
|
||||||
|
t.Helper()
|
||||||
|
done := make(chan struct{})
|
||||||
|
go func() { fetchRepomd(t, e); close(done) }()
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
t.Fatal("merge returned before the member fetch finished")
|
||||||
|
case <-time.After(50 * time.Millisecond):
|
||||||
|
}
|
||||||
|
close(release)
|
||||||
|
<-done
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNonServeStaleMemberBlocksMerge(t *testing.T) {
|
||||||
|
release := make(chan struct{})
|
||||||
|
var slow atomic.Bool
|
||||||
|
e, _ := staleEngine(false, func() *RPMMember {
|
||||||
|
if slow.Load() {
|
||||||
|
<-release
|
||||||
|
}
|
||||||
|
return rpmPkgMember("a", "1")
|
||||||
|
})
|
||||||
|
fetchRepomd(t, e)
|
||||||
|
slow.Store(true)
|
||||||
|
assertMergeBlocks(t, e, release)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeStaleColdStartBlocksMerge(t *testing.T) {
|
||||||
|
release := make(chan struct{})
|
||||||
|
e, _ := staleEngine(true, func() *RPMMember {
|
||||||
|
<-release
|
||||||
|
return rpmPkgMember("a", "1")
|
||||||
|
})
|
||||||
|
assertMergeBlocks(t, e, release)
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeStaleRefreshErrorKeepsCopy(t *testing.T) {
|
||||||
|
var down atomic.Bool
|
||||||
|
e, _, _ := staleEngineErr(true, func() (*RPMMember, error) {
|
||||||
|
if down.Load() {
|
||||||
|
return nil, errors.New("upstream down")
|
||||||
|
}
|
||||||
|
return rpmPkgMember("a", "1"), nil
|
||||||
|
})
|
||||||
|
v1 := fetchRepomd(t, e)
|
||||||
|
down.Store(true)
|
||||||
|
for range 3 {
|
||||||
|
if got := fetchRepomd(t, e); got != v1 {
|
||||||
|
t.Fatal("a failed refresh should keep serving the previous copy")
|
||||||
|
}
|
||||||
|
waitRefresh(e, rpmStaleKey)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeStaleMaxAgeFallsBackToFetch(t *testing.T) {
|
||||||
|
var down atomic.Bool
|
||||||
|
e, _, _ := staleEngineErr(true, func() (*RPMMember, error) {
|
||||||
|
if down.Load() {
|
||||||
|
return nil, errors.New("upstream down")
|
||||||
|
}
|
||||||
|
return rpmPkgMember("a", "1"), nil
|
||||||
|
})
|
||||||
|
fetchRepomd(t, e)
|
||||||
|
down.Store(true)
|
||||||
|
e.mu.Lock()
|
||||||
|
e.stale[rpmStaleKey].at = time.Now().Add(-maxStaleAge)
|
||||||
|
e.mu.Unlock()
|
||||||
|
if _, _, err := e.Fetch(context.Background(), rpmVirt("a"), "repodata/repomd.xml", ""); err == nil {
|
||||||
|
t.Fatal("a copy past maxStaleAge should not be served")
|
||||||
|
}
|
||||||
|
if len(e.stale) != 0 {
|
||||||
|
t.Fatal("an expired copy should be dropped")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeStaleToggleOffClearsCopy(t *testing.T) {
|
||||||
|
var down atomic.Bool
|
||||||
|
e, _, flag := staleEngineErr(true, func() (*RPMMember, error) {
|
||||||
|
if down.Load() {
|
||||||
|
return nil, errors.New("upstream down")
|
||||||
|
}
|
||||||
|
return rpmPkgMember("a", "1"), nil
|
||||||
|
})
|
||||||
|
fetchRepomd(t, e)
|
||||||
|
flag.Store(false)
|
||||||
|
fetchRepomd(t, e)
|
||||||
|
if len(e.stale) != 0 {
|
||||||
|
t.Fatal("turning serve_stale off should drop the copy")
|
||||||
|
}
|
||||||
|
flag.Store(true)
|
||||||
|
down.Store(true)
|
||||||
|
if _, _, err := e.Fetch(context.Background(), rpmVirt("a"), "repodata/repomd.xml", ""); err == nil {
|
||||||
|
t.Fatal("re-enabling serve_stale must not resurrect the old copy")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func staleRemote(_ context.Context, name string) (*models.Remote, error) {
|
||||||
|
return &models.Remote{Name: name, RepoType: models.RepoTypeRemote, ServeStale: true}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeStaleDebAndAlpine(t *testing.T) {
|
||||||
|
var down atomic.Bool
|
||||||
|
e := fakeEngine(nil)
|
||||||
|
e.getRemote = staleRemote
|
||||||
|
e.debMember = func(_ context.Context, name, _ string, _ bool) (*DebMember, error) {
|
||||||
|
if down.Load() {
|
||||||
|
return nil, errors.New("upstream down")
|
||||||
|
}
|
||||||
|
return suiteDebMember(name, "1"), nil
|
||||||
|
}
|
||||||
|
e.apkMember = func(_ context.Context, name, _ string) (*AlpineMember, error) {
|
||||||
|
if down.Load() {
|
||||||
|
return nil, errors.New("upstream down")
|
||||||
|
}
|
||||||
|
return &AlpineMember{RemoteName: name, Index: []byte(apkRec("foo", "1-r0", "x86_64"))}, nil
|
||||||
|
}
|
||||||
|
for _, tc := range []struct {
|
||||||
|
virt models.Virtual
|
||||||
|
path string
|
||||||
|
}{
|
||||||
|
{debVirt("a"), "dists/s/Release"},
|
||||||
|
{alpineVirt("a"), "x86_64/APKINDEX.tar.gz"},
|
||||||
|
} {
|
||||||
|
down.Store(false)
|
||||||
|
first, _, err := e.Fetch(context.Background(), tc.virt, tc.path, "")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
down.Store(true)
|
||||||
|
got, _, err := e.Fetch(context.Background(), tc.virt, tc.path, "")
|
||||||
|
if err != nil || string(got) != string(first) {
|
||||||
|
t.Fatalf("%s: want the previous copy while the member is down, got err %v", tc.virt.PackageType, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeStaleEvictionDropsLateRefresh(t *testing.T) {
|
||||||
|
release := make(chan struct{})
|
||||||
|
var slow atomic.Bool
|
||||||
|
e := fakeEngine(nil)
|
||||||
|
e.mergeTTL = time.Minute
|
||||||
|
e.getRemote = staleRemote
|
||||||
|
e.debMember = func(_ context.Context, name, base string, _ bool) (*DebMember, error) {
|
||||||
|
if base == "dists/s0/" && slow.Load() {
|
||||||
|
<-release
|
||||||
|
}
|
||||||
|
return suiteDebMember(name, "1"), nil
|
||||||
|
}
|
||||||
|
fetch := func(suite string) {
|
||||||
|
t.Helper()
|
||||||
|
if _, _, err := e.Fetch(context.Background(), debVirt("a"), "dists/"+suite+"/Release", ""); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
fetch("s0")
|
||||||
|
slow.Store(true)
|
||||||
|
e.mu.Lock()
|
||||||
|
e.gens["deb\x00v\x00dists/s0/"].at = time.Time{}
|
||||||
|
e.mu.Unlock()
|
||||||
|
fetch("s0")
|
||||||
|
for i := range maxDebSuites {
|
||||||
|
time.Sleep(time.Microsecond)
|
||||||
|
fetch(fmt.Sprintf("s%d", i+1))
|
||||||
|
}
|
||||||
|
close(release)
|
||||||
|
sk := "deb\x00v\x00dists/s0/\x00a"
|
||||||
|
waitRefresh(e, sk)
|
||||||
|
e.mu.Lock()
|
||||||
|
defer e.mu.Unlock()
|
||||||
|
if e.gens["deb\x00v\x00dists/s0/"] != nil {
|
||||||
|
t.Fatal("suite s0 should be evicted")
|
||||||
|
}
|
||||||
|
if e.stale[sk] != nil {
|
||||||
|
t.Fatal("a refresh finishing after eviction must not re-insert its copy")
|
||||||
|
}
|
||||||
|
if len(e.stale) != maxDebSuites {
|
||||||
|
t.Fatalf("stale holds %d copies, want %d", len(e.stale), maxDebSuites)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServeStaleEvictionDropsLateColdFetch(t *testing.T) {
|
||||||
|
release := make(chan struct{})
|
||||||
|
var slow atomic.Bool
|
||||||
|
e := fakeEngine(nil)
|
||||||
|
e.mergeTTL = time.Minute
|
||||||
|
e.getRemote = staleRemote
|
||||||
|
e.debMember = func(_ context.Context, name, base string, _ bool) (*DebMember, error) {
|
||||||
|
if base == "dists/s0/" && slow.Load() {
|
||||||
|
<-release
|
||||||
|
}
|
||||||
|
return suiteDebMember(name, "1"), nil
|
||||||
|
}
|
||||||
|
fetch := func(suite string) {
|
||||||
|
if _, _, err := e.Fetch(context.Background(), debVirt("a"), "dists/"+suite+"/Release", ""); err != nil {
|
||||||
|
t.Error(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
sk := "deb\x00v\x00dists/s0/\x00a"
|
||||||
|
fetch("s0")
|
||||||
|
slow.Store(true)
|
||||||
|
e.mu.Lock()
|
||||||
|
e.gens["deb\x00v\x00dists/s0/"].at = time.Time{}
|
||||||
|
delete(e.stale, sk)
|
||||||
|
e.mu.Unlock()
|
||||||
|
done := make(chan struct{})
|
||||||
|
go func() { defer close(done); fetch("s0") }()
|
||||||
|
for {
|
||||||
|
e.mu.Lock()
|
||||||
|
cold := e.stale[sk] != nil
|
||||||
|
e.mu.Unlock()
|
||||||
|
if cold {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
time.Sleep(time.Millisecond)
|
||||||
|
}
|
||||||
|
for i := range maxDebSuites {
|
||||||
|
time.Sleep(time.Microsecond)
|
||||||
|
fetch(fmt.Sprintf("s%d", i+1))
|
||||||
|
}
|
||||||
|
close(release)
|
||||||
|
<-done
|
||||||
|
e.mu.Lock()
|
||||||
|
defer e.mu.Unlock()
|
||||||
|
if e.stale[sk] != nil {
|
||||||
|
t.Fatal("a cold fetch finishing after eviction must not re-insert its copy")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMergePrunesExpiredCopiesOfOtherMembers(t *testing.T) {
|
||||||
|
e, _ := staleEngine(false, func() *RPMMember { return rpmPkgMember("a", "1") })
|
||||||
|
e.stale = map[string]*staleEntry{"rpm\x00gone\x00x": {m: rpmPkgMember("x", "1"), at: time.Now().Add(-maxStaleAge)}}
|
||||||
|
fetchRepomd(t, e)
|
||||||
|
if len(e.stale) != 0 {
|
||||||
|
t.Fatal("any merge should prune expired copies of removed members")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -19,7 +19,7 @@ func fakeEngine(members map[string]*RPMMember) *Engine {
|
|||||||
getRemote: func(_ context.Context, name string) (*models.Remote, error) {
|
getRemote: func(_ context.Context, name string) (*models.Remote, error) {
|
||||||
return &models.Remote{Name: name, RepoType: models.RepoTypeRemote}, nil
|
return &models.Remote{Name: name, RepoType: models.RepoTypeRemote}, nil
|
||||||
},
|
},
|
||||||
rpmMember: func(_ context.Context, name string) (*RPMMember, error) {
|
rpmMember: func(_ context.Context, name string, _ bool) (*RPMMember, error) {
|
||||||
if m := members[name]; m != nil {
|
if m := members[name]; m != nil {
|
||||||
return m, nil
|
return m, nil
|
||||||
}
|
}
|
||||||
@@ -75,7 +75,7 @@ func TestFetchRPMLocalMemberWithoutRepodataIsUpstreamError(t *testing.T) {
|
|||||||
e := fakeEngine(map[string]*RPMMember{
|
e := fakeEngine(map[string]*RPMMember{
|
||||||
"a": {RemoteName: "a", Data: map[string][]byte{"primary": primaryXML(primaryPkgXML("foo", "1", "aaa", "foo.rpm"))}},
|
"a": {RemoteName: "a", Data: map[string][]byte{"primary": primaryXML(primaryPkgXML("foo", "1", "aaa", "foo.rpm"))}},
|
||||||
})
|
})
|
||||||
e.rpmMember = func(_ context.Context, name string) (*RPMMember, error) {
|
e.rpmMember = func(_ context.Context, name string, _ bool) (*RPMMember, error) {
|
||||||
if name == "local" {
|
if name == "local" {
|
||||||
return nil, fmt.Errorf("local/repodata/repomd.xml: %w", ErrNotFound)
|
return nil, fmt.Errorf("local/repodata/repomd.xml: %w", ErrNotFound)
|
||||||
}
|
}
|
||||||
@@ -91,7 +91,7 @@ func TestFetchRPMMergeIsShared(t *testing.T) {
|
|||||||
var calls atomic.Int32
|
var calls atomic.Int32
|
||||||
e := fakeEngine(nil)
|
e := fakeEngine(nil)
|
||||||
e.mergeTTL = time.Minute
|
e.mergeTTL = time.Minute
|
||||||
e.rpmMember = func(_ context.Context, name string) (*RPMMember, error) {
|
e.rpmMember = func(_ context.Context, name string, _ bool) (*RPMMember, error) {
|
||||||
calls.Add(1)
|
calls.Add(1)
|
||||||
time.Sleep(20 * time.Millisecond)
|
time.Sleep(20 * time.Millisecond)
|
||||||
return &RPMMember{RemoteName: name, Data: map[string][]byte{"primary": primaryXML(primaryPkgXML("foo", "1", "aaa", "foo.rpm"))}}, nil
|
return &RPMMember{RemoteName: name, Data: map[string][]byte{"primary": primaryXML(primaryPkgXML("foo", "1", "aaa", "foo.rpm"))}}, nil
|
||||||
@@ -160,7 +160,7 @@ func TestMemberRedirect(t *testing.T) {
|
|||||||
|
|
||||||
func debEngine(members map[string]*DebMember) *Engine {
|
func debEngine(members map[string]*DebMember) *Engine {
|
||||||
e := fakeEngine(nil)
|
e := fakeEngine(nil)
|
||||||
e.debMember = func(_ context.Context, name, base string) (*DebMember, error) {
|
e.debMember = func(_ context.Context, name, base string, _ bool) (*DebMember, error) {
|
||||||
if m := members[name]; m != nil && base == "" {
|
if m := members[name]; m != nil && base == "" {
|
||||||
return m, nil
|
return m, nil
|
||||||
}
|
}
|
||||||
@@ -213,7 +213,7 @@ func TestFetchDebMergeIsSharedPerSuite(t *testing.T) {
|
|||||||
var calls atomic.Int32
|
var calls atomic.Int32
|
||||||
e := fakeEngine(nil)
|
e := fakeEngine(nil)
|
||||||
e.mergeTTL = time.Minute
|
e.mergeTTL = time.Minute
|
||||||
e.debMember = func(_ context.Context, name, base string) (*DebMember, error) {
|
e.debMember = func(_ context.Context, name, base string, _ bool) (*DebMember, error) {
|
||||||
calls.Add(1)
|
calls.Add(1)
|
||||||
m := flatDebMember(name, "", debStanza("foo", "1", "amd64", "pool/foo.deb"))
|
m := flatDebMember(name, "", debStanza("foo", "1", "amd64", "pool/foo.deb"))
|
||||||
return &m, nil
|
return &m, nil
|
||||||
@@ -307,7 +307,9 @@ func suiteDebMember(name, version string) *DebMember {
|
|||||||
func TestFetchDebByHashSurvivesRemerge(t *testing.T) {
|
func TestFetchDebByHashSurvivesRemerge(t *testing.T) {
|
||||||
version := "1"
|
version := "1"
|
||||||
e := fakeEngine(nil)
|
e := fakeEngine(nil)
|
||||||
e.debMember = func(_ context.Context, name, _ string) (*DebMember, error) { return suiteDebMember(name, version), nil }
|
e.debMember = func(_ context.Context, name, _ string, _ bool) (*DebMember, error) {
|
||||||
|
return suiteDebMember(name, version), nil
|
||||||
|
}
|
||||||
virt := debVirt("a")
|
virt := debVirt("a")
|
||||||
fetch := func(p string) []byte {
|
fetch := func(p string) []byte {
|
||||||
body, _, err := e.Fetch(context.Background(), virt, p, "")
|
body, _, err := e.Fetch(context.Background(), virt, p, "")
|
||||||
@@ -340,7 +342,9 @@ func TestFetchDebByHashSurvivesRemerge(t *testing.T) {
|
|||||||
func TestFetchDebBoundsSuitesPerVirtual(t *testing.T) {
|
func TestFetchDebBoundsSuitesPerVirtual(t *testing.T) {
|
||||||
e := fakeEngine(nil)
|
e := fakeEngine(nil)
|
||||||
e.mergeTTL = time.Minute
|
e.mergeTTL = time.Minute
|
||||||
e.debMember = func(_ context.Context, name, _ string) (*DebMember, error) { return suiteDebMember(name, "1"), nil }
|
e.debMember = func(_ context.Context, name, _ string, _ bool) (*DebMember, error) {
|
||||||
|
return suiteDebMember(name, "1"), nil
|
||||||
|
}
|
||||||
other := models.Virtual{Name: "other", PackageType: models.PackageDeb, Members: []string{"a"}}
|
other := models.Virtual{Name: "other", PackageType: models.PackageDeb, Members: []string{"a"}}
|
||||||
if _, _, err := e.Fetch(context.Background(), other, "dists/keep/Release", ""); err != nil {
|
if _, _, err := e.Fetch(context.Background(), other, "dists/keep/Release", ""); err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
@@ -367,3 +371,203 @@ func TestFetchDebBoundsSuitesPerVirtual(t *testing.T) {
|
|||||||
t.Fatal("another virtual's suites must not be evicted")
|
t.Fatal("another virtual's suites must not be evicted")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func fetchFilesInput(n int) map[string]string {
|
||||||
|
files := map[string]string{}
|
||||||
|
for i := range n {
|
||||||
|
files[fmt.Sprintf("k%d", i)] = fmt.Sprintf("f%d", i)
|
||||||
|
}
|
||||||
|
return files
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFetchFilesParallelRunsConcurrently(t *testing.T) {
|
||||||
|
var inFlight, peak atomic.Int32
|
||||||
|
release := make(chan struct{})
|
||||||
|
go func() {
|
||||||
|
for peak.Load() < maxFileFetches {
|
||||||
|
time.Sleep(time.Millisecond)
|
||||||
|
}
|
||||||
|
close(release)
|
||||||
|
}()
|
||||||
|
got, err := fetchFiles(context.Background(), true, fetchFilesInput(6), func(_ context.Context, f string) ([]byte, error) {
|
||||||
|
n := inFlight.Add(1)
|
||||||
|
defer inFlight.Add(-1)
|
||||||
|
for p := peak.Load(); n > p && !peak.CompareAndSwap(p, n); p = peak.Load() {
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-release:
|
||||||
|
case <-time.After(5 * time.Second):
|
||||||
|
return nil, errors.New("fetches never overlapped")
|
||||||
|
}
|
||||||
|
return []byte(f), nil
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if peak.Load() != maxFileFetches {
|
||||||
|
t.Fatalf("peak concurrency %d, want %d", peak.Load(), maxFileFetches)
|
||||||
|
}
|
||||||
|
for k, f := range fetchFilesInput(6) {
|
||||||
|
if string(got[k]) != f {
|
||||||
|
t.Fatalf("%s = %q, want %q", k, got[k], f)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFetchFilesSerialByDefault(t *testing.T) {
|
||||||
|
var inFlight atomic.Int32
|
||||||
|
_, err := fetchFiles(context.Background(), false, fetchFilesInput(4), func(_ context.Context, f string) ([]byte, error) {
|
||||||
|
defer inFlight.Add(-1)
|
||||||
|
if inFlight.Add(1) > 1 {
|
||||||
|
return nil, errors.New("concurrent fetch")
|
||||||
|
}
|
||||||
|
time.Sleep(time.Millisecond)
|
||||||
|
return []byte(f), nil
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFetchFilesErrorFailsMember(t *testing.T) {
|
||||||
|
boom := errors.New("boom")
|
||||||
|
for _, parallel := range []bool{false, true} {
|
||||||
|
got, err := fetchFiles(context.Background(), parallel, fetchFilesInput(5), func(_ context.Context, f string) ([]byte, error) {
|
||||||
|
if f == "f2" {
|
||||||
|
return nil, boom
|
||||||
|
}
|
||||||
|
return []byte(f), nil
|
||||||
|
})
|
||||||
|
if !errors.Is(err, boom) || got != nil {
|
||||||
|
t.Fatalf("parallel=%v: got %v, %v; want boom and no files", parallel, got, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMergeRPMPassesParallelFetchAndKeepsMemberOrder(t *testing.T) {
|
||||||
|
e := fakeEngine(nil)
|
||||||
|
var sawParallel atomic.Bool
|
||||||
|
e.rpmMember = func(_ context.Context, name string, parallel bool) (*RPMMember, error) {
|
||||||
|
sawParallel.Store(parallel)
|
||||||
|
if name == "a" {
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
return &RPMMember{RemoteName: name, Data: map[string][]byte{"primary": primaryXML(primaryPkgXML("foo", "1", name+"sum", name+".rpm"))}}, nil
|
||||||
|
}
|
||||||
|
virt := rpmVirt("a", "b")
|
||||||
|
virt.ParallelFetch = true
|
||||||
|
repo, err := e.mergeRPM(context.Background(), virt)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if !sawParallel.Load() {
|
||||||
|
t.Fatal("parallel_fetch not passed to member fetch")
|
||||||
|
}
|
||||||
|
primary := regexp.MustCompile(`repodata/[0-9a-f]+-primary\.xml\.gz`).FindString(string(repo.Repomd))
|
||||||
|
body := string(gunzip(t, repo.Files[primary]))
|
||||||
|
if a, b := strings.Index(body, "a.rpm"), strings.Index(body, "b.rpm"); a < 0 || b >= 0 && b < a {
|
||||||
|
t.Fatalf("member priority order lost:\n%s", body)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFetchFilesErrorCancelsRest(t *testing.T) {
|
||||||
|
boom := errors.New("boom")
|
||||||
|
var calls atomic.Int32
|
||||||
|
_, err := fetchFiles(context.Background(), true, fetchFilesInput(8), func(ctx context.Context, _ string) ([]byte, error) {
|
||||||
|
if calls.Add(1) == 1 {
|
||||||
|
return nil, boom
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
return nil, ctx.Err()
|
||||||
|
case <-time.After(5 * time.Second):
|
||||||
|
return nil, errors.New("in-flight fetch not cancelled")
|
||||||
|
}
|
||||||
|
})
|
||||||
|
if !errors.Is(err, boom) {
|
||||||
|
t.Fatalf("got %v, want boom", err)
|
||||||
|
}
|
||||||
|
if n := calls.Load(); n > maxFileFetches {
|
||||||
|
t.Fatalf("%d fetches started after the first error, want at most %d", n, maxFileFetches)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// overlapEngine serves fixed member index paths and records the peak number of
|
||||||
|
// index file fetches in flight. Each fetch blocks until want are in flight (or
|
||||||
|
// fails after 5s); with want 1 it also holds briefly so a stray overlap shows.
|
||||||
|
func overlapEngine(index map[string][]byte, want int32, peak *atomic.Int32) *Engine {
|
||||||
|
e := fakeEngine(nil)
|
||||||
|
var inFlight atomic.Int32
|
||||||
|
e.memberPath = func(_ context.Context, _ models.Remote, path string) ([]byte, error) {
|
||||||
|
body, ok := index[path]
|
||||||
|
if !ok {
|
||||||
|
return nil, fmt.Errorf("%s: %w", path, ErrNotFound)
|
||||||
|
}
|
||||||
|
if strings.HasSuffix(path, "Release") || strings.HasSuffix(path, "repomd.xml") {
|
||||||
|
return body, nil
|
||||||
|
}
|
||||||
|
n := inFlight.Add(1)
|
||||||
|
defer inFlight.Add(-1)
|
||||||
|
for p := peak.Load(); n > p && !peak.CompareAndSwap(p, n); p = peak.Load() {
|
||||||
|
}
|
||||||
|
for deadline := time.Now().Add(5 * time.Second); peak.Load() < want; {
|
||||||
|
if time.Now().After(deadline) {
|
||||||
|
return nil, fmt.Errorf("%s: only %d of %d fetches in flight", path, peak.Load(), want)
|
||||||
|
}
|
||||||
|
time.Sleep(time.Millisecond)
|
||||||
|
}
|
||||||
|
if want == 1 {
|
||||||
|
time.Sleep(10 * time.Millisecond)
|
||||||
|
}
|
||||||
|
return body, nil
|
||||||
|
}
|
||||||
|
return e
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFetchRPMMemberHonoursParallelFetch(t *testing.T) {
|
||||||
|
index := map[string][]byte{
|
||||||
|
"repodata/repomd.xml": []byte(`<repomd>` +
|
||||||
|
`<data type="primary"><location href="repodata/p.xml"/></data>` +
|
||||||
|
`<data type="filelists"><location href="repodata/f.xml"/></data>` +
|
||||||
|
`<data type="other"><location href="repodata/o.xml"/></data></repomd>`),
|
||||||
|
"repodata/p.xml": []byte("P"), "repodata/f.xml": []byte("F"), "repodata/o.xml": []byte("O"),
|
||||||
|
}
|
||||||
|
for parallel, want := range map[bool]int32{false: 1, true: 3} {
|
||||||
|
var peak atomic.Int32
|
||||||
|
m, err := overlapEngine(index, want, &peak).fetchRPMMember(context.Background(), "a", parallel)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if peak.Load() != want {
|
||||||
|
t.Errorf("parallel=%v: peak concurrency %d, want %d", parallel, peak.Load(), want)
|
||||||
|
}
|
||||||
|
if string(m.Data["primary"]) != "P" || string(m.Data["filelists"]) != "F" || string(m.Data["other"]) != "O" {
|
||||||
|
t.Errorf("parallel=%v: data %q", parallel, m.Data)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFetchDebMemberHonoursParallelFetch(t *testing.T) {
|
||||||
|
index := map[string][]byte{
|
||||||
|
"dists/s/Release": []byte("Suite: s\nSHA256:\n" +
|
||||||
|
" aa 1 main/binary-amd64/Packages\n" +
|
||||||
|
" bb 1 contrib/binary-amd64/Packages\n" +
|
||||||
|
" cc 1 non-free/binary-amd64/Packages\n"),
|
||||||
|
"dists/s/main/binary-amd64/Packages": []byte("M"),
|
||||||
|
"dists/s/contrib/binary-amd64/Packages": []byte("C"),
|
||||||
|
"dists/s/non-free/binary-amd64/Packages": []byte("N"),
|
||||||
|
}
|
||||||
|
for parallel, want := range map[bool]int32{false: 1, true: 3} {
|
||||||
|
var peak atomic.Int32
|
||||||
|
m, err := overlapEngine(index, want, &peak).fetchDebMember(context.Background(), "a", "dists/s/", parallel)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if peak.Load() != want {
|
||||||
|
t.Errorf("parallel=%v: peak concurrency %d, want %d", parallel, peak.Load(), want)
|
||||||
|
}
|
||||||
|
if string(m.Packages["main/binary-amd64/"]) != "M" || string(m.Packages["non-free/binary-amd64/"]) != "N" {
|
||||||
|
t.Errorf("parallel=%v: packages %q", parallel, m.Packages)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -194,10 +194,18 @@ func (e *Engine) goList(ctx context.Context, virt models.Virtual, escMod string)
|
|||||||
return nil, ErrNotFound
|
return nil, ErrNotFound
|
||||||
}
|
}
|
||||||
|
|
||||||
// goProbe returns the first member, in member order, that serves path.
|
// goProbe returns the first member, in member order, that serves path, else
|
||||||
|
// the first member quarantining it so the client sees that refusal.
|
||||||
func (e *Engine) goProbe(ctx context.Context, virt models.Virtual, path string) (string, error) {
|
func (e *Engine) goProbe(ctx context.Context, virt models.Virtual, path string) (string, error) {
|
||||||
|
held := ""
|
||||||
for _, name := range virt.Members {
|
for _, name := range virt.Members {
|
||||||
m, err := e.goMember(ctx, name, path)
|
m, err := e.goMember(ctx, name, path)
|
||||||
|
if proxy.Quarantined(err) {
|
||||||
|
if held == "" {
|
||||||
|
held = name
|
||||||
|
}
|
||||||
|
continue
|
||||||
|
}
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return "", fmt.Errorf("virtual %q: member %q: %v", virt.Name, name, err)
|
return "", fmt.Errorf("virtual %q: member %q: %v", virt.Name, name, err)
|
||||||
}
|
}
|
||||||
@@ -205,6 +213,9 @@ func (e *Engine) goProbe(ctx context.Context, virt models.Virtual, path string)
|
|||||||
return name, nil
|
return name, nil
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
if held != "" {
|
||||||
|
return held, nil
|
||||||
|
}
|
||||||
return "", ErrNotFound
|
return "", ErrNotFound
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -3,11 +3,15 @@ package virtual
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"errors"
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"net/http"
|
||||||
|
"strings"
|
||||||
"sync"
|
"sync"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"git.unkin.net/unkin/artifactapi/internal/database"
|
"git.unkin.net/unkin/artifactapi/internal/database"
|
||||||
|
"git.unkin.net/unkin/artifactapi/internal/proxy"
|
||||||
"git.unkin.net/unkin/artifactapi/internal/testsupport"
|
"git.unkin.net/unkin/artifactapi/internal/testsupport"
|
||||||
"git.unkin.net/unkin/artifactapi/pkg/models"
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
||||||
)
|
)
|
||||||
@@ -181,3 +185,32 @@ func TestGoProxyLocalMemberNotFound(t *testing.T) {
|
|||||||
t.Fatalf("module only absent from a local member must be not-found, got %v", err)
|
t.Fatalf("module only absent from a local member must be not-found, got %v", err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestGoProbeFallsThroughQuarantine(t *testing.T) {
|
||||||
|
quarantined := &proxy.ProxyError{Status: http.StatusForbidden, Message: "quarantined", Published: time.Now()}
|
||||||
|
served := map[string]bool{}
|
||||||
|
e := &Engine{
|
||||||
|
mergeTTL: time.Minute,
|
||||||
|
getRemote: func(_ context.Context, name string) (*models.Remote, error) {
|
||||||
|
return &models.Remote{Name: name, RepoType: models.RepoTypeRemote}, nil
|
||||||
|
},
|
||||||
|
goMember: func(_ context.Context, name, path string) (*GoMember, error) {
|
||||||
|
if name == "internal" && strings.HasSuffix(path, ".info") {
|
||||||
|
return nil, fmt.Errorf("fetch: %w", quarantined)
|
||||||
|
}
|
||||||
|
if served[name] {
|
||||||
|
return &GoMember{RemoteName: name, Body: []byte("{}")}, nil
|
||||||
|
}
|
||||||
|
return &GoMember{RemoteName: name}, nil
|
||||||
|
},
|
||||||
|
}
|
||||||
|
zip := "example.com/mod/@v/v0.0.0-20260101-abcdef.zip"
|
||||||
|
served["goproxy"] = true
|
||||||
|
if _, loc, err := e.GoProxy(context.Background(), goVirt(), zip, ""); err != nil || loc != "/api/v1/remote/goproxy/"+zip {
|
||||||
|
t.Errorf("next member serving: %q %v", loc, err)
|
||||||
|
}
|
||||||
|
served["goproxy"] = false
|
||||||
|
if _, loc, err := e.GoProxy(context.Background(), goVirt(), zip, ""); err != nil || loc != "/api/v1/remote/internal/"+zip {
|
||||||
|
t.Errorf("only quarantined member: %q %v, want redirect to its refusal", loc, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -0,0 +1 @@
|
|||||||
|
UPDATE remotes SET quarantine_days = 3 WHERE quarantine_days IS NULL OR quarantine_days <= 0;
|
||||||
@@ -0,0 +1 @@
|
|||||||
|
ALTER TABLE virtuals ADD COLUMN IF NOT EXISTS parallel_fetch BOOLEAN NOT NULL DEFAULT FALSE;
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
-- serve_stale lets a virtual merge a member's previous index while that member
|
||||||
|
-- refreshes in the background.
|
||||||
|
ALTER TABLE remotes ADD COLUMN IF NOT EXISTS serve_stale BOOLEAN NOT NULL DEFAULT FALSE;
|
||||||
@@ -0,0 +1,5 @@
|
|||||||
|
package models
|
||||||
|
|
||||||
|
const PackageVCS PackageType = "vcs"
|
||||||
|
|
||||||
|
func init() { registerPackageType(PackageVCS) }
|
||||||
@@ -73,6 +73,9 @@ type Remote struct {
|
|||||||
QuarantineDays int `json:"quarantine_days,omitempty"`
|
QuarantineDays int `json:"quarantine_days,omitempty"`
|
||||||
|
|
||||||
StaleOnError bool `json:"stale_on_error"`
|
StaleOnError bool `json:"stale_on_error"`
|
||||||
|
// ServeStale lets an rpm/deb/alpine virtual merge this member's previous
|
||||||
|
// index while it refreshes in the background.
|
||||||
|
ServeStale bool `json:"serve_stale"`
|
||||||
|
|
||||||
ReleasesRemote string `json:"releases_remote,omitempty"`
|
ReleasesRemote string `json:"releases_remote,omitempty"`
|
||||||
ManagedBy string `json:"managed_by,omitempty"`
|
ManagedBy string `json:"managed_by,omitempty"`
|
||||||
@@ -149,6 +152,17 @@ func (r *Remote) ValidateMirrorStrategy() error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// DefaultQuarantineDays matches the remotes.quarantine_days column default.
|
||||||
|
const DefaultQuarantineDays = 3
|
||||||
|
|
||||||
|
// ValidateQuarantine rejects an enabled quarantine with no window.
|
||||||
|
func (r *Remote) ValidateQuarantine() error {
|
||||||
|
if r.QuarantineEnabled && r.QuarantineDays < 1 {
|
||||||
|
return fmt.Errorf("quarantine_days must be at least 1 when quarantine_enabled is set")
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// ValidatePatterns ensures every configured regex compiles. Storing an
|
// ValidatePatterns ensures every configured regex compiles. Storing an
|
||||||
// invalid pattern would otherwise be silently dropped at match time, which
|
// invalid pattern would otherwise be silently dropped at match time, which
|
||||||
// for the blocklist is a fail-open: a mistyped deny rule becomes a no-op.
|
// for the blocklist is a fail-open: a mistyped deny rule becomes a no-op.
|
||||||
|
|||||||
@@ -3,11 +3,12 @@ package models
|
|||||||
import "time"
|
import "time"
|
||||||
|
|
||||||
type Virtual struct {
|
type Virtual struct {
|
||||||
Name string `json:"name"`
|
Name string `json:"name"`
|
||||||
PackageType PackageType `json:"package_type"`
|
PackageType PackageType `json:"package_type"`
|
||||||
Description string `json:"description,omitempty"`
|
Description string `json:"description,omitempty"`
|
||||||
Members []string `json:"members"`
|
Members []string `json:"members"`
|
||||||
ManagedBy string `json:"managed_by,omitempty"`
|
ManagedBy string `json:"managed_by,omitempty"`
|
||||||
CreatedAt time.Time `json:"created_at"`
|
ParallelFetch bool `json:"parallel_fetch"`
|
||||||
UpdatedAt time.Time `json:"updated_at"`
|
CreatedAt time.Time `json:"created_at"`
|
||||||
|
UpdatedAt time.Time `json:"updated_at"`
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -17,6 +17,7 @@ export interface Remote {
|
|||||||
quarantine_enabled: boolean;
|
quarantine_enabled: boolean;
|
||||||
quarantine_days: number;
|
quarantine_days: number;
|
||||||
stale_on_error: boolean;
|
stale_on_error: boolean;
|
||||||
|
serve_stale: boolean;
|
||||||
releases_remote: string;
|
releases_remote: string;
|
||||||
managed_by: string;
|
managed_by: string;
|
||||||
created_at: string;
|
created_at: string;
|
||||||
|
|||||||
@@ -0,0 +1,26 @@
|
|||||||
|
import type { PackageTypeUI } from '../types';
|
||||||
|
|
||||||
|
const def: PackageTypeUI = {
|
||||||
|
color: 'default',
|
||||||
|
snippets: ({ proxy }) => {
|
||||||
|
return [
|
||||||
|
{
|
||||||
|
title: 'Download a tag archive',
|
||||||
|
language: 'bash',
|
||||||
|
code: `curl -fsSLO ${proxy}/<owner>/<repo>/archive/refs/tags/<tag>.tar.gz`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
title: 'Download a branch archive (redirects to its current commit)',
|
||||||
|
language: 'bash',
|
||||||
|
code: `curl -fsSL -o src.tar.gz ${proxy}/<owner>/<repo>/archive/refs/heads/<branch>.tar.gz`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
title: 'Download a release asset',
|
||||||
|
language: 'bash',
|
||||||
|
code: `curl -fsSLO ${proxy}/<owner>/<repo>/releases/download/<tag>/<asset>`,
|
||||||
|
},
|
||||||
|
];
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
export default def;
|
||||||
@@ -50,6 +50,8 @@ export function RemoteDetail() {
|
|||||||
<dd>{remote.check_mutable ? 'enabled' : 'disabled'}</dd>
|
<dd>{remote.check_mutable ? 'enabled' : 'disabled'}</dd>
|
||||||
<dt>Stale on Error</dt>
|
<dt>Stale on Error</dt>
|
||||||
<dd>{remote.stale_on_error ? 'enabled' : 'disabled'}</dd>
|
<dd>{remote.stale_on_error ? 'enabled' : 'disabled'}</dd>
|
||||||
|
<dt>Serve Stale</dt>
|
||||||
|
<dd>{remote.serve_stale ? 'enabled' : 'disabled'}</dd>
|
||||||
{remote.releases_remote && (
|
{remote.releases_remote && (
|
||||||
<>
|
<>
|
||||||
<dt>Releases Remote</dt>
|
<dt>Releases Remote</dt>
|
||||||
|
|||||||
Reference in New Issue
Block a user