unkin/artifactapi
2
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

fix: strip base URL path prefix from helm chart download URLs #64

Merged
benvin merged 1 commits from benvin/fix-helm-url-path-dedup into master 2026-06-27 08:02:52 +10:00
Conversation 0 Commits 1 Files Changed 1
+14 -1
unkinben commented 2026-06-27 07:57:03 +10:00
Owner
Copy Link
Copy Source

When a helm repo base URL includes a path component (e.g. `stakater.github.io/stakater-charts`), the merger was extracting the full URL path (`stakater-charts/reloader-2.2.8.tgz`) and the proxy then constructed `base_url/stakater-charts/reloader-2.2.8.tgz` = double path = 404.

Fix: `extractPathRelativeToBase()` strips the shared base path prefix so only the filename portion is used as the proxy path.

When a helm repo base URL includes a path component (e.g. \`stakater.github.io/stakater-charts\`), the merger was extracting the full URL path (\`stakater-charts/reloader-2.2.8.tgz\`) and the proxy then constructed \`base_url/stakater-charts/reloader-2.2.8.tgz\` = double path = 404. Fix: \`extractPathRelativeToBase()\` strips the shared base path prefix so only the filename portion is used as the proxy path.
unkinben added 1 commit 2026-06-27 07:57:03 +10:00
fix: strip base URL path prefix from helm chart download URLs
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
cca640958d 
When a helm repo's base URL includes a path (e.g. stakater.github.io/
stakater-charts), the merger extracted the full path from download URLs
causing duplication: /stakater-charts/stakater-charts/reloader.tgz.

Now strips the base URL's path prefix from same-host download URLs so
the proxy constructs the correct upstream URL.
benvin merged commit 30b7cef026 into master 2026-06-27 08:02:52 +10:00
benvin deleted branch benvin/fix-helm-url-path-dedup 2026-06-27 08:02:52 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#64
Delete Branch "benvin/fix-helm-url-path-dedup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?