unkin/artifactapi
2
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

fix: isNetworkError should use errors.As, not a bare type assertion #68

New Issue
Closed
opened 2026-07-02 00:20:16 +10:00 by unkinben · 0 comments
unkinben commented 2026-07-02 00:20:16 +10:00
Owner
Copy Link
Copy Source

internal/proxy/engine.go:433 type-asserts err.(*UpstreamError) directly. If the error is ever wrapped, stale-on-error handling silently breaks. Use errors.As.

`internal/proxy/engine.go:433` type-asserts `err.(*UpstreamError)` directly. If the error is ever wrapped, stale-on-error handling silently breaks. Use `errors.As`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#68
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?