unkin/artifactapi
2
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

fix: isNetworkError should use errors.As, not a bare type assertion #84

Merged
benvin merged 1 commits from benvin/isnetworkerror-errors-as into master 2026-07-02 20:18:24 +10:00
Conversation 0 Commits 1 Files Changed 1
+3 -4
unkinben commented 2026-07-02 00:27:45 +10:00
Owner
Copy Link
Copy Source

Fixes #68

Why

isNetworkError type-asserted err.(*UpstreamError) directly. If the error is ever wrapped, stale-on-error handling silently stops triggering.

Changes

  • Use errors.As to detect *UpstreamError through wrapping.

Validation

  • make e2e passes.
Fixes #68 ## Why `isNetworkError` type-asserted `err.(*UpstreamError)` directly. If the error is ever wrapped, stale-on-error handling silently stops triggering. ## Changes - Use `errors.As` to detect `*UpstreamError` through wrapping. ## Validation - `make e2e` passes.
unkinben added 1 commit 2026-07-02 00:27:45 +10:00
fix: detect UpstreamError with errors.As in isNetworkError
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
b125630a86 
The stale-on-error path used a bare type assertion, which fails if the
UpstreamError is ever wrapped. Use errors.As so wrapping is handled.

Refs #68
benvin merged commit 0a89b2005c into master 2026-07-02 20:18:24 +10:00
benvin deleted branch benvin/isnetworkerror-errors-as 2026-07-02 20:18:24 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#84
Delete Branch "benvin/isnetworkerror-errors-as"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?