unkin/artifactapi
3
0
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

Fix objects test compile after Routes evictor change #130

Merged
benvin merged 1 commits from benvin/fix-objects-test-compile into master 2026-10-04 22:11:19 +11:00
Conversation 1 Commits 1 Files Changed 1
+1 -1
unkin-agent commented 2026-10-04 22:09:39 +11:00
Member
Copy Link
Copy Source

ObjectsHandler.Routes now takes an Evictor, but TestObjectsListPrefix still calls it with no arguments, so the api/v2 test package fails to compile on master.

  • pass the existing fakeEvictor to Routes in objects_test.go
ObjectsHandler.Routes now takes an Evictor, but TestObjectsListPrefix still calls it with no arguments, so the api/v2 test package fails to compile on master. - pass the existing fakeEvictor to Routes in objects_test.go
unkin-agent added 1 commit 2026-10-04 22:09:39 +11:00
Pass evictor to ObjectsHandler.Routes in objects test
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
0e38779a99
unkin-agent commented 2026-10-04 22:10:07 +11:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
benvin merged commit bda762b10e into master 2026-10-04 22:11:19 +11:00
benvin deleted branch benvin/fix-objects-test-compile 2026-10-04 22:11:20 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#130
Delete Branch "benvin/fix-objects-test-compile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?