unkin/artifactapi
3
0
Fork 0
Code Issues 5 Pull Requests 8 Actions Packages Projects Releases 1 Wiki Activity

Add ansible virtual repositories #158

Open
unkin-agent wants to merge 4 commits from benvin/virtual-ansible into benvin/local-ansible
pull from: benvin/virtual-ansible
merge into: unkin:benvin/local-ansible
Conversation 2 Commits 4 Files Changed 11
+622 -6
unkin-agent commented 2026-10-18 03:45:40 +11:00
Member
Copy Link
Copy Source

Clients need one Galaxy server to install both internal collections and galaxy.ansible.com ones; ansible has no virtual type.

  • merge member collection version lists in member order, the earlier member winning a duplicate version, cached with the shared virtual merge cache
  • paginate limit/offset over the merged list, following remote member pages
  • serve version detail from the owning member with href and download_url via the virtual; downloads 302 to the member through the member-redirect validation
  • fail closed with 502 on a member error or a member versions list shorter than its count
  • add docs/ansible/virtual.md and an e2e-docker case driving real ansible-galaxy

requires unkin/artifactapi#157

Clients need one Galaxy server to install both internal collections and galaxy.ansible.com ones; ansible has no virtual type. - merge member collection version lists in member order, the earlier member winning a duplicate version, cached with the shared virtual merge cache - paginate limit/offset over the merged list, following remote member pages - serve version detail from the owning member with href and download_url via the virtual; downloads 302 to the member through the member-redirect validation - fail closed with 502 on a member error or a member versions list shorter than its count - add docs/ansible/virtual.md and an e2e-docker case driving real ansible-galaxy requires unkin/artifactapi#157
unkin-agent added 1 commit 2026-10-18 03:45:40 +11:00
Add ansible virtual repositories
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
4b202b1852
unkin-agent commented 2026-10-18 03:51:50 +11:00
Author
Member
Copy Link
Copy Source
  • nit: internal/virtual/ansible_merger.go:163 — a remote page with empty data while len(m.Refs) < meta.count returns the partial list as complete, contradicting fail-closed → return an error in that case.
  • nit: internal/virtual/ansible_merger.go:19 — cache is capped by collection count (1024 per virtual, cur+prev each, plus body duplicating Refs), not size; 10k-version collections make that large → drop the redundant body (e.g. index from a version-count/hash) or cap by total refs.
- nit: internal/virtual/ansible_merger.go:163 — a remote page with empty `data` while `len(m.Refs) < meta.count` returns the partial list as complete, contradicting fail-closed → return an error in that case. - nit: internal/virtual/ansible_merger.go:19 — cache is capped by collection count (1024 per virtual, cur+prev each, plus `body` duplicating `Refs`), not size; 10k-version collections make that large → drop the redundant `body` (e.g. index from a version-count/hash) or cap by total refs.
unkin-agent added 2 commits 2026-10-18 04:02:17 +11:00
Merge remote-tracking branch 'origin/benvin/local-ansible' into benvin/virtual-ansible d6acf7a7e9
Fail virtual ansible merges on a short member versions list
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
c1a5feb64e
unkin-agent added 1 commit 2026-10-18 04:04:43 +11:00
Expect root-relative pagination links from ansible virtuals
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
41008cd8f6
unkin-agent commented 2026-10-18 04:12:23 +11:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
Some checks are pending
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin benvin/virtual-ansible:benvin/virtual-ansible
git checkout benvin/virtual-ansible
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#158
Delete Branch "benvin/virtual-ansible"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?