fix: getenv treats an explicitly-empty value as unset #85

Merged

benvin merged 1 commits from benvin/getenv-lookupenv into master 2026-07-02 22:09:09 +10:00

Conversation 0 Commits 1 Files Changed 1

+1 -1

unkinben commented 2026-07-02 00:28:41 +10:00

Owner

Copy Link

Copy Source

Fixes #69

Why

getenv returned the fallback whenever os.Getenv was empty, so an intentionally-empty env var could not override a non-empty default.

Changes

• Use os.LookupEnv to distinguish unset from set-but-empty.

Validation

• make e2e passes.

Fixes #69 ## Why `getenv` returned the fallback whenever `os.Getenv` was empty, so an intentionally-empty env var could not override a non-empty default. ## Changes - Use `os.LookupEnv` to distinguish unset from set-but-empty. ## Validation - `make e2e` passes.

unkinben added 1 commit 2026-07-02 00:28:42 +10:00

fix: let getenv honour an explicitly-empty env var ... 1bed296c35

getenv fell back to the default whenever os.Getenv returned empty, so an
intentionally-empty override was impossible. Use os.LookupEnv to
distinguish unset from empty.

Refs #69

benvin merged commit c39703ed0d into master 2026-07-02 22:09:09 +10:00

benvin deleted branch benvin/getenv-lookupenv 2026-07-02 22:09:10 +10:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

benvin (BenVincent) unkinben (Ben Vincent)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unkin/artifactapi#85