test: raise core-package unit coverage to 90% #98

Merged

benvin merged 25 commits from benvin/unit-coverage-90 into master 2026-07-03 14:31:25 +10:00

Conversation 0 Commits 25 Files Changed 26

+3555

unkinben commented 2026-07-03 13:57:33 +10:00

Owner

Copy Link

Copy Source

Raises statement coverage of the core packages (all of internal/ except the interactive tui/, plus pkg/) from 8.7% to 90.1%.

Approach

• Pure-go unit tests for all providers, virtual mergers, classifier, config, auth, models, and the API client (httptest).
• Testcontainers-backed tests (new internal/testsupport helper: Postgres/Redis/MinIO, Ryuk disabled) for database, storage, cache, the proxy engine, the GC, and a full-stack server test that drives the whole HTTP API. These t.Skip when Docker is absent so go test still runs locally without it.

Measuring

go test -coverpkg=./internal/...,./pkg/... -coverprofile=cover.out ./internal/... ./pkg/...
grep -v /internal/tui/ cover.out | go tool cover -func=/dev/stdin | tail -1   # 90.1%

Run with -p 1 (containers are heavy).

Notes

• The interactive tui/ package and cmd/main are excluded from the target per the agreed scope.
• Some defensive error branches are covered via fault injection (closed DB pool, killing MinIO mid-upload).

Raises statement coverage of the core packages (all of `internal/` except the interactive `tui/`, plus `pkg/`) from **8.7% to 90.1%**. ## Approach - **Pure-go unit tests** for all providers, virtual mergers, classifier, config, auth, models, and the API client (httptest). - **Testcontainers-backed** tests (new `internal/testsupport` helper: Postgres/Redis/MinIO, Ryuk disabled) for database, storage, cache, the proxy engine, the GC, and a full-stack `server` test that drives the whole HTTP API. These `t.Skip` when Docker is absent so `go test` still runs locally without it. ## Measuring ``` go test -coverpkg=./internal/...,./pkg/... -coverprofile=cover.out ./internal/... ./pkg/... grep -v /internal/tui/ cover.out | go tool cover -func=/dev/stdin | tail -1 # 90.1% ``` Run with `-p 1` (containers are heavy). ## Notes - The interactive `tui/` package and `cmd/main` are excluded from the target per the agreed scope. - Some defensive error branches are covered via fault injection (closed DB pool, killing MinIO mid-upload).

unkinben added 24 commits 2026-07-03 13:57:34 +10:00

test: unit tests for pure provider/config/auth packages ... 428c6d0e97

First increment toward 90% core-package coverage. Adds Docker-free unit
tests taking these packages to full or near-full coverage:
- provider/npm, provider/alpine, provider/puppet: 100%
- provider/pypi: index generation via a fake FileStore, upload validation,
  name parsing, classification, rewrite
- config: defaults, overrides, DSN, invalid port
- auth: basic header with/without credentials

Infra-backed packages (database, storage, cache, proxy engine, api
handlers, server) still need the testcontainers batch to reach 90%.

test: cover rpm provider (metadata parse, repodata generation) ... b6091c859d

rpm 2.7% -> 83.6%, pure-go via a real RPM testdata fixture and fake
BlobReader/MetadataStore/RPMMetadataReader implementations.

test: cover virtual mergers and pkg/client ... db663e00d7

virtual mergers (helm/pypi merge, dedup, URL rewriting, registry) and the
API client (all endpoints via httptest, error/decode paths). pkg/client
0->96%, virtual 49->57%.

test: testcontainers harness + database integration tests ... bf31714e08

Add internal/testsupport (Postgres/Redis/MinIO container helpers, Ryuk
disabled) and full database coverage: remotes, artifacts/blobs, local
files, virtuals, stats, rpm metadata, orphan/cold cleanup. database
0->83%.

test: storage (MinIO) and cache (Redis) integration tests ... 5e7500ed04

storage 0->79%, cache 0->92%, via the testsupport container harness.

test: full-stack server integration test ... 6ba78caf4c

Drives the whole HTTP API against real Postgres/Redis/MinIO + a mock
upstream: health, remote CRUD, proxy miss/hit, local upload/download,
virtual helm merge, objects, stats, probe. Exercises server + api/v1 +
api/v2 + proxy + virtual engines together.

test: wait for postgres readiness log twice (avoid connection-reset flake) a6830d6d9f

test: wait for minio readiness endpoint (avoid init-race flake) 696a1955b3

test: proxy engine edge cases + storage/server minio retry ... 21579c1ec0

Cover denied, HEAD (cached/uncached/denied), stale-on-error, circuit-open,
and mutable revalidation (304) paths. proxy ~8->58%.

test: gc sweep integration (delete old orphan, empty no-op) ba4a0e3b43

test: expand server test (pypi/rpm local, object evict, validation errors) 915ec910c8

test: bearer-token flow (engine) + docker/head/virtual/probe/events (server) 3d80837539

test: probe branches, local upload errors, upstream errors, rpm/gc error paths 6bcda813fd

test: RunOnListener, local pypi virtual merge, v2 download, waitForStore/Unwrap 1842042241

test: v2 handler error paths (closed db), v1 scheme, rpm content-type/flag helpers 4ec3d7b59e

test: circuit breaker states, bearer cache-hit, blob dedup, terraform/storage branches 2658167346

test: proxy HTTP error branches (403/502) + revalidation upstream error 6029f19b86

test: server Run, upstream 500/401 branches, virtual dead members, local DB accessor cfd0bae515

test: ttlFor, HEAD 500/cached-index, rpm full-metadata xml, generic content-type 03a29f2c0a

test: provider-not-found and missing-blob download error branches 053fbd70e2

test: classifier branches, docker provider, pypi index serving, bearer/checkUpstream variants 3e590bea2b

test: rpm serve errors, terraform rewriteDownloadURL, pypi merger, s3 stat, pattern-validation 400 1d97628fbd

test: local upload store-failure branches (kill minio mid-test) 2ae12d9aef

test: database closed-db error paths + pure goproxy/generic/helm/repotype gaps 1009bc7c69

unkinben added 23 commits 2026-07-03 13:57:48 +10:00

test: cover rpm provider (metadata parse, repodata generation) ... b6091c859d

rpm 2.7% -> 83.6%, pure-go via a real RPM testdata fixture and fake
BlobReader/MetadataStore/RPMMetadataReader implementations.

test: cover virtual mergers and pkg/client ... db663e00d7

virtual mergers (helm/pypi merge, dedup, URL rewriting, registry) and the
API client (all endpoints via httptest, error/decode paths). pkg/client
0->96%, virtual 49->57%.

test: testcontainers harness + database integration tests ... bf31714e08

Add internal/testsupport (Postgres/Redis/MinIO container helpers, Ryuk
disabled) and full database coverage: remotes, artifacts/blobs, local
files, virtuals, stats, rpm metadata, orphan/cold cleanup. database
0->83%.

test: storage (MinIO) and cache (Redis) integration tests ... 5e7500ed04

storage 0->79%, cache 0->92%, via the testsupport container harness.

test: full-stack server integration test ... 6ba78caf4c

Drives the whole HTTP API against real Postgres/Redis/MinIO + a mock
upstream: health, remote CRUD, proxy miss/hit, local upload/download,
virtual helm merge, objects, stats, probe. Exercises server + api/v1 +
api/v2 + proxy + virtual engines together.

test: wait for postgres readiness log twice (avoid connection-reset flake) a6830d6d9f

test: wait for minio readiness endpoint (avoid init-race flake) 696a1955b3

test: proxy engine edge cases + storage/server minio retry ... 21579c1ec0

Cover denied, HEAD (cached/uncached/denied), stale-on-error, circuit-open,
and mutable revalidation (304) paths. proxy ~8->58%.

test: gc sweep integration (delete old orphan, empty no-op) ba4a0e3b43

test: expand server test (pypi/rpm local, object evict, validation errors) 915ec910c8

test: bearer-token flow (engine) + docker/head/virtual/probe/events (server) 3d80837539

test: probe branches, local upload errors, upstream errors, rpm/gc error paths 6bcda813fd

test: RunOnListener, local pypi virtual merge, v2 download, waitForStore/Unwrap 1842042241

test: v2 handler error paths (closed db), v1 scheme, rpm content-type/flag helpers 4ec3d7b59e

test: circuit breaker states, bearer cache-hit, blob dedup, terraform/storage branches 2658167346

test: proxy HTTP error branches (403/502) + revalidation upstream error 6029f19b86

test: server Run, upstream 500/401 branches, virtual dead members, local DB accessor cfd0bae515

test: ttlFor, HEAD 500/cached-index, rpm full-metadata xml, generic content-type 03a29f2c0a

test: provider-not-found and missing-blob download error branches 053fbd70e2

test: classifier branches, docker provider, pypi index serving, bearer/checkUpstream variants 3e590bea2b

test: rpm serve errors, terraform rewriteDownloadURL, pypi merger, s3 stat, pattern-validation 400 1d97628fbd

test: local upload store-failure branches (kill minio mid-test) 2ae12d9aef

test: database closed-db error paths + pure goproxy/generic/helm/repotype gaps 1009bc7c69

unkinben added 1 commit 2026-07-03 14:25:33 +10:00

test: generate a minimal RPM in pure Go instead of a committed fixture ... 35719984e6

Removes the committed .rpm binary (gitignored, so it broke clean checkouts)
and the rpmbuild dependency. testsupport.MinimalRPM builds a valid-enough
RPM header in-memory for cavaliergopher/rpm to parse, used by both the rpm
provider test and the full-stack server repodata test.

benvin merged commit a1ba86e76b into master 2026-07-03 14:31:25 +10:00

benvin deleted branch benvin/unit-coverage-90 2026-07-03 14:31:25 +10:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

benvin (BenVincent) unkinben (Ben Vincent)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unkin/artifactapi#98