unkin-agent
6a08539a78
Evicting a remote object only deleted its Postgres row. The S3 index and the Redis TTL/ETag keys survived, so stale mirror metadata such as EPEL repodata kept being served. - evict the artifact row, S3 index and Redis keys via `Engine.Evict` - evict a directory with `<dir>/*`; other wildcards return 400, unknown remotes 404 - wait on the per-path fetch lock for single-path evicts; return 503 on timeout or a Redis error - wildcard evicts take no lock; a fetch already in flight may re-cache its path - return S3 list errors from `DeletePrefix` instead of deleting nothing Reviewed-on: #128 Co-authored-by: unkin-agent <unkin-agent@unkin.net> Co-committed-by: unkin-agent <unkin-agent@unkin.net>
111 lines
2.9 KiB
Go
111 lines
2.9 KiB
Go
package v2
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"strconv"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
|
|
"git.unkin.net/unkin/artifactapi/internal/database"
|
|
"git.unkin.net/unkin/artifactapi/internal/proxy"
|
|
)
|
|
|
|
// Evictor drops a remote path from every cache layer.
|
|
type Evictor interface {
|
|
Evict(ctx context.Context, remoteName, path string) error
|
|
}
|
|
|
|
type ObjectsHandler struct {
|
|
db *database.DB
|
|
}
|
|
|
|
func NewObjectsHandler(db *database.DB) *ObjectsHandler {
|
|
return &ObjectsHandler{db: db}
|
|
}
|
|
|
|
// Routes lists and evicts objects for remote repos; evictor serves the DELETE.
|
|
func (h *ObjectsHandler) Routes(evictor Evictor) chi.Router {
|
|
r := chi.NewRouter()
|
|
r.Get("/", h.list)
|
|
r.Delete("/*", func(w http.ResponseWriter, r *http.Request) {
|
|
evict(w, r, evictor)
|
|
})
|
|
return r
|
|
}
|
|
|
|
// LocalRoutes lists and evicts objects for local repos, which live in the
|
|
// local_files table rather than the artifacts table used by remotes.
|
|
func (h *ObjectsHandler) LocalRoutes() chi.Router {
|
|
r := chi.NewRouter()
|
|
r.Get("/", h.listLocal)
|
|
r.Delete("/*", h.evictLocal)
|
|
return r
|
|
}
|
|
|
|
// pageBounds parses the shared page/per_page query params into a SQL limit and offset.
|
|
func pageBounds(r *http.Request) (limit, offset int) {
|
|
limit, _ = strconv.Atoi(r.URL.Query().Get("per_page"))
|
|
if limit <= 0 || limit > 5000 {
|
|
limit = 50
|
|
}
|
|
page, _ := strconv.Atoi(r.URL.Query().Get("page"))
|
|
if page <= 0 {
|
|
page = 1
|
|
}
|
|
return limit, (page - 1) * limit
|
|
}
|
|
|
|
func (h *ObjectsHandler) list(w http.ResponseWriter, r *http.Request) {
|
|
remoteName := chi.URLParam(r, "name")
|
|
limit, offset := pageBounds(r)
|
|
|
|
artifacts, err := h.db.ListArtifacts(r.Context(), remoteName, limit, offset)
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, artifacts)
|
|
}
|
|
|
|
func (h *ObjectsHandler) listLocal(w http.ResponseWriter, r *http.Request) {
|
|
repoName := chi.URLParam(r, "name")
|
|
limit, offset := pageBounds(r)
|
|
|
|
artifacts, err := h.db.ListLocalArtifacts(r.Context(), repoName, limit, offset)
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, artifacts)
|
|
}
|
|
|
|
func (h *ObjectsHandler) evictLocal(w http.ResponseWriter, r *http.Request) {
|
|
repoName := chi.URLParam(r, "name")
|
|
path := chi.URLParam(r, "*")
|
|
|
|
if err := deleteLocalFile(r.Context(), h.db, repoName, path); err != nil {
|
|
http.Error(w, fmt.Sprintf("evict failed: %v", err), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
|
|
func evict(w http.ResponseWriter, r *http.Request, evictor Evictor) {
|
|
remoteName := chi.URLParam(r, "name")
|
|
path := chi.URLParam(r, "*")
|
|
|
|
if err := evictor.Evict(r.Context(), remoteName, path); err != nil {
|
|
var proxyErr *proxy.ProxyError
|
|
if errors.As(err, &proxyErr) {
|
|
http.Error(w, proxyErr.Message, proxyErr.Status)
|
|
return
|
|
}
|
|
http.Error(w, fmt.Sprintf("evict failed: %v", err), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|