Prefer null checks over HasValue everywhere

Emby.Server.Implementations/Library/LibraryManager.cs

@@ -3195,11 +3195,11 @@ namespace Emby.Server.Implementations.Library
                     }
                 }
 
-                if (!episode.ProductionYear.HasValue)
+                if (episode.ProductionYear is null)
                 {
                     episode.ProductionYear = episodeInfo.Year;
 
-                    if (episode.ProductionYear.HasValue)
+                    if (episode.ProductionYear is not null)
                     {
                         changed = true;
                     }

Emby.Server.Implementations/Sorting/PremiereDateComparer.cs

@@ -45,7 +45,7 @@ namespace Emby.Server.Implementations.Sorting
                 return x.PremiereDate.Value;
             }
 
-            if (x.ProductionYear.HasValue)
+            if (x.ProductionYear is not null)
             {
                 try
                 {

Emby.Server.Implementations/Sorting/ProductionYearComparer.cs

@@ -39,7 +39,7 @@ namespace Emby.Server.Implementations.Sorting
                 return 0;
             }
 
-            if (x.ProductionYear.HasValue)
+            if (x.ProductionYear is not null)
             {
                 return x.ProductionYear.Value;
             }

MediaBrowser.Controller/Entities/Movies/Movie.cs

@@ -90,7 +90,7 @@ namespace MediaBrowser.Controller.Entities.Movies
         {
             var hasChanges = base.BeforeMetadataRefresh(replaceAllMetadata);
 
-            if (!ProductionYear.HasValue)
+            if (ProductionYear is null)
             {
                 var info = LibraryManager.ParseName(Name);
 

MediaBrowser.Controller/Entities/MusicVideo.cs

@@ -40,7 +40,7 @@ namespace MediaBrowser.Controller.Entities
         {
             var hasChanges = base.BeforeMetadataRefresh(replaceAllMetadata);
 
-            if (!ProductionYear.HasValue)
+            if (ProductionYear is null)
             {
                 var info = LibraryManager.ParseName(Name);
 

MediaBrowser.Controller/Entities/TV/Series.cs

@@ -507,7 +507,7 @@ namespace MediaBrowser.Controller.Entities.TV
         {
             var hasChanges = base.BeforeMetadataRefresh(replaceAllMetadata);
 
-            if (!ProductionYear.HasValue)
+            if (ProductionYear is null)
             {
                 var info = LibraryManager.ParseName(Name);
 

MediaBrowser.Controller/Entities/Trailer.cs

@@ -49,7 +49,7 @@ namespace MediaBrowser.Controller.Entities
         {
             var hasChanges = base.BeforeMetadataRefresh(replaceAllMetadata);
 
-            if (!ProductionYear.HasValue)
+            if (ProductionYear is null)
             {
                 var info = LibraryManager.ParseName(Name);
 

MediaBrowser.Controller/Entities/UserViewBuilder.cs

@@ -730,7 +730,7 @@ namespace MediaBrowser.Controller.Entities
             // Apply year filter
             if (query.Years.Length > 0)
             {
-                if (!(item.ProductionYear.HasValue && query.Years.Contains(item.ProductionYear.Value)))
+                if (item.ProductionYear is null || !query.Years.Contains(item.ProductionYear.Value))
                 {
                     return false;
                 }

MediaBrowser.LocalMetadata/Savers/BaseXmlSaver.cs

@@ -277,7 +277,7 @@ namespace MediaBrowser.LocalMetadata.Savers
                 await writer.WriteElementStringAsync(null, "Rating", null, item.CommunityRating.Value.ToString(CultureInfo.InvariantCulture)).ConfigureAwait(false);
             }
 
-            if (item.ProductionYear.HasValue && item is not Person)
+            if (item.ProductionYear is not null && item is not Person)
             {
                 await writer.WriteElementStringAsync(null, "ProductionYear", null, item.ProductionYear.Value.ToString(CultureInfo.InvariantCulture)).ConfigureAwait(false);
             }

MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs

@@ -189,7 +189,7 @@ namespace MediaBrowser.MediaEncoding.Probing
             }
 
             // Guess ProductionYear from PremiereDate if missing
-            if (!info.ProductionYear.HasValue && info.PremiereDate.HasValue)
+            if (info.ProductionYear is null && info.PremiereDate is not null)
             {
                 info.ProductionYear = info.PremiereDate.Value.Year;
             }

MediaBrowser.Providers/Manager/MetadataService.cs

@@ -1114,7 +1114,7 @@ namespace MediaBrowser.Providers.Manager
                 target.PremiereDate = source.PremiereDate;
             }
 
-            if (replaceData || !target.ProductionYear.HasValue)
+            if (replaceData || target.ProductionYear is null)
             {
                 target.ProductionYear = source.ProductionYear;
             }

MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs

@@ -432,9 +432,9 @@ namespace MediaBrowser.Providers.MediaInfo
                 }
             }
 
-            if (data.ProductionYear.HasValue)
+            if (data.ProductionYear is not null)
             {
-                if (!video.ProductionYear.HasValue || replaceData)
+                if (video.ProductionYear is null || replaceData)
                 {
                     video.ProductionYear = data.ProductionYear;
                 }
@@ -482,7 +482,7 @@ namespace MediaBrowser.Providers.MediaInfo
             }
 
             // If we don't have a ProductionYear try and get it from PremiereDate
-            if (video.PremiereDate.HasValue && !video.ProductionYear.HasValue)
+            if (video.PremiereDate is not null && video.ProductionYear is null)
             {
                 video.ProductionYear = video.PremiereDate.Value.ToLocalTime().Year;
             }

MediaBrowser.XbmcMetadata/Savers/ArtistNfoSaver.cs

@@ -82,7 +82,7 @@ namespace MediaBrowser.XbmcMetadata.Savers
                     writer.WriteElementString("title", album.Name);
                 }
 
-                if (album.ProductionYear.HasValue)
+                if (album.ProductionYear is not null)
                 {
                     writer.WriteElementString("year", album.ProductionYear.Value.ToString(CultureInfo.InvariantCulture));
                 }

MediaBrowser.XbmcMetadata/Savers/BaseNfoSaver.cs

@@ -544,7 +544,7 @@ namespace MediaBrowser.XbmcMetadata.Savers
                 writer.WriteElementString("rating", item.CommunityRating.Value.ToString(CultureInfo.InvariantCulture));
             }
 
-            if (item.ProductionYear.HasValue)
+            if (item.ProductionYear is not null)
             {
                 writer.WriteElementString("year", item.ProductionYear.Value.ToString(CultureInfo.InvariantCulture));
             }

src/Jellyfin.LiveTv/Recordings/RecordingsManager.cs

@@ -497,7 +497,7 @@ public sealed class RecordingsManager : IRecordingsManager, IDisposable
             // trim trailing period from the folder name
             var folderName = _fileSystem.GetValidFilename(timer.Name).Trim().TrimEnd('.').Trim();
 
-            if (metadata is not null && metadata.ProductionYear.HasValue)
+            if (metadata is not null && metadata.ProductionYear is not null)
             {
                 folderName += " (" + metadata.ProductionYear.Value.ToString(CultureInfo.InvariantCulture) + ")";
             }
@@ -532,7 +532,7 @@ public sealed class RecordingsManager : IRecordingsManager, IDisposable
             }
 
             var folderName = _fileSystem.GetValidFilename(timer.Name).Trim();
-            if (timer.ProductionYear.HasValue)
+            if (timer.ProductionYear is not null)
             {
                 folderName += " (" + timer.ProductionYear.Value.ToString(CultureInfo.InvariantCulture) + ")";
             }
@@ -550,7 +550,7 @@ public sealed class RecordingsManager : IRecordingsManager, IDisposable
             }
 
             var folderName = _fileSystem.GetValidFilename(timer.Name).Trim();
-            if (timer.ProductionYear.HasValue)
+            if (timer.ProductionYear is not null)
             {
                 folderName += " (" + timer.ProductionYear.Value.ToString(CultureInfo.InvariantCulture) + ")";
             }

src/Jellyfin.LiveTv/Recordings/RecordingsMetadataManager.cs

@@ -290,7 +290,7 @@ public class RecordingsMetadataManager
                     null,
                     DateTime.UtcNow.ToString(DateAddedFormat, CultureInfo.InvariantCulture)).ConfigureAwait(false);
 
-                if (item.ProductionYear.HasValue)
+                if (item.ProductionYear is not null)
                 {
                     await writer.WriteElementStringAsync(null, "year", null, item.ProductionYear.Value.ToString(CultureInfo.InvariantCulture)).ConfigureAwait(false);
                 }