Merge pull request #6000 from Bond-009/nullable2

Emby.Server.Implementations/Library/ResolverHelper.cs

@@ -44,6 +44,11 @@ namespace Emby.Server.Implementations.Library
 
             // Make sure DateCreated and DateModified have values
             var fileInfo = directoryService.GetFile(item.Path);
+            if (fileInfo == null)
+            {
+                throw new FileNotFoundException("Can't find item path.", item.Path);
+            }
+
             SetDateCreated(item, fileInfo);
 
             EnsureName(item, fileInfo);

Jellyfin.Api/Controllers/LibraryController.cs

@@ -600,7 +600,7 @@ namespace Jellyfin.Api.Controllers
         {
             foreach (var item in dto.Updates)
             {
-                _libraryMonitor.ReportFileSystemChanged(item.Path);
+                _libraryMonitor.ReportFileSystemChanged(item.Path ?? throw new ArgumentException("Item path can't be null."));
             }
 
             return NoContent();

MediaBrowser.Controller/Authentication/AuthenticationResult.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using MediaBrowser.Controller.Session;

MediaBrowser.Controller/Authentication/IAuthenticationProvider.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Threading.Tasks;

MediaBrowser.Controller/Authentication/IPasswordResetProvider.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/BaseItemManager/BaseItemManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 using System;
 using System.Linq;
 using System.Threading;

MediaBrowser.Controller/BaseItemManager/IBaseItemManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 using System.Threading;
 using MediaBrowser.Controller.Entities;
 using MediaBrowser.Model.Configuration;

MediaBrowser.Controller/Channels/Channel.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Channels/ChannelItemInfo.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Channels/ChannelItemResult.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Collections.Generic;

MediaBrowser.Controller/Channels/ChannelSearchInfo.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 namespace MediaBrowser.Controller.Channels

MediaBrowser.Controller/Channels/IChannel.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Collections.Generic;

MediaBrowser.Controller/Channels/IChannelManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Channels/IHasCacheKey.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 namespace MediaBrowser.Controller.Channels

MediaBrowser.Controller/Channels/ISearchableChannel.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Collections.Generic;

MediaBrowser.Controller/Channels/InternalChannelFeatures.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Collections.Generic;

MediaBrowser.Controller/Channels/InternalChannelItemQuery.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Collections/CollectionCreationOptions.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Collections/CollectionEvents.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Collections/ICollectionManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Configuration/IServerConfigurationManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 using MediaBrowser.Common.Configuration;
 using MediaBrowser.Model.Configuration;
 

MediaBrowser.Controller/Devices/IDeviceManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Dlna/IDlnaManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Collections.Generic;

MediaBrowser.Controller/Drawing/IImageEncoder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 #nullable enable
 

MediaBrowser.Controller/Drawing/IImageProcessor.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 #nullable enable
 

MediaBrowser.Controller/Drawing/ImageCollageOptions.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 namespace MediaBrowser.Controller.Drawing

MediaBrowser.Controller/Drawing/ImageHelper.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 #nullable enable
 

MediaBrowser.Controller/Drawing/ImageProcessingOptions.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Drawing/ImageProcessorExtensions.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using MediaBrowser.Controller.Entities;

MediaBrowser.Controller/Drawing/ImageStream.cs

@@ -12,7 +12,7 @@ namespace MediaBrowser.Controller.Drawing
         /// Gets or sets the stream.
         /// </summary>
         /// <value>The stream.</value>
-        public Stream Stream { get; set; }
+        public Stream? Stream { get; set; }
 
         /// <summary>
         /// Gets or sets the format.

MediaBrowser.Controller/Dto/DtoOptions.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Dto/IDtoService.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 using System.Collections.Generic;
 using Jellyfin.Data.Entities;
 using MediaBrowser.Controller.Entities;

MediaBrowser.Controller/Entities/AggregateFolder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Audio/Audio.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Audio/IHasAlbumArtist.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Collections.Generic;

MediaBrowser.Controller/Entities/Audio/IHasMusicGenres.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 namespace MediaBrowser.Controller.Entities.Audio

MediaBrowser.Controller/Entities/Audio/MusicAlbum.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Audio/MusicArtist.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Audio/MusicGenre.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/AudioBook.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/BaseItem.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/BaseItemExtensions.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #nullable enable
 #pragma warning disable CS1591
 

MediaBrowser.Controller/Entities/BasePluginFolder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Text.Json.Serialization;

MediaBrowser.Controller/Entities/Book.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/CollectionFolder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Extensions.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 using System;
 using System.Linq;
 using MediaBrowser.Common.Extensions;

MediaBrowser.Controller/Entities/Folder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Genre.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/ICollectionFolder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/IHasAspectRatio.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 namespace MediaBrowser.Controller.Entities
 {
     /// <summary>

MediaBrowser.Controller/Entities/IHasDisplayOrder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 namespace MediaBrowser.Controller.Entities
 {
     /// <summary>

MediaBrowser.Controller/Entities/IHasMediaSources.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/IHasProgramAttributes.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using MediaBrowser.Model.LiveTv;

MediaBrowser.Controller/Entities/IHasSeries.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/IHasSpecialFeatures.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/IHasTrailers.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/InternalItemsQuery.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/InternalPeopleQuery.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/ItemImageInfo.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/LinkedChild.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Movies/BoxSet.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Movies/Movie.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/MusicVideo.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Person.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/PersonInfo.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Photo.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Text.Json.Serialization;

MediaBrowser.Controller/Entities/Share.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 namespace MediaBrowser.Controller.Entities

MediaBrowser.Controller/Entities/Studio.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/TV/Episode.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/TV/Season.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/TV/Series.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Trailer.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/UserItemData.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/UserRootFolder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/UserView.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/UserViewBuilder.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Video.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Entities/Year.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Events/IEventConsumer.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Threading.Tasks;
 
 namespace MediaBrowser.Controller.Events

MediaBrowser.Controller/Events/IEventManager.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Threading.Tasks;
 
 namespace MediaBrowser.Controller.Events

MediaBrowser.Controller/Events/Session/SessionEndedEventArgs.cs

@@ -1,4 +1,4 @@
-using Jellyfin.Data.Events;
+using Jellyfin.Data.Events;
 using MediaBrowser.Controller.Session;
 
 namespace MediaBrowser.Controller.Events.Session

MediaBrowser.Controller/Events/Session/SessionStartedEventArgs.cs

@@ -1,4 +1,4 @@
-using Jellyfin.Data.Events;
+using Jellyfin.Data.Events;
 using MediaBrowser.Controller.Session;
 
 namespace MediaBrowser.Controller.Events.Session

MediaBrowser.Controller/Events/Updates/PluginInstallationCancelledEventArgs.cs

@@ -1,4 +1,4 @@
-using Jellyfin.Data.Events;
+using Jellyfin.Data.Events;
 using MediaBrowser.Model.Updates;
 
 namespace MediaBrowser.Controller.Events.Updates

MediaBrowser.Controller/Events/Updates/PluginInstalledEventArgs.cs

@@ -1,4 +1,4 @@
-using Jellyfin.Data.Events;
+using Jellyfin.Data.Events;
 using MediaBrowser.Model.Updates;
 
 namespace MediaBrowser.Controller.Events.Updates

MediaBrowser.Controller/Events/Updates/PluginInstallingEventArgs.cs

@@ -1,4 +1,4 @@
-using Jellyfin.Data.Events;
+using Jellyfin.Data.Events;
 using MediaBrowser.Model.Updates;
 
 namespace MediaBrowser.Controller.Events.Updates

MediaBrowser.Controller/Events/Updates/PluginUpdatedEventArgs.cs

@@ -1,4 +1,4 @@
-using Jellyfin.Data.Events;
+using Jellyfin.Data.Events;
 using MediaBrowser.Model.Updates;
 
 namespace MediaBrowser.Controller.Events.Updates

MediaBrowser.Controller/Extensions/StringExtensions.cs

@@ -1,4 +1,3 @@
-#nullable enable
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/IDisplayPreferencesManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 using System;
 using System.Collections.Generic;
 using Jellyfin.Data.Entities;

MediaBrowser.Controller/IServerApplicationHost.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/IServerApplicationPaths.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using MediaBrowser.Common.Configuration;

MediaBrowser.Controller/Library/IIntroProvider.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 using System.Collections.Generic;
 using System.Threading.Tasks;
 using MediaBrowser.Controller.Entities;

MediaBrowser.Controller/Library/ILibraryManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Library/ILiveStream.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Threading;

MediaBrowser.Controller/Library/IMediaSourceManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Library/IMetadataSaver.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 using System.Threading;
 using MediaBrowser.Controller.Entities;
 

MediaBrowser.Controller/Library/IMusicManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System.Collections.Generic;

MediaBrowser.Controller/Library/IUserDataManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Library/IUserManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Library/IUserViewManager.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;

MediaBrowser.Controller/Library/IntroInfo.cs

@@ -1,3 +1,5 @@
+#nullable disable
+
 #pragma warning disable CS1591
 
 using System;