unkin/jellyfin-ha-src
4
0
Fork 0
Code Issues 15 Pull Requests Packages Projects Releases Wiki Activity

fix(config): read an unusable encoding.xml EncoderPreset as the default #5

Merged
benvin merged 1 commits from benvin/fix-encoder-preset-fallback into main 2026-09-12 17:43:53 +10:00
Conversation 0 Commits 1 Files Changed 2
+74
unkin-agent commented 2026-09-12 16:26:10 +10:00
Member
Copy Link
Copy Source

An EncoderPreset element the enum cannot parse throws during deserialization, and BaseConfigurationManager.LoadConfiguration catches that and returns defaults, so one bad value silently discarded every other encoding setting in encoding.xml.

  • serialize EncoderPreset through a string surrogate in XML, leaving JSON untouched
  • fall back to auto for an empty, unknown or out-of-range value
An `EncoderPreset` element the enum cannot parse throws during deserialization, and `BaseConfigurationManager.LoadConfiguration` catches that and returns defaults, so one bad value silently discarded every other encoding setting in `encoding.xml`. - serialize `EncoderPreset` through a string surrogate in XML, leaving JSON untouched - fall back to `auto` for an empty, unknown or out-of-range value
unkin-agent added 1 commit 2026-09-12 16:26:10 +10:00
fix(config): read an unusable encoding.xml EncoderPreset as the default
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
3b60289502 
An element the enum cannot parse throws, and the configuration manager
catches that and returns defaults, so one bad preset discarded every other
encoding setting.

- serialize EncoderPreset through a string surrogate in XML
- fall back to auto for an empty, unknown or out-of-range value
benvin merged commit f2166df463 into main 2026-09-12 17:43:53 +10:00
benvin deleted branch benvin/fix-encoder-preset-fallback 2026-09-12 17:43:54 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/jellyfin-ha-src#5
Delete Branch "benvin/fix-encoder-preset-fallback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?