Piotr Niełacny
6e3c187493
SubtitleEncoder.ConvertSubtitles parsed subtitles with libse's static Subtitle.Parse, which iterates a statically cached list of shared SubtitleFormat instances. Format parsers keep mutable per-parse state on the instance, so concurrent subtitle requests corrupted each other's output (cues mixed across streams and languages, truncated files) or failed with NullReferenceException when format detection broke down and Subtitle.Parse returned null. Parse through the injected ISubtitleParser instead. SubtitleEditParser instantiates a fresh format parser per call, so requests no longer share state. Its Parse method now returns the libse Subtitle directly (the SubtitleTrackInfo flattening was unused since the SubtitleEdit writer rework) so the writers keep full fidelity such as ASS styling.
26 lines
849 B
C#
26 lines
849 B
C#
#pragma warning disable CS1591
|
|
|
|
using System.IO;
|
|
using Nikse.SubtitleEdit.Core.Common;
|
|
|
|
namespace MediaBrowser.MediaEncoding.Subtitles
|
|
{
|
|
public interface ISubtitleParser
|
|
{
|
|
/// <summary>
|
|
/// Parses the specified stream.
|
|
/// </summary>
|
|
/// <param name="stream">The stream.</param>
|
|
/// <param name="fileExtension">The file extension.</param>
|
|
/// <returns>The parsed subtitle.</returns>
|
|
Subtitle Parse(Stream stream, string fileExtension);
|
|
|
|
/// <summary>
|
|
/// Determines whether the file extension is supported by the parser.
|
|
/// </summary>
|
|
/// <param name="fileExtension">The file extension.</param>
|
|
/// <returns>A value indicating whether the file extension is supported.</returns>
|
|
bool SupportsFileExtension(string fileExtension);
|
|
}
|
|
}
|