fix: look up existing release by tag instead of creating a new one (#6 )

tea creates the release before the pipeline runs; POST was failing with conflict, leaving RELEASE_ID empty and skipping the asset upload. Now GETs the release by tag, PATCHes its body, then uploads the binary. 💘 Generated with Crush Assisted-by: Claude Sonnet 4.6 via Crush <crush@charm.land> Reviewed-on: #6
fix: surface release API errors in woodpecker pipeline (#5 )
2026-03-26 13:17:25 +11:00 · 2026-03-26 12:48:54 +11:00 · 2026-03-25 21:27:45 +11:00 · 2026-03-25 19:45:34 +11:00
2 changed files with 29 additions and 11 deletions
@@ -15,16 +15,34 @@ steps:
    depends_on: [test]

  - name: release
-    image: woodpeckerci/plugin-gitea-release
-    settings:
-      api_key:
-        from_secret: GITEA_TOKEN
-      base_url: https://git.unkin.net
-      files: node-lookup
-      title: ${CI_COMMIT_TAG}
+    image: git.unkin.net/unkin/almalinux9-base:20260325
    environment:
      DRONECI_PASSWORD:
        from_secret: DRONECI_PASSWORD
+    commands:
+      - |
+        PREV_TAG=$(git describe --tags --abbrev=0 HEAD^ 2>/dev/null || echo "")
+        if [ -n "$PREV_TAG" ]; then
+          NOTES=$(git log "${PREV_TAG}..${CI_COMMIT_TAG}" --merges --pretty=format:"- %s")
+        else
+          NOTES=$(git log --merges --pretty=format:"- %s")
+        fi
+        BODY=$(printf '%s' "$NOTES" | sed 's/"/\\"/g; s/$/\\n/' | tr -d '\n')
+        GET_RESPONSE=$(curl -s "https://git.unkin.net/api/v1/repos/${CI_REPO}/releases/tags/${CI_COMMIT_TAG}")
+        echo "GET response: ${GET_RESPONSE}"
+        RELEASE_ID=$(echo "${GET_RESPONSE}" | grep -o '"id":[0-9]*' | head -1 | cut -d: -f2)
+        if [ -z "$RELEASE_ID" ]; then
+          echo "ERROR: failed to find release for tag ${CI_COMMIT_TAG}" >&2
+          exit 1
+        fi
+        echo "Release ID: ${RELEASE_ID}"
+        curl -s -X PATCH "https://git.unkin.net/api/v1/repos/${CI_REPO}/releases/${RELEASE_ID}" \
+          -u "droneci:$DRONECI_PASSWORD" \
+          -H "Content-Type: application/json" \
+          -d "{\"body\":\"${BODY}\"}"
+        curl -s -X POST "https://git.unkin.net/api/v1/repos/${CI_REPO}/releases/${RELEASE_ID}/assets" \
+          -u "droneci:$DRONECI_PASSWORD" \
+          -F "attachment=@node-lookup"
    backend_options:
      kubernetes:
        serviceAccountName: default
@@ -354,11 +354,11 @@ func TestAllFactsForNode_QueryContainsCertname(t *testing.T) {
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		receivedQuery = r.URL.Query().Get("query")
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode([]fact{})
+		_ = json.NewEncoder(w).Encode([]fact{})
 	}))
 	defer srv.Close()

-	allFactsForNode(srv.URL+"/pdb/query/v4/facts", "mynode.example.com")
+	_, _ = allFactsForNode(srv.URL+"/pdb/query/v4/facts", "mynode.example.com")
 	if !strings.Contains(receivedQuery, "mynode.example.com") {
 		t.Fatalf("expected certname in query, got: %s", receivedQuery)
 	}
@@ -405,10 +405,10 @@ func TestRun_AllFacts_PrintsSortedByName(t *testing.T) {
 	cfg := config{PuppetDBURL: srv.URL + "/pdb/query/v4/facts", RoleFact: "enc_role"}
 	err := run(cfg, "node1", "", "", "", false, false, false, false, false, false, true)

-	w.Close()
+	_ = w.Close()
 	os.Stdout = old
 	var buf strings.Builder
-	io.Copy(&buf, r)
+	_, _ = io.Copy(&buf, r)
 	out := buf.String()

 	if err != nil {
Author	SHA1	Message	Date
unkinben	3291f8f73d	fix: look up existing release by tag instead of creating a new one (#6 ) ci/woodpecker/release/release Pipeline failed Details tea creates the release before the pipeline runs; POST was failing with conflict, leaving RELEASE_ID empty and skipping the asset upload. Now GETs the release by tag, PATCHes its body, then uploads the binary. 💘 Generated with Crush Assisted-by: Claude Sonnet 4.6 via Crush <crush@charm.land> Reviewed-on: #6	2026-03-26 13:17:25 +11:00
unkinben	3a4c9ea1c1	fix: surface release API errors in woodpecker pipeline (#5 ) ci/woodpecker/release/release Pipeline failed Details Capture and print the full Gitea API response before parsing the release ID, and fail explicitly if the ID is empty so the root cause is visible in CI logs instead of silently producing a malformed asset upload URL. 💘 Generated with Crush Assisted-by: Claude Sonnet 4.6 via Crush <crush@charm.land> Reviewed-on: #5	2026-03-26 12:48:54 +11:00
unkinben	b0d8f57b6f	Add merged branch release notes to Gitea release body (#4 ) ci/woodpecker/release/release Pipeline failed Details Generates release notes from merged branches since last tag and includes them in the release body via Gitea API. Reviewed-on: #4	2026-03-25 21:27:45 +11:00
unkinben	45cb378022	Replace gitea-release plugin with curl-based release upload (#3 ) Uses basic auth (droneci user) and Gitea API directly to create the release and upload the binary asset. Reviewed-on: #3	2026-03-25 19:45:34 +11:00