fix: remove positional tag argument from tea releases create (#12)

Passing tag both as argument and --tag flag causes ambiguous args error.

💘 Generated with Crush

Assisted-by: Claude Sonnet 4.6 via Crush <crush@charm.land>

Reviewed-on: #12

.woodpecker/release.yaml

@@ -1,5 +1,5 @@
 when:
-  - event: release
+  - event: tag
 
 steps:
   - name: test
@@ -7,29 +7,53 @@ steps:
     commands:
       - go test ./...
 
-  - name: build
+  - name: build-linux-amd64
     image: golang:latest
     commands:
-      - VERSION=${CI_COMMIT_TAG}
-      - go build -ldflags="-s -w -X main.version=${VERSION}" -o node-lookup ./...
+      - GOOS=linux GOARCH=amd64 go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" -o node-lookup-linux-amd64 ./...
+    depends_on: [test]
+
+  - name: build-linux-arm64
+    image: golang:latest
+    commands:
+      - GOOS=linux GOARCH=arm64 go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" -o node-lookup-linux-arm64 ./...
+    depends_on: [test]
+
+  - name: build-darwin-amd64
+    image: golang:latest
+    commands:
+      - GOOS=darwin GOARCH=amd64 go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" -o node-lookup-darwin-amd64 ./...
+    depends_on: [test]
+
+  - name: build-darwin-arm64
+    image: golang:latest
+    commands:
+      - GOOS=darwin GOARCH=arm64 go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" -o node-lookup-darwin-arm64 ./...
     depends_on: [test]
 
   - name: release
-    image: alpine/curl
+    image: git.unkin.net/unkin/almalinux9-base:20260325
     environment:
-      DRONECI_PASSWORD:
-        from_secret: DRONECI_PASSWORD
+      RELEASER_TOKEN:
+        from_secret: RELEASER_TOKEN
     commands:
       - |
-        RELEASE_ID=$(curl -sf -X POST "https://git.unkin.net/api/v1/repos/${CI_REPO}/releases" \
-          -u "droneci:$DRONECI_PASSWORD" \
-          -H "Content-Type: application/json" \
-          -d "{\"tag_name\":\"${CI_COMMIT_TAG}\",\"name\":\"${CI_COMMIT_TAG}\"}" \
-          | grep -o '"id":[0-9]*' | head -1 | cut -d: -f2)
-        curl -sf -X POST "https://git.unkin.net/api/v1/repos/${CI_REPO}/releases/${RELEASE_ID}/assets" \
-          -u "droneci:$DRONECI_PASSWORD" \
-          -F "attachment=@node-lookup"
+        curl --output /usr/local/bin/tea https://artifactapi.k8s.syd1.au.unkin.net/api/v1/remote/gitea-dl/tea/0.12.0/tea-0.12.0-linux-amd64 && chmod +x /usr/local/bin/tea
+        tea logins add --name gitea --url https://git.unkin.net --token "$${RELEASER_TOKEN}" --no-version-check
+        PREV_TAG=$(git describe --tags --abbrev=0 HEAD^ 2>/dev/null || echo "")
+        if [ -n "$PREV_TAG" ]; then
+          NOTES=$(git log "${PREV_TAG}..${CI_COMMIT_TAG}" --pretty=format:"- %s")
+        else
+          NOTES=$(git log --pretty=format:"- %s")
+        fi
+        tea releases create --tag "${CI_COMMIT_TAG}" --title "${CI_COMMIT_TAG}" --note "${NOTES}" --login gitea --repo "${CI_REPO}"
+        tea releases assets create "${CI_COMMIT_TAG}" \
+          node-lookup-linux-amd64 \
+          node-lookup-linux-arm64 \
+          node-lookup-darwin-amd64 \
+          node-lookup-darwin-arm64 \
+          --login gitea --repo "${CI_REPO}"
     backend_options:
       kubernetes:
         serviceAccountName: default
-    depends_on: [build]
+    depends_on: [build-linux-amd64, build-linux-arm64, build-darwin-amd64, build-darwin-arm64]

Makefile

@@ -2,7 +2,7 @@ BINARY   := node-lookup
 VERSION  := $(shell git describe --tags --always --dirty 2>/dev/null || echo dev)
 GOFLAGS  := -ldflags="-s -w -X main.version=$(VERSION)"
 
-.PHONY: all build test lint clean install patch minor major _release
+.PHONY: all build test lint clean install patch minor major _tag
 
 all: build
 
@@ -31,16 +31,15 @@ _PAT    := $(shell echo $(_BASE) | sed 's/^v//' | cut -d. -f3)
 
 patch:
 	@NEW=v$(_MAJ).$(_MIN).$(shell expr $(_PAT) + 1); \
-	git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _release TAG=$$NEW
+	git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _tag TAG=$$NEW
 
 minor:
 	@NEW=v$(_MAJ).$(shell expr $(_MIN) + 1).0; \
-	git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _release TAG=$$NEW
+	git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _tag TAG=$$NEW
 
 major:
 	@NEW=v$(shell expr $(_MAJ) + 1).0.0; \
-	git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _release TAG=$$NEW
+	git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _tag TAG=$$NEW
 
-_release:
+_tag:
 	git push origin $(TAG)
-	tea releases create --tag $(TAG) --title $(TAG)

main_test.go

@@ -354,11 +354,11 @@ func TestAllFactsForNode_QueryContainsCertname(t *testing.T) {
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		receivedQuery = r.URL.Query().Get("query")
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode([]fact{})
+		_ = json.NewEncoder(w).Encode([]fact{})
 	}))
 	defer srv.Close()
 
-	allFactsForNode(srv.URL+"/pdb/query/v4/facts", "mynode.example.com")
+	_, _ = allFactsForNode(srv.URL+"/pdb/query/v4/facts", "mynode.example.com")
 	if !strings.Contains(receivedQuery, "mynode.example.com") {
 		t.Fatalf("expected certname in query, got: %s", receivedQuery)
 	}
@@ -405,10 +405,10 @@ func TestRun_AllFacts_PrintsSortedByName(t *testing.T) {
 	cfg := config{PuppetDBURL: srv.URL + "/pdb/query/v4/facts", RoleFact: "enc_role"}
 	err := run(cfg, "node1", "", "", "", false, false, false, false, false, false, true)
 
-	w.Close()
+	_ = w.Close()
 	os.Stdout = old
 	var buf strings.Builder
-	io.Copy(&buf, r)
+	_, _ = io.Copy(&buf, r)
 	out := buf.String()
 
 	if err != nil {