fix: consul members role key

- moved members_role for consul to common yaml

hieradata/common.yaml

@@ -59,6 +59,7 @@ profiles::base::puppet_servers:
 profiles::dns::master::basedir: '/var/named/sources'
 profiles::dns::base::ns_role: 'roles::infra::dns::resolver'
 profiles::dns::base::use_ns: 'region'
+profiles::consul::server::members_role: roles::infra::storage::consul
 
 profiles::packages::install:
   - bash-completion

hieradata/roles/infra/storage/consul.yaml

@@ -1,5 +1,4 @@
 ---
-profiles::consul::server::members_role: roles::infra::storage::consul
 profiles::consul::server::members_lookup: true
 profiles::consul::server::data_dir: /data/consul
 profiles::consul::server::primary_datacenter: 'au-drw1'

site/profiles/manifests/consul/server.pp

@@ -47,6 +47,7 @@ class profiles::consul::server (
 
   # wait for all attributes to be ready
   if $facts['enc_role'] == $members_role {
+
     # set a datacentre/cluster name
     $consul_cluster = "${::facts['country']}-${::facts['region']}"