test: validate all metadata.yaml files against schema in pytest

refactor: use make test in pre-commit hook
feat: add pytest pre-commit hook and tests scaffold (issue #162 )
2026-05-17 12:32:46 +10:00 · 2026-05-17 12:30:35 +10:00 · 2026-05-17 12:30:35 +10:00 · 2026-05-17 12:30:35 +10:00 · 2026-05-17 12:29:10 +10:00 · 2026-05-16 23:36:13 +10:00
26 changed files with 485 additions and 27 deletions
@@ -31,6 +31,24 @@ repos:
            "-s",
          ]

+  - repo: local
+    hooks:
+      - id: pytest
+        name: Run unit tests
+        entry: make test
+        language: system
+        types: [python]
+        pass_filenames: false
+
+  - repo: https://github.com/python-jsonschema/check-jsonschema
+    rev: 0.37.2
+    hooks:
+      - id: check-jsonschema
+        name: Validate RPM package metadata
+        files: ^rpms/[^/]+/metadata\.yaml$
+        args: [--schemafile, schema/metadata.json]
+        language_version: python3.11
+
  - repo: https://github.com/astral-sh/ruff-pre-commit
    rev: v0.14.7
    hooks:
@@ -7,7 +7,6 @@ steps:
    commands:
      - mkdir -p /woodpecker/rpms
      - ln -s /woodpecker/rpms /workspace
-      - dnf install buildah -y
      - ./tools/build build-all --distro almalinux/el8 --buildah
    privileged: true
    backend_options:
@@ -7,7 +7,6 @@ steps:
    commands:
      - mkdir -p /woodpecker/rpms
      - ln -s /woodpecker/rpms /workspace
-      - dnf install buildah -y
      - ./tools/build build-all --distro almalinux/el9 --buildah
    privileged: true
    backend_options:
@@ -0,0 +1,26 @@
+when:
+  - event: pull_request
+
+steps:
+  - name: build rpms
+    image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    commands:
+      - mkdir -p /woodpecker/rpms
+      - ln -s /woodpecker/rpms /workspace
+      - ./tools/build build-all --distro fedora/42 --buildah
+    privileged: true
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 512Mi
+            cpu: 1
+          limits:
+            memory: 2Gi
+            cpu: 2
+
+  - name: show rpms
+    image: git.unkin.net/unkin/fedora42-base:latest
+    commands:
+      - find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"
@@ -0,0 +1,26 @@
+when:
+  - event: pull_request
+
+steps:
+  - name: build rpms
+    image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    commands:
+      - mkdir -p /woodpecker/rpms
+      - ln -s /woodpecker/rpms /workspace
+      - ./tools/build build-all --distro fedora/43 --buildah
+    privileged: true
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 512Mi
+            cpu: 1
+          limits:
+            memory: 2Gi
+            cpu: 2
+
+  - name: show rpms
+    image: git.unkin.net/unkin/fedora43-base:latest
+    commands:
+      - find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"
@@ -0,0 +1,26 @@
+when:
+  - event: pull_request
+
+steps:
+  - name: build rpms
+    image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    commands:
+      - mkdir -p /woodpecker/rpms
+      - ln -s /woodpecker/rpms /workspace
+      - ./tools/build build-all --distro fedora/44 --buildah
+    privileged: true
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 512Mi
+            cpu: 1
+          limits:
+            memory: 2Gi
+            cpu: 2
+
+  - name: show rpms
+    image: git.unkin.net/unkin/fedora44-base:latest
+    commands:
+      - find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"
@@ -8,7 +8,6 @@ steps:
    commands:
      - mkdir -p /woodpecker/rpms
      - ln -s /woodpecker/rpms /workspace
-      - dnf install buildah -y
      - ./tools/build build-all --distro almalinux/el8 --buildah
    privileged: true
    backend_options:
@@ -8,7 +8,6 @@ steps:
    commands:
      - mkdir -p /woodpecker/rpms
      - ln -s /woodpecker/rpms /workspace
-      - dnf install buildah -y
      - ./tools/build build-all --distro almalinux/el9 --buildah
    privileged: true
    backend_options:
@@ -0,0 +1,50 @@
+when:
+  - event: push
+    branch: master
+
+steps:
+  - name: build-rpms
+    image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    commands:
+      - mkdir -p /woodpecker/rpms
+      - ln -s /woodpecker/rpms /workspace
+      - ./tools/build build-all --distro fedora/42 --buildah
+    privileged: true
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 512Mi
+            cpu: 1
+          limits:
+            memory: 2Gi
+            cpu: 2
+
+  - name: show-rpms
+    image: git.unkin.net/unkin/fedora42-rpmbuilder:latest
+    commands:
+      - find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"
+    depends_on: [build-rpms]
+
+  - name: deploy-rpms
+    image: git.unkin.net/unkin/fedora42-rpmbuilder:latest
+    commands:
+      - |
+        for rpm in $(find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"); do
+          curl --user droneci:$${DRONECI_PASSWORD} --upload-file $rpm https://git.unkin.net/api/packages/unkin/rpm/fedora/42/upload
+        done
+    environment:
+      DRONECI_PASSWORD:
+        from_secret: DRONECI_PASSWORD
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 128Mi
+            cpu: 100m
+          limits:
+            memory: 512Mi
+            cpu: 500m
+    depends_on: [build-rpms, show-rpms]
@@ -0,0 +1,50 @@
+when:
+  - event: push
+    branch: master
+
+steps:
+  - name: build-rpms
+    image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    commands:
+      - mkdir -p /woodpecker/rpms
+      - ln -s /woodpecker/rpms /workspace
+      - ./tools/build build-all --distro fedora/43 --buildah
+    privileged: true
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 512Mi
+            cpu: 1
+          limits:
+            memory: 2Gi
+            cpu: 2
+
+  - name: show-rpms
+    image: git.unkin.net/unkin/fedora43-rpmbuilder:latest
+    commands:
+      - find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"
+    depends_on: [build-rpms]
+
+  - name: deploy-rpms
+    image: git.unkin.net/unkin/fedora43-rpmbuilder:latest
+    commands:
+      - |
+        for rpm in $(find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"); do
+          curl --user droneci:$${DRONECI_PASSWORD} --upload-file $rpm https://git.unkin.net/api/packages/unkin/rpm/fedora/43/upload
+        done
+    environment:
+      DRONECI_PASSWORD:
+        from_secret: DRONECI_PASSWORD
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 128Mi
+            cpu: 100m
+          limits:
+            memory: 512Mi
+            cpu: 500m
+    depends_on: [build-rpms, show-rpms]
@@ -0,0 +1,50 @@
+when:
+  - event: push
+    branch: master
+
+steps:
+  - name: build-rpms
+    image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    commands:
+      - mkdir -p /woodpecker/rpms
+      - ln -s /woodpecker/rpms /workspace
+      - ./tools/build build-all --distro fedora/44 --buildah
+    privileged: true
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 512Mi
+            cpu: 1
+          limits:
+            memory: 2Gi
+            cpu: 2
+
+  - name: show-rpms
+    image: git.unkin.net/unkin/fedora44-rpmbuilder:latest
+    commands:
+      - find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"
+    depends_on: [build-rpms]
+
+  - name: deploy-rpms
+    image: git.unkin.net/unkin/fedora44-rpmbuilder:latest
+    commands:
+      - |
+        for rpm in $(find /woodpecker/src/git.unkin.net/unkin/rpmbuilder/ -type f -name "*.rpm"); do
+          curl --user droneci:$${DRONECI_PASSWORD} --upload-file $rpm https://git.unkin.net/api/packages/unkin/rpm/fedora/44/upload
+        done
+    environment:
+      DRONECI_PASSWORD:
+        from_secret: DRONECI_PASSWORD
+    backend_options:
+      kubernetes:
+        serviceAccountName: default
+        resources:
+          requests:
+            memory: 128Mi
+            cpu: 100m
+          limits:
+            memory: 512Mi
+            cpu: 500m
+    depends_on: [build-rpms, show-rpms]
@@ -11,7 +11,7 @@ DISTRO ?= almalinux/el9
 PACKAGES := $(shell find $(ROOT_DIR)/rpms -mindepth 1 -maxdepth 1 -type d -exec test -f {}/metadata.yaml \; -print | xargs -n1 basename | sort)

 # Default target to build all packages
-.PHONY: all list build clean
+.PHONY: all list build clean test
 all: build-all

 # List all available packages
@@ -47,6 +47,10 @@ dry-run:
 	@echo "Dry run - showing what would be built for distro $(DISTRO):"
 	$(BUILD_TOOL) build-all --distro $(DISTRO) --dry-run

+# Run unit tests
+test:
+	@uv run --group dev pytest tests/ -q; rc=$$?; [ $$rc -eq 5 ] && exit 0 || exit $$rc
+
 # Clean target
 clean:
 	@echo "Cleaning build artifacts..."
@@ -0,0 +1,11 @@
+[project]
+name = "rpmbuilder"
+version = "0.1.0"
+requires-python = ">=3.11"
+
+[dependency-groups]
+dev = [
+    "pytest>=8",
+    "jsonschema>=4",
+    "pyyaml>=6",
+]
@@ -1,19 +1,18 @@
-arch: amd64
-builds:
- image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
-  release: 1
-  repository:
-  - almalinux/el8
-  version: 2.1.126
- image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
-  release: 1
-  repository:
-  - almalinux/el9
-  version: 2.1.126
-claude_ai: true
+name: claude-code
 description: Claude Code - Anthropic's agentic AI coding tool
+arch: amd64
+platform: linux
+maintainer: Anthropic
 homepage: https://claude.ai/code
 license: Proprietary
-maintainer: Anthropic
-name: claude-code
-platform: linux
+builds:
+- repository:
+  - almalinux/el8
+  image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
+  release: 1
+  version: 2.1.126
+- repository:
+  - almalinux/el9
+  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+  release: 1
+  version: 2.1.126
@@ -18,3 +18,10 @@ builds:
  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
  release: 1
  version: 1.22.7
+- repository:
+  - fedora/42
+  - fedora/43
+  - fedora/44
+  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+  release: 1
+  version: 1.22.7
@@ -18,3 +18,10 @@ builds:
  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
  release: 1
  version: 0.14.0
+- repository:
+  - fedora/42
+  - fedora/43
+  - fedora/44
+  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+  release: 1
+  version: 0.14.0
@@ -3,11 +3,20 @@ arch: amd64
 builds:
  - image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
    release: '1'
-    repository: [almalinux/el8]
+    repository:
+      - almalinux/el8
    version: 2025.07.13
  - image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
    release: '1'
-    repository: [almalinux/el9]
+    repository:
+      - almalinux/el9
+    version: 2025.07.13
+  - image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    release: '1'
+    repository:
+      - fedora/42
+      - fedora/43
+      - fedora/44
    version: 2025.07.13
 description: ca-certificates for the unkin site
 github: unknown/unkin-ca-certificates
@@ -11,9 +11,16 @@ builds:
  - almalinux/el8
  image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
  release: 1
-  version: 0.11.8
+  version: 0.11.14
 - repository:
  - almalinux/el9
  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
  release: 1
-  version: 0.11.8
+  version: 0.11.14
+- repository:
+  - fedora/42
+  - fedora/43
+  - fedora/44
+  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+  release: 1
+  version: 0.11.14
@@ -20,3 +20,10 @@ builds:
  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
  release: 1
  version: 2.0.0
+- repository:
+  - fedora/42
+  - fedora/43
+  - fedora/44
+  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+  release: 1
+  version: 2.0.0
@@ -3,11 +3,20 @@ arch: amd64
 builds:
  - image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
    release: '1'
-    repository: [almalinux/el8]
+    repository:
+      - almalinux/el8
    version: 0.25.3
  - image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
    release: '1'
-    repository: [almalinux/el9]
+    repository:
+      - almalinux/el9
+    version: 0.25.3
+  - repository:
+      - fedora/42
+      - fedora/43
+      - fedora/44
+    image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    release: 1
    version: 0.25.3
 description: A friendly and fast tool for sending HTTP requests (HTTPie reimplementation in Rust)
 github: ducaale/xh
@@ -18,3 +18,10 @@ builds:
  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
  release: 1
  version: 4.53.2
+- repository:
+  - fedora/42
+  - fedora/43
+  - fedora/44
+  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+  release: 1
+  version: 4.53.2
@@ -0,0 +1,111 @@
+{
+  "$schema": "http://json-schema.org/draft-07/schema#",
+  "additionalProperties": false,
+  "description": "Schema for rpms/*/metadata.yaml files",
+  "properties": {
+    "arch": {
+      "enum": [
+        "amd64",
+        "arm64",
+        "x86_64"
+      ],
+      "type": "string"
+    },
+    "builds": {
+      "items": {
+        "additionalProperties": false,
+        "properties": {
+          "image": {
+            "minLength": 1,
+            "pattern": "^[a-zA-Z0-9][a-zA-Z0-9\\-_.:/@]+$",
+            "type": "string"
+          },
+          "release": {
+            "oneOf": [
+              {
+                "minLength": 1,
+                "type": "string"
+              },
+              {
+                "type": "number"
+              }
+            ]
+          },
+          "repository": {
+            "items": {
+              "enum": [
+                "almalinux/el8",
+                "almalinux/el9",
+                "fedora/42",
+                "fedora/43",
+                "fedora/44"
+              ],
+              "type": "string"
+            },
+            "minItems": 1,
+            "type": "array"
+          },
+          "version": {
+            "minLength": 1,
+            "pattern": "^[0-9]+(\\.[0-9]+)*(-[a-zA-Z0-9]+)*$",
+            "type": "string"
+          }
+        },
+        "required": [
+          "repository",
+          "image",
+          "release",
+          "version"
+        ],
+        "type": "object"
+      },
+      "minItems": 1,
+      "type": "array"
+    },
+    "description": {
+      "minLength": 1,
+      "type": "string"
+    },
+    "dist_tag": {
+      "type": "boolean"
+    },
+    "github": {
+      "minLength": 1,
+      "pattern": "^[a-zA-Z0-9\\-_]+/[a-zA-Z0-9\\-_.]+$",
+      "type": "string"
+    },
+    "github_release_pattern": {
+      "minLength": 1,
+      "type": "string"
+    },
+    "homepage": {
+      "minLength": 1,
+      "pattern": "^https?://.+",
+      "type": "string"
+    },
+    "license": {
+      "minLength": 1,
+      "type": "string"
+    },
+    "maintainer": {
+      "minLength": 1,
+      "type": "string"
+    },
+    "name": {
+      "minLength": 1,
+      "pattern": "^[a-zA-Z0-9][a-zA-Z0-9\\-_.]*$",
+      "type": "string"
+    },
+    "platform": {
+      "minLength": 1,
+      "type": "string"
+    }
+  },
+  "required": [
+    "name",
+    "description",
+    "builds"
+  ],
+  "title": "RPM Package Metadata",
+  "type": "object"
+}
@@ -0,0 +1,2 @@
+# Tests for tools/build and tools/update-gh.
+# See https://git.unkin.net/unkin/rpmbuilder/issues/162
@@ -0,0 +1,36 @@
+"""Validate every rpms/*/metadata.yaml against schema/metadata.json."""
+
+import json
+from pathlib import Path
+
+import jsonschema
+import pytest
+import yaml
+
+REPO_ROOT = Path(__file__).parent.parent
+SCHEMA_FILE = REPO_ROOT / "schema" / "metadata.json"
+RPMS_DIR = REPO_ROOT / "rpms"
+
+
+@pytest.fixture(scope="session")
+def schema():
+    with open(SCHEMA_FILE) as f:
+        return json.load(f)
+
+
+def metadata_files():
+    return sorted(RPMS_DIR.glob("*/metadata.yaml"))
+
+
+@pytest.mark.parametrize("metadata_file", metadata_files(), ids=lambda p: p.parent.name)
+def test_metadata_valid(metadata_file, schema):
+    with open(metadata_file) as f:
+        data = yaml.safe_load(f)
+
+    validator = jsonschema.Draft7Validator(schema)
+    errors = sorted(validator.iter_errors(data), key=str)
+
+    assert not errors, "\n".join(
+        f"  {'.'.join(str(p) for p in e.absolute_path) or '(root)'}: {e.message}"
+        for e in errors
+    )
Author	SHA1	Message	Date
unkinben	db5a829429	test: validate all metadata.yaml files against schema in pytest ci/woodpecker/pr/build-fedora42 Pipeline was successful Details ci/woodpecker/pr/build-fedora44 Pipeline was successful Details ci/woodpecker/pr/build-fedora43 Pipeline was successful Details ci/woodpecker/pr/build-almalinux9 Pipeline was successful Details ci/woodpecker/pr/pre-commit Pipeline was successful Details ci/woodpecker/pr/build-almalinux8 Pipeline was successful Details	2026-05-17 12:32:46 +10:00
unkinben	ff34987784	refactor: use make test in pre-commit hook	2026-05-17 12:30:35 +10:00
unkinben	f46e8bfc0b	feat: add pytest pre-commit hook and tests scaffold (issue #162 ) - pyproject.toml with pytest>=8 in [dependency-groups.dev] so uv run --group dev pytest resolves without a global install - tests/__init__.py and tests/conftest.py skeleton referencing issue #162 - pre-commit local hook runs pytest tests/ on Python file changes; exit code 5 (no tests collected) is treated as success so commits are not blocked while the test suite is being built out	2026-05-17 12:30:35 +10:00
unkinben	26c399598c	feat: JSON Schema validation for metadata.yaml as pre-commit hook Adds schema/metadata.json (JSON Schema draft-07) as the authoritative schema for all rpms/*/metadata.yaml files. Key constraints: - additionalProperties: false at both the top level and builds items, so unknown fields are rejected outright - name allows dots (fixes neovim-glibc-2.17) - github is optional (fixes claude-code, which has no GitHub repo) - repository enum includes fedora/42, fedora/43, fedora/44 - dist_tag boolean field documented in schema Pre-commit hook (check-jsonschema 0.37.2) runs against every file matching ^rpms/[^/]+/metadata\.yaml$ on every commit. Also fixes rpms/claude-code/metadata.yaml: removes the unknown claude_ai field and normalises field order.	2026-05-17 12:30:35 +10:00
unkinben	aeea587aeb	fix: move unkin-undionly-kpxe preinstall.sh to scripts/ subdirectory (#166 ) ci/woodpecker/push/deploy-fedora42 Pipeline was successful Details ci/woodpecker/push/deploy-fedora43 Pipeline was successful Details ci/woodpecker/push/deploy-almalinux9 Pipeline was successful Details ci/woodpecker/push/deploy-fedora44 Pipeline was successful Details ci/woodpecker/push/deploy-almalinux8 Pipeline was successful Details nfpm.yaml referenced /app/resources/scripts/preinstall.sh but the file was at resources/preinstall.sh, causing the build to fail. Reviewed-on: #166	2026-05-17 12:29:10 +10:00
unkinben	96d0e25e94	feat: update pipelines (#160 ) ci/woodpecker/push/deploy-fedora44 Pipeline failed Details ci/woodpecker/push/deploy-fedora43 Pipeline was successful Details ci/woodpecker/push/deploy-almalinux9 Pipeline was successful Details ci/woodpecker/push/deploy-fedora42 Pipeline was successful Details ci/woodpecker/push/deploy-almalinux8 Pipeline was successful Details - remove buildah (now in image) - add fedora42/fedora43/fedora44 pipelines Reviewed-on: #160	2026-05-16 23:36:13 +10:00