feat/metadata-schema-validation #165

Merged

unkinben merged 4 commits from feat/metadata-schema-validation into master 2026-05-17 12:34:33 +10:00

Conversation 0 Commits 4 Files Changed 8

+198 -17

unkinben commented 2026-05-17 11:58:54 +10:00

Owner

Copy Link

Copy Source

No description provided.

unkinben added 4 commits 2026-05-17 11:58:55 +10:00

feat: JSON Schema validation for metadata.yaml as pre-commit hook ... be23a37c2e

Adds schema/metadata.json (JSON Schema draft-07) as the authoritative
schema for all rpms/*/metadata.yaml files.  Key constraints:

- additionalProperties: false at both the top level and builds items,
  so unknown fields are rejected outright
- name allows dots (fixes neovim-glibc-2.17)
- github is optional (fixes claude-code, which has no GitHub repo)
- repository enum includes fedora/42, fedora/43, fedora/44
- dist_tag boolean field documented in schema

Pre-commit hook (check-jsonschema 0.37.2) runs against every file
matching ^rpms/[^/]+/metadata\.yaml$ on every commit.

Also fixes rpms/claude-code/metadata.yaml: removes the unknown
claude_ai field and normalises field order.

feat: add pytest pre-commit hook and tests scaffold (issue #162) ... 451254447f

- pyproject.toml with pytest>=8 in [dependency-groups.dev] so
  uv run --group dev pytest resolves without a global install
- tests/__init__.py and tests/conftest.py skeleton referencing issue #162
- pre-commit local hook runs pytest tests/ on Python file changes;
  exit code 5 (no tests collected) is treated as success so commits
  are not blocked while the test suite is being built out

refactor: use make test in pre-commit hook fbb3471a42

test: validate all metadata.yaml files against schema in pytest c683858261

unkinben force-pushed feat/metadata-schema-validation from c683858261 to db5a829429 2026-05-17 12:32:54 +10:00 Compare

unkinben merged commit 539a63e0a1 into master 2026-05-17 12:34:33 +10:00

unkinben deleted branch feat/metadata-schema-validation 2026-05-17 12:34:34 +10:00

unkinben referenced this issue from a commit 2026-05-17 12:34:35 +10:00

feat/metadata-schema-validation (#165)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

benvin (BenVincent) droneci unkinben (Ben Vincent)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unkin/rpmbuilder#165