unkin/terraform-provider-artifactapi
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: strip v prefix from version in make install path #3

Merged
benvin merged 3 commits from benvin/fix-make-install-version into main 2026-06-21 22:34:40 +10:00
Conversation 0 Commits 3 Files Changed 4
+22 -3
unkinben commented 2026-06-21 22:08:00 +10:00
Owner
Copy Link
Copy Source

Summary

  • make install used the raw git tag (e.g. v0.0.2) in the plugin directory path, but Terraform expects bare version numbers (e.g. 0.0.2)
  • Adds INSTALL_VERSION that strips the v prefix before constructing the install path

Test plan

  • Run make install and verify the plugin lands in ~/.terraform.d/plugins/git.unkin.net/unkin/artifactapi/<version>/linux_amd64/ without the v prefix
## Summary - `make install` used the raw git tag (e.g. `v0.0.2`) in the plugin directory path, but Terraform expects bare version numbers (e.g. `0.0.2`) - Adds `INSTALL_VERSION` that strips the `v` prefix before constructing the install path ## Test plan - [ ] Run `make install` and verify the plugin lands in `~/.terraform.d/plugins/git.unkin.net/unkin/artifactapi/<version>/linux_amd64/` without the `v` prefix
unkinben added 1 commit 2026-06-21 22:08:00 +10:00
fix: strip v prefix from version in make install path
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
6446997a12 
Terraform plugin directory expects bare version numbers (e.g. 0.0.2)
but git tags use v-prefixed versions (e.g. v0.0.2).
unkinben added 1 commit 2026-06-21 22:17:26 +10:00
fix: pul_request tests only
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
d2da94cb52 
- update tests to run on pull request only
unkinben added 1 commit 2026-06-21 22:31:35 +10:00
feat: add pre-commit to build jobs
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
3d776f9e0f 
ensure pre-commit is run by woodpecker in ci
unkinben force-pushed benvin/fix-make-install-version from 02536dd4f0 to 3d776f9e0f 2026-06-21 22:31:35 +10:00 Compare
benvin merged commit e6d58ac2ee into main 2026-06-21 22:34:40 +10:00
benvin deleted branch benvin/fix-make-install-version 2026-06-21 22:34:40 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/terraform-provider-artifactapi#3
Delete Branch "benvin/fix-make-install-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?