unkin/terraform-provider-vault-secrets-arrstack
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Model apps as a set instead of an ordered list #2

Merged
benvin merged 1 commits from benvin/apps-set into main 2026-08-23 00:08:58 +10:00
Conversation 0 Commits 1 Files Changed 2
+32 -14
unkin-agent commented 2026-08-22 23:24:18 +10:00
Member
Copy Link
Copy Source

The arrstack engine returns apps alphabetically sorted regardless of the order they were written in, so modelling it as an ordered List makes any config whose order differs fail apply with "Provider produced inconsistent result after apply" and produce perpetual re-diffs. apps is semantically a set of app names, so it is now modelled as one.

  • Changes the apps attribute on arrstack_secret_backend_role from types.List/schema.ListAttribute to types.Set/schema.SetAttribute
  • Reads engine responses back via types.SetValueFrom
  • Updates unit tests for the set type and adds an order-insensitivity test proving a sorted engine response equals a differently-ordered config value
  • No other resources or data sources use the List-of-apps pattern
The arrstack engine returns `apps` alphabetically sorted regardless of the order they were written in, so modelling it as an ordered List makes any config whose order differs fail apply with "Provider produced inconsistent result after apply" and produce perpetual re-diffs. `apps` is semantically a set of app names, so it is now modelled as one. - Changes the `apps` attribute on `arrstack_secret_backend_role` from `types.List`/`schema.ListAttribute` to `types.Set`/`schema.SetAttribute` - Reads engine responses back via `types.SetValueFrom` - Updates unit tests for the set type and adds an order-insensitivity test proving a sorted engine response equals a differently-ordered config value - No other resources or data sources use the List-of-apps pattern
unkin-agent added 1 commit 2026-08-22 23:24:19 +10:00
Model apps as a set instead of an ordered list
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
98550e5b68 
The arrstack engine returns apps alphabetically sorted, so a List
attribute produces 'inconsistent result after apply' and perpetual
re-diffs whenever config order differs. apps is semantically a set.
benvin merged commit 35a1dcf7bb into main 2026-08-23 00:08:58 +10:00
benvin deleted branch benvin/apps-set 2026-08-23 00:08:58 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/terraform-provider-vault-secrets-arrstack#2
Delete Branch "benvin/apps-set"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?