unkin/tomswall
4
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases 5 Wiki Activity

Attach conntrack helpers via ct helper objects #25

Merged
benvin merged 2 commits from benvin/ct-helpers into main 2026-10-04 14:17:24 +11:00
Conversation 2 Commits 2 Files Changed 6
+339 -14
unkin-agent commented 2026-10-03 23:50:40 +10:00
Member
Copy Link
Copy Source

Shorewall CT:helper:<name> conntrack entries are migrated but never compiled, so FTP/SIP/TFTP and other ALG helpers are never attached.

  • declare a ct helper object per helper/proto, diffed in plan/apply and recreated in order on snapshot restore
  • attach with ct helper set rules in helper_prerouting/helper_output chains at mangle priority (after conntrack)
  • scope by source/dest zones with the same rules as notrack/drop entries; honour :P/:O (default both), proto and ports; default proto per known helper
  • ignore kernel-narrowed l3proto (pptp is IPv4-only) when diffing
Shorewall `CT:helper:<name>` conntrack entries are migrated but never compiled, so FTP/SIP/TFTP and other ALG helpers are never attached. - declare a `ct helper` object per helper/proto, diffed in plan/apply and recreated in order on snapshot restore - attach with `ct helper set` rules in `helper_prerouting`/`helper_output` chains at mangle priority (after conntrack) - scope by source/dest zones with the same rules as notrack/drop entries; honour `:P`/`:O` (default both), proto and ports; default proto per known helper - ignore kernel-narrowed l3proto (pptp is IPv4-only) when diffing
unkin-agent added 1 commit 2026-10-03 23:50:40 +10:00
Attach conntrack helpers via ct helper objects
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
c557c4b78a
unkin-agent commented 2026-10-03 23:52:39 +10:00
Author
Member
Copy Link
Copy Source
  • nit: internal/nftables/compiler.go:225 — ct.User (valid on output-chain helper rules) is silently dropped, so the helper is attached for all users with no warning (Source/Dest do warn) → include ct.User in the unsupported-scoping warning, or reject it for helper rules.
- nit: internal/nftables/compiler.go:225 — `ct.User` (valid on output-chain helper rules) is silently dropped, so the helper is attached for all users with no warning (Source/Dest do warn) → include `ct.User` in the unsupported-scoping warning, or reject it for helper rules.
unkin-agent added 1 commit 2026-10-04 13:58:27 +11:00
Merge remote-tracking branch 'origin/main' into benvin/ct-helpers
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
b85ba61fe6 
# Conflicts:
#	internal/nftables/compiler.go
#	internal/nftables/compiler_test.go
#	internal/nftables/engine.go
unkin-agent commented 2026-10-04 13:59:26 +11:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
benvin merged commit b849626a8c into main 2026-10-04 14:17:24 +11:00
benvin deleted branch benvin/ct-helpers 2026-10-04 14:17:24 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/tomswall#25
Delete Branch "benvin/ct-helpers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?