unkinben
a1ba86e76b
Raises statement coverage of the core packages (all of `internal/` except the interactive `tui/`, plus `pkg/`) from **8.7% to 90.1%**. ## Approach - **Pure-go unit tests** for all providers, virtual mergers, classifier, config, auth, models, and the API client (httptest). - **Testcontainers-backed** tests (new `internal/testsupport` helper: Postgres/Redis/MinIO, Ryuk disabled) for database, storage, cache, the proxy engine, the GC, and a full-stack `server` test that drives the whole HTTP API. These `t.Skip` when Docker is absent so `go test` still runs locally without it. ## Measuring ``` go test -coverpkg=./internal/...,./pkg/... -coverprofile=cover.out ./internal/... ./pkg/... grep -v /internal/tui/ cover.out | go tool cover -func=/dev/stdin | tail -1 # 90.1% ``` Run with `-p 1` (containers are heavy). ## Notes - The interactive `tui/` package and `cmd/main` are excluded from the target per the agreed scope. - Some defensive error branches are covered via fault injection (closed DB pool, killing MinIO mid-upload). Reviewed-on: #98 Co-authored-by: Ben Vincent <ben@unkin.net> Co-committed-by: Ben Vincent <ben@unkin.net>
79 lines
2.2 KiB
Go
79 lines
2.2 KiB
Go
package npm
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"git.unkin.net/unkin/artifactapi/internal/provider"
|
|
"git.unkin.net/unkin/artifactapi/pkg/models"
|
|
)
|
|
|
|
func TestType(t *testing.T) {
|
|
if (&Provider{}).Type() != models.PackageNPM {
|
|
t.Fatal("wrong type")
|
|
}
|
|
}
|
|
|
|
func TestClassify(t *testing.T) {
|
|
p := &Provider{}
|
|
if p.Classify("pkg/-/pkg-1.0.0.tgz") != provider.Immutable {
|
|
t.Error("tgz should be immutable")
|
|
}
|
|
if p.Classify("pkg") != provider.Mutable {
|
|
t.Error("metadata should be mutable")
|
|
}
|
|
}
|
|
|
|
func TestContentType(t *testing.T) {
|
|
p := &Provider{}
|
|
if p.ContentType("pkg/-/pkg-1.0.0.tgz") != "application/gzip" {
|
|
t.Error("tgz content type")
|
|
}
|
|
if p.ContentType("pkg") != "application/json" {
|
|
t.Error("metadata content type")
|
|
}
|
|
}
|
|
|
|
func TestUpstreamURL(t *testing.T) {
|
|
p := &Provider{}
|
|
got := p.UpstreamURL(models.Remote{BaseURL: "https://registry.npmjs.org/"}, "/pkg")
|
|
if got != "https://registry.npmjs.org/pkg" {
|
|
t.Errorf("got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestRewriteResponse(t *testing.T) {
|
|
p := &Provider{}
|
|
remote := models.Remote{Name: "npmjs", BaseURL: "https://registry.npmjs.org"}
|
|
|
|
if out, _ := p.RewriteResponse([]byte(`{"a":1}`), remote, ""); out != nil {
|
|
t.Error("empty proxyBaseURL should be a no-op")
|
|
}
|
|
if out, _ := p.RewriteResponse([]byte("not json"), remote, "http://proxy"); out != nil {
|
|
t.Error("invalid json should be a no-op")
|
|
}
|
|
body := []byte(`{"tarball":"https://registry.npmjs.org/pkg/-/pkg-1.0.0.tgz"}`)
|
|
out, err := p.RewriteResponse(body, remote, "http://proxy")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if string(out) != `{"tarball":"http://proxy/api/v1/remote/npmjs/pkg/-/pkg-1.0.0.tgz"}` {
|
|
t.Errorf("rewrite: %s", out)
|
|
}
|
|
if out, _ := p.RewriteResponse([]byte(`{"x":"unrelated"}`), remote, "http://proxy"); out != nil {
|
|
t.Error("no matching base URL should be a no-op")
|
|
}
|
|
}
|
|
|
|
func TestAuthHeaders(t *testing.T) {
|
|
p := &Provider{}
|
|
h, _ := p.AuthHeaders(context.Background(), models.Remote{Username: "u", Password: "pw"})
|
|
if h.Get("Authorization") == "" {
|
|
t.Error("expected auth header when credentials set")
|
|
}
|
|
h, _ = p.AuthHeaders(context.Background(), models.Remote{})
|
|
if h.Get("Authorization") != "" {
|
|
t.Error("expected no auth header without credentials")
|
|
}
|
|
}
|